Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp2220050rdb; Mon, 9 Oct 2023 17:51:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFiLy2Tpf2n6jqFPc4kGr5W8Cr+JtMiwnd4i4pI1wqrFuo5c7cYjxsjv8PYLq/vi8tusC/I X-Received: by 2002:a05:6a00:3906:b0:690:c75e:25d7 with SMTP id fh6-20020a056a00390600b00690c75e25d7mr15837070pfb.18.1696899116851; Mon, 09 Oct 2023 17:51:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696899116; cv=none; d=google.com; s=arc-20160816; b=EeB65RFMgr9gqvbIZ6YueIxk8S4RIuBXYbifSmqE/qhAuwKvP3aJ3C9zmbomVEjvhx vBWtpMnhKJ7TjBGvPKVdR0i3ACLykMMZOvPvU5MCjrBMme3cquoNZUAwNSWdSLYNT7A6 1MxvcbWDNfddGw+V5sOPp+ObAhg/QmWB6Eyq3Ovrgga/9fY744W99TahnClEyg4xb1Vs rQEFy005d0yQNU5WzIo6Z7tGOhp2/PktTNitwLkGQ1qB6FY6KFTsnciEM/h7i0652jCi 4mWKjzT40ZyWslTkjli4P+ohEMc5fZjATdXD+vX3ruvSUbbEHW44Yj+czAABEjOY2Jzv jXtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=A+jHWiY0otmijR8ARNJ3IA1ANTprjWNKtbNvj0UUJfg=; fh=KPPO4w/WNlKKcUme74fOJWAWFF+MJLt/bRW1ZZ7V1gk=; b=lZRG6OXcqSWGHxhDJGDUW5ybcxkMcQrUVT+FhglTSrlghNSoQwS7byXg5R4jeMT9uc 9K5PXAcarqhC9zR4SPqQa9mDp7UVEZvpK3Gc74t3L/sC/2tuJhCBz1wcZmF6EeLthUTP RdijlRzZx1mbYDDthVuqoir9Dn/bT48S05Izh0iasjud8U34aByH3c37J3hQiw5rvl1Y 92kNnfn5KT+5xe37WnckG5ob7+9lOnT89DBsZZwk3jPIDzS6sAB32CfDCOCoOZIj+fPw wdWqOJjjSB7AD60GIp1xanwcVDgA6kx0UCHwaXVbvUceS7datjVK6xR5+5i9w2QRZXqz vsKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=MMyOMzOq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id h70-20020a636c49000000b0058988340c60si8498111pgc.481.2023.10.09.17.51.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 17:51:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=MMyOMzOq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 12A608104390; Mon, 9 Oct 2023 17:51:56 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379309AbjJJAvr (ORCPT + 99 others); Mon, 9 Oct 2023 20:51:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379284AbjJJAvm (ORCPT ); Mon, 9 Oct 2023 20:51:42 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40AAAB4; Mon, 9 Oct 2023 17:51:41 -0700 (PDT) Received: from Monstersaurus.local (aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net [82.37.23.78]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2602BF0C; Tue, 10 Oct 2023 02:51:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1696899094; bh=gaWQ9+vNu5E0S40zJ98ILSdv6vdUDu9g/y/qreNcGv0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MMyOMzOqmHBulm0ToE9kVYxEO0YjWXyclZnxFwBpvNai2AoxgaXGaOn1UazmDH3uo /n6a74k3N1f7D4IyxySQ/3j8lfu9nxJ1Nyf5q0n6+khaMBAR40bexMNdzM9erTdk5g NT0QettZzdL69NvhbjQAtKGIg7W/AgQf9M87Q3l8= From: Kieran Bingham To: linux-media@vger.kernel.org, devicetree@vger.kernel.org Cc: Kieran Bingham , "Paul J. Murphy" , Daniele Alessandrelli , Sakari Ailus , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 4/5] media: i2c: imx335: Fix hblank min/max values Date: Tue, 10 Oct 2023 01:51:25 +0100 Message-Id: <20231010005126.3425444-5-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231010005126.3425444-1-kieran.bingham@ideasonboard.com> References: <20231010005126.3425444-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 09 Oct 2023 17:51:56 -0700 (PDT) The V4L2_CID_HBLANK control is marked as readonly and can only be a single value. Set the minimum and maximum value to match the mode value. Signed-off-by: Kieran Bingham --- drivers/media/i2c/imx335.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c index 026777eb362e..1a34b2a43718 100644 --- a/drivers/media/i2c/imx335.c +++ b/drivers/media/i2c/imx335.c @@ -1043,8 +1043,8 @@ static int imx335_init_controls(struct imx335 *imx335) imx335->hblank_ctrl = v4l2_ctrl_new_std(ctrl_hdlr, &imx335_ctrl_ops, V4L2_CID_HBLANK, - IMX335_REG_MIN, - IMX335_REG_MAX, + mode->hblank, + mode->hblank, 1, mode->hblank); if (imx335->hblank_ctrl) imx335->hblank_ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY; -- 2.34.1