Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
To:     Justin Stitt <justinstitt@google.com>
Cc:     Sathya Prakash <sathya.prakash@broadcom.com>,
        Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
        Suganath Prabu Subramani 
        <suganath-prabu.subramani@broadcom.com>,
        MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
        Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] scsi: message: fusion: replace deprecated strncpy with
 strscpy_pad
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq18r8bp8nf.fsf@ca-mkp.ca.oracle.com>
References: <20230927-strncpy-drivers-message-fusion-mptctl-c-v1-1-bb2eddc1743c@google.com>
Date:   Mon, 09 Oct 2023 21:29:32 -0400
In-Reply-To: <20230927-strncpy-drivers-message-fusion-mptctl-c-v1-1-bb2eddc1743c@google.com>
        (Justin Stitt's message of "Wed, 27 Sep 2023 04:06:09 +0000")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BT28aWWC06NIgnrLdEYjNfaY83ObkmPUMVZchy9vOewcihp6NLmtKBGuA293?=
 =?us-ascii?Q?l4YThfnIq0OTITrmt7piv+EEkF4E7PW2jb8OVesedXBU8kYeeZ/a6j7/90wY?=
 =?us-ascii?Q?XthGqMEClQt5131WRXmVOPpWD3+ujQxQF8tT3eXbz97TuTFROndNuOl4pq84?=
 =?us-ascii?Q?w96qooekSt3alEoAyMFO+LAV9IY/EV1kxXDwwBCsPoxvCrrLZmrU5Kxh8rMn?=
 =?us-ascii?Q?qdwSIskvFEkKd0Blod2beRkLRTyh99P1X88gOqgtWpG9HQeWMtgw9+3hj/JZ?=
 =?us-ascii?Q?486R9kHkIHGeHLAMh4k2FHJrZOlIMar16RZMUih8GNVrudylCxIgpSsXlPX4?=
 =?us-ascii?Q?s6RybyinFxa6aHN8QSuRn2jKVT/MeRf9sZAuva+PAlrdhOdhd4McxTN+HlTx?=
 =?us-ascii?Q?mZWO6A8wMRUjvfV9DOAZH46O2HtamCLD2hEt/LAqq7JjCCqILyqMmLtC56tZ?=
 =?us-ascii?Q?R3P3PXDcrHdBQDH64AnF95Mh6KIIBvSTeW0RR3bVQJOqan+0rAktuWnimFM2?=
 =?us-ascii?Q?jxDGLKO0K/2HIzHgZ5IB2LCAp6N79R5oquE8OnWaOF45eSLVhHXHEQJydS1w?=
 =?us-ascii?Q?EnWko1tzYVEqhHojaMHDN3ZQtZX8JkSBWZlI9mzFiFPLUBDi8PzrBIsZp1gL?=
 =?us-ascii?Q?ZL0P/lo6yaPFtQwL5sUTexn+Iv/s6bEZrUaPbXyuhDa0C6QMvcQdJwzTxD4b?=
 =?us-ascii?Q?4Wv3z6ERIcNgl0hFyNkJxOZ6DD6hhsZuoYl3qrO/DARJvAHtqFE1V7+PNYeI?=
 =?us-ascii?Q?TRUGL2qHnbm6s4qoRiUt88IcC4ryFx5OzZ9M1IykH5ksaNyu7XH7HLdmoN5R?=
 =?us-ascii?Q?Fnj7QpxfA+Vd2Cez3/KzOgQ8Hniqwa6Zca9Wbsra1gLKJOnAnzvOGFngMIry?=
 =?us-ascii?Q?63cEkBp+VwxGFLymY9hAszSFvaaHWrmRg8JkR17RdxnqrsXnByfJAEvy2QrV?=
 =?us-ascii?Q?O2tsWdNTcyHyPeY8ROGR0eHqJVo2rdkQIZRi1pYpSwsIqMwoO0IEoUB674wn?=
 =?us-ascii?Q?sxEJcBlKYo0ITdHtonl+Sb9x4GnbV6KufRilcsOs76qcnzwH8qOCYjaLclyB?=
 =?us-ascii?Q?vvAT2adwII4by50LLFMw70YsjENyszTOkLEB0Llbqx7ScaTc2P3Q4y3jgrey?=
 =?us-ascii?Q?SN0xFQWNadIR5n28VtzNeB2QWXyRrSogxekfBYF8s6SKUKDnqNBYlEhJ+tCE?=
 =?us-ascii?Q?D7SMfzURFbJP4aMd8pZciOTlhwf85tULgWhjWSY8fp9up5sAI2TjkwFXJhbZ?=
 =?us-ascii?Q?TEtMoFtqZNW9nxjYAArZSl4Lv4EWugBqadDSyf5ZrgYFMCeulf09QMBsGjcF?=
 =?us-ascii?Q?Mjzj6gwfSp+Huzi4d8lCPnWXblNkpOCFL05HKDoNa2J4dS4lyU1O2C1iJKlU?=
 =?us-ascii?Q?5e0VNIvbGCELBm4Y3tVmq4TBO5YwVKFyRroVh6fRLkaKYFHwvPcOM4/oJXUD?=
 =?us-ascii?Q?hyyUytseGzeTsslWKB+YGFmXpLhZpArYLB6iFFUjrkiBFCaayGqRjqzp7wSd?=
 =?us-ascii?Q?H3o6y/SWTabnBSMee4NcZN9ia1d5pQXGk7snpDY9LpKafWDJXikemlSuojn5?=
 =?us-ascii?Q?4//Eicy/Gr39HFd6QluajQ9CNnK+Ko01Q5fgNRqaV/4HGFzLNhpahcqm0G+j?=
 =?us-ascii?Q?xw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LnlLL9bobTKTWLBXeKkkQfxgGcLbYRNdLX4Y8V/yR/puizRtMhn2K5+ve5fcmDodQ+1pDYGHjDkK4jnmioc1t0wIzNBp+XWhXiZUVeVFjWIn0PYPxn0Fbe4NaOYoGf0yKdVI9OvPA29xQ7cch2UlXaX133y1eukkTRQQ7BvG4agbgevsww+Hp6iOveAJFuUg7YZzrCNnWp7OPbNSzxwikxceGrqwV4d/2QdvuGEXuH09pxOzn4QqYBj5fVkHqyeGUxCESMwAAqps4JBuyQbrA9AtjuwVbNHHIrIPO87t0zraTNiSLpvl4EJuF+GQsZHOSEKcaV+wR3VNNux5Eu6bP9RxYuDrcVj5NHHLRyMMl6yiBSoS47gVkZZXng8C8AuVartjErRj/PY6wcRFW9wk0c3F82GVKao5DWBFQ5YHt7fOkCcPACdwqUdOl3O9+c9hgRe1eKAs2tImEG2NtN+L2OOK28kBBJSGx7Nw6a09AaJ7o12dTVl4BTD25Q3YBBGGOoxN8kW3TNP97LKrQHqIIG6qpUrTv7gpPFoATQb6zGwsF8PPqelnP+fahJUbryJqpdBlC1AZWFRYLVgqpt7TgiYNznQM9e+kgmynn3BZDDmM4Qb41NxvQwWfnT53nA30FuxRif/Wq9tK48disHk5fdVQOU+MeszeAbMGBqC6QNwGOuMHKZZ2QZujSwPiacpwFrIwKSon6JBqHAwQCT8aYMsLDxI45GCBjN0ADwqL2I1ZdEAr5xfnZCBRMLjMeJzVOLcKsY5W49kwWsWRhdeCc7BhyMjYMog9Ztil42nuyI0czQpwOSx1dB0a/UNkImsfBkG1tEkivy/n72AmZIFhISOy5V4VvS+VUFNdxyb85Co=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1b9b32f-5586-423b-61a7-08dbc9305c16
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 01:29:34.4926
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yNpg/Xtbt651UvPv1ypFidRbcRXLcxRiy7WUob53k7N+KcJxAH0lNPu0CjTRjNLYtL6D2uK7lXgsplBKNulWOEulg8G7ZmVbqNCwmHrE6s4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6205
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-10_01,2023-10-09_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=787 mlxscore=0
 bulkscore=0 phishscore=0 suspectscore=0 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2310100009
X-Proofpoint-ORIG-GUID: t0snkqFKrQ7ociiW0RDX9jQYfb5m-AgM
X-Proofpoint-GUID: t0snkqFKrQ7ociiW0RDX9jQYfb5m-AgM
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 09 Oct 2023 18:30:01 -0700 (PDT)
X-Spam-Level: **


Justin,

> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.

Applied to 6.7/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering