Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
To:     Justin Stitt <justinstitt@google.com>
Cc:     Sathya Prakash <sathya.prakash@broadcom.com>,
        Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
        Suganath Prabu Subramani 
        <suganath-prabu.subramani@broadcom.com>,
        MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
        Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v2] scsi: message: fusion: replace deprecated strncpy
 with strscpy
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq134yjp8ju.fsf@ca-mkp.ca.oracle.com>
References: <20231003-strncpy-drivers-message-fusion-mptsas-c-v2-1-5ce07e60bd21@google.com>
Date:   Mon, 09 Oct 2023 21:31:42 -0400
In-Reply-To: <20231003-strncpy-drivers-message-fusion-mptsas-c-v2-1-5ce07e60bd21@google.com>
        (Justin Stitt's message of "Tue, 03 Oct 2023 22:15:45 +0000")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tjYdugkjGXRmwoGUTbC4z2nkR/lDoiZa8ygaC9mzWPxNrBFq6Q2UZ8p+WL+O?=
 =?us-ascii?Q?h6hM5tbBczTOWiytMfhL7xTFesiVuBpwZjRfnjPb7tXhNbytRFH+48jgliRm?=
 =?us-ascii?Q?5JGz3Geho6F4S2f5h62LWN6lXdPLwwqucgiR/kS2aev4/JgvaLf5Kk/p/Tgl?=
 =?us-ascii?Q?88vZpM8Md0hkdFgdtmRlFYgSC5tCC++KGMFDwYgTq6PtsZ7vSn4SivRe6oiw?=
 =?us-ascii?Q?5ii/AwUUfCjlOYRnZ20SSzci4nkDHHQG94C7S0vCyyr3nrZvsO0iYUlBuk9O?=
 =?us-ascii?Q?3GTRHvRkfTfw6ee4a3bGUH6l5ZToZyY3UUrnz/V1tJNVO1Beg+gdHs7O90bk?=
 =?us-ascii?Q?k9yjOcHaeeDD6wXVMh6YQFT+DwLNRC2bn3vWzBloaPtlzKsMF4znxezljiN+?=
 =?us-ascii?Q?AQgtCfq0yMtRVSIaYTo5IDeTp+Z1tMsSLTbT08F5qZhKm0gPlNDPmRm2VPNe?=
 =?us-ascii?Q?1ZIrIQkBohzI4u5ExPnQCFyyYqorkFolvN+A8xpYUexMA9+O6e7MBIRMRJNZ?=
 =?us-ascii?Q?B/qxEXo4JHpqWcLl6n+kL6m5LX47799FyJFMnhEDFmg7hrTEH3bm/e9/S/dk?=
 =?us-ascii?Q?yehLVfAPbvxaAtVxFw0B//yqYeytvmOYQrvjM82jCatz4O02TIgeqPP8u66s?=
 =?us-ascii?Q?fUqtIj0BKXmgtx6lHLGhTNA5tmzLM8I5fAOgrHjNmUw0ubMimHmzM9ARqI+h?=
 =?us-ascii?Q?KfSRCf8zGQRQj+dQvCxYNaSu3LtVk6KA9jREkTM/5ZAOg1HdG7lwbW35syyD?=
 =?us-ascii?Q?+qp9AFs3iAWXHu8KG53nfvo6FIHQwicsbX0LkpV4m7J6Sbr0lm5+D4ewj0UA?=
 =?us-ascii?Q?i9boG+J28ytRjTsnaBlLtC7vrmq11UiovqvEN2B7IOsCLB+uYPhkw2Jr5rpl?=
 =?us-ascii?Q?ZwztmsjOKOI+h4WwYGzckY5WW1tNwBvnAM0P48h4wWST0vEaoOEDsuLFAhgH?=
 =?us-ascii?Q?WSQKofqBCSrH1cw4obm6vhN8bJqZ9OryFlye/k1Y5h3qpzEkhQ6CeGxvDi35?=
 =?us-ascii?Q?nUu3Cn1Gg8rlNk8p0slPYF7PZTFJOflhQPZJEhNG5Iabc37Ncq3y9hbM8+FP?=
 =?us-ascii?Q?2n0MGIYTlshr4WYoAdvSzQhcwHCz4GVBW71xmrHui8ErLttW59/8Qli0zwqg?=
 =?us-ascii?Q?a+1hVymBkDMDqWdfJASNa9aIQk+TZznxWr0dSNJaEtEg1HTomlHBHh2xvHPn?=
 =?us-ascii?Q?NqrPOyd157pSNEYLV++lmbyak4dr7KNLyJZ/PEju/+Mrc3dLjCCb8Km8SXJ6?=
 =?us-ascii?Q?ryfuu10a+czOqe38gyv6IiSFxbcf5ZYrjGem8RnrqbgGd/W/E5w6xrEO17bS?=
 =?us-ascii?Q?0UQeUzJd9U7YF7NAnHEevMZA9PeTxb69mwlUebx+YnaW4t6YIcGxw6+Dovlv?=
 =?us-ascii?Q?vSXW180KyFWcJFUVxFP+7RC4y4qn5xhcNBZ/n4ka3+072TSEjkM0dN8an8oA?=
 =?us-ascii?Q?Nh4/35mWmZQ82FPb1ESAbbxX5UIUcYZI4Zd4gONzfAmboXG1APUvxJOrkdve?=
 =?us-ascii?Q?I/9Swzfjfl62g8NDXYzd79CsWX3mYjbfNcU/92aLjHb5W1PIuS4i4K7DEKvZ?=
 =?us-ascii?Q?QKg9fgY0eMljYBZfaexve2iwleuOddy10ADUyz5VyzpRoacuMj1+ABTM/Srb?=
 =?us-ascii?Q?Ug=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: fijZKHQgtVGhdspFBl3iB/O5cj5VOBSiO+KuxKNFg0z7fgWrZa+v3hBiYS7jfxq26/kgciNFCuGs5oTGiNwCit0/deii7TrZ679VKP3jdpxEDhzHrwqGRusCtooCsc3Gm8d7bwmZxCuHzGvQ1yYviqYyORLC8HjG01CBj0MJpgn3H78d0FT1Xo+iN9bdRlFFjcNIvoWbb80AstfxD4APq+6SqL1EPLgGeCUAx+zYJ1hNWjEWTJT9UZYwb6qgdtBja9mR8U2s+P4oQcegswG+y/CNb317aQmIibThtzcDxSiWm3cRYi+Q7dzkyD4nlWfkyw6jDhZGdSi3i68oa0HNnWVANBZRXK65G8J0VrLkXwy0UXfcV9hbUnuvCmh/SVSJ0SiPEOtfNCTvayQ7Ui8GeL5htwN2OlBAXl/LrRbyV6gqVjphMPrKmFDgjNYT7Dzw0ONOvhp8eYyRMSU5cjBlz/fHmK5BNXS+4po/IsueiQOhXeFZL3w63/E51QmOjl2afQVrU3PUd2Izjn0FPgd2aM/j3/sEY6pkLud//4kJL/T/BjWxfSzDdfn230O9QHtzo2eq7OZOZN0pMOrw0laTuNNYLL2oQz4vfm0nTfc/6OTOCGZjkGPRhw/aCUYRu5Xvy3NqjOhmVJzt9ckPW3SRtckNneYSxut5JpxgKCve1jLeKGcOyED7Dt0F6nFlfIE6acxx1Uk1fm7mLpaRXpMow6sje2+A2I94WzwSvvy6Y6dHd2VWOVqSTfMzL2k68YHJswSaNOy5MnjNIW/7a0L0QOqYPNJoB3azAYAY126izD5rIQPbSYd2iwXocZ0u+0vNtWtvVUNXtWagGQTyAxpqDGys/UiEGQ20IJQWN3sCRh8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32cf55fa-473d-4206-1982-08dbc930a9b5
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 01:31:44.7870
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PCBsTU8oUdV8SvEU2NAwOi/PoN6Pvhn9O5LEhL0tfCyy99NCCiekYGlzFCG5vj30HDyexuQJDh6bdWzWD8wpXDwEVh3s9y7utMaLbL0OT2M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6195
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-10_01,2023-10-09_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=792 suspectscore=0
 phishscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2309180000 definitions=main-2310100009
X-Proofpoint-ORIG-GUID: h-Zi8IDmEhVdQrX-HDSHHLleHWBETeLf
X-Proofpoint-GUID: h-Zi8IDmEhVdQrX-HDSHHLleHWBETeLf
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 09 Oct 2023 18:32:02 -0700 (PDT)


Justin,

> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.

Applied to 6.7/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering