Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp2247590rdb; Mon, 9 Oct 2023 19:20:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHJVy8MkmVXw5M2kfraN/g4XHKUz2OGvY/SVNkXElewKU+yurySCHr12liTECoTxqNK2vmL X-Received: by 2002:a05:6a20:ce9d:b0:154:4246:d63b with SMTP id if29-20020a056a20ce9d00b001544246d63bmr14282717pzb.25.1696904444073; Mon, 09 Oct 2023 19:20:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696904444; cv=none; d=google.com; s=arc-20160816; b=uEv+ZA0rGxj7VPl2OROyPeiYEYg0tpyw3jaSkQRRHHjFt2Bb2YWPVtFbCkYiH9TWPt ytf4T9Hun4hsGwIapY8LhQ7ynECqzx+5p9i0dbah0s6BWMRGaShiG/ZvzJVOo7wtqDzw SxUu8EcgR7culknMxcCiUQSqvF9WTcx/s1daOmxL9k0dHKiXcYqPz03AHwjUpW5Vi2Z+ aUG+8UZ5E4cJaXX2MXYSP3VcZjrtuzmci6guqLKbj4KcxxXr3MPP4KJcU7vKlekTMagG Q2lq0puGvKduMSafmuKG1B1OH7Rwyymk9pAdysO+Iah5UN5hrtlKnL7ePHf737IlvRk9 GDrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=BLXF/fLYuoRfmnKsuNRG5HxuDMqkxj/yEYOP3uSC5fg=; fh=5FWYcjNHzPoESfciJVXeQK2ZKNdfKIV00JCxOEhrsmI=; b=Fp5UXisOQSGiHllyMjGvrkOpCWdp7+lsKLz6IjUOrWSJe8gZcuimPzlKTKWF33bt8D F9P+sKIajGrXs1PvJdKAoucze3MXwnpjhoSUmeBmay+NnLAcF8Agom5qly6CDwiee9Gg 5m+NnGx30OJuHvSlFIfQow6Grbx9UDslC7ipnLQyyyqQ1jKJ3d3hHv73NfNZD4Ia+rjH F3cJL5dFbAVg4iNsRbgY9i0Ay0tbrFhILeEnAp8dxGMJ7HYvcCd38myC/Xb6bFQFl23Y ExkBJjKjku1/YuIetcNgyFe+NcWy5+xPXzaqoUZCYhLzeJFgDL1VIM1PE3HgBGV2AdUj UHdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id y15-20020a056a00180f00b0068e285eaa31si9383318pfa.259.2023.10.09.19.20.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 19:20:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id D33FB807CF43; Mon, 9 Oct 2023 19:20:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1441824AbjJJCUR (ORCPT + 99 others); Mon, 9 Oct 2023 22:20:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379400AbjJJCUQ (ORCPT ); Mon, 9 Oct 2023 22:20:16 -0400 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F01E9D for ; Mon, 9 Oct 2023 19:20:13 -0700 (PDT) X-UUID: 953745ecea834646b29c342a907ed9a8-20231010 X-CID-CACHE: Type:Local,Time:202310101010+08,HitQuantity:1 X-CID-O-RULE: Release_Ham X-CID-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.32,REQID:d1cb4757-7922-4b9a-8eeb-51f980972c7b,IP:15, URL:0,TC:0,Content:0,EDM:-30,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,AC TION:release,TS:-30 X-CID-INFO: VERSION:1.1.32,REQID:d1cb4757-7922-4b9a-8eeb-51f980972c7b,IP:15,UR L:0,TC:0,Content:0,EDM:-30,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-30 X-CID-META: VersionHash:5f78ec9,CLOUDID:24579cf0-9a6e-4c39-b73e-f2bc08ca3dc5,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:24|17|19|44|102,TC:nil,Content:0,EDM :2,IP:-2,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES :1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI,TF_CID_SPAM_SNR X-UUID: 953745ecea834646b29c342a907ed9a8-20231010 X-User: chentao@kylinos.cn Received: from localhost.localdomain [(116.128.244.169)] by mailgw (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 38406539; Tue, 10 Oct 2023 10:20:07 +0800 From: "Kunwu.Chan" To: evan.quan@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, lijo.lazar@amd.com, asad.kamal@amd.com, Hawking.Zhang@amd.com, kevinyang.wang@amd.com, le.ma@amd.com, dan.carpenter@linaro.org Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kunwu.chan@hotmail.com, "Kunwu.Chan" Subject: [PATCH] drm/amd/pm: Fix a memory leak on an error path Date: Tue, 10 Oct 2023 10:19:15 +0800 Message-Id: <20231010021915.36066-1-chentao@kylinos.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 09 Oct 2023 19:20:25 -0700 (PDT) X-Spam-Level: ** Add missing free on an error path. Signed-off-by: Kunwu.Chan --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c index ce971a93d28b..c26e12ff532c 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c @@ -1981,8 +1981,10 @@ static ssize_t smu_v13_0_6_get_gpu_metrics(struct smu_context *smu, void **table metrics = kzalloc(sizeof(MetricsTable_t), GFP_KERNEL); ret = smu_v13_0_6_get_metrics_table(smu, metrics, true); - if (ret) + if (ret) { + kfree(metrics); return ret; + } smu_cmn_init_soft_gpu_metrics(gpu_metrics, 1, 3); -- 2.25.1