DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=ms2.inr.ac.ru;
  b=pVgtaLH0RGVZsigfq9BeyniNvtNT9CSSQcFPS9ANjaVpPLHnyLbRRnVfFbuxpZfGeE447v7rO8wEnE1ULQKX3sgop8NxNujRJhRPab3MaQybYIzfa6vOcAmnRFQpIACA/RYcZqyjqvQ2Mc+S6ZxbLmFniTai7xxL9fNltBeRhiw=;
Date: Thu, 15 Nov 2007 18:40:32 +0300
From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
To: Jonas Danielsson <the.sator@gmail.com>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net, jmorris@namei.org,
       netdev@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 (was: Strange behavior in arp probe reply, bug or feature?)
Message-ID: <20071115154032.GA30391@ms2.inr.ac.ru>
References: <cac0ab7d0711150340p58eda94ah92894072ba328205@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cac0ab7d0711150340p58eda94ah92894072ba328205@mail.gmail.com>
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1132
Lines: 29

Hello!

> Send a correct arp reply instead of one with sender ip and sender
> hardware adress in target fields.

I do not see anything more legal in setting target address to 0.


Actually, semantics of target address in ARP reply is ambiguous.
If it is a reply to some real request, it is set to address of requestor
and protocol requires recipient of this arp reply to test that the address
matches its own address before creating new entry triggered by unsolicited
arp reply. That's all.

In the case of duplicate address detection, requestor does not have
any address, so that it is absolutely not essential what we use as target
address. The only place, which could depend on this is the tool, which
tests for duplicate address. At least, arping written by me, should
work with any variant.

So, please, could you explain what did force you to think that use of 0
is better?

Alexey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/