Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp2250599rdb; Mon, 9 Oct 2023 19:32:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH1Nixtt47HKCu4vS7xxmVn3wTUnKexcPWbWrwqwgCRkjbtSJYib/1c8qLvCd9CYVNRWprw X-Received: by 2002:a05:6a20:6a1a:b0:154:fb34:5f09 with SMTP id p26-20020a056a206a1a00b00154fb345f09mr20652248pzk.15.1696905138521; Mon, 09 Oct 2023 19:32:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696905138; cv=none; d=google.com; s=arc-20160816; b=ktm9ZzQoneBwruod+YuJuRtkMCGZ5DEt5pqLuiT234DN6wbZniKoXB/5aH3H45iAzi Rik5yZEbDRmu53zfI7LmkC01+4rkDUMf4lmQVX26vQwbfCPNh39iTfdMt7cxSe2PDhug eJYZLVC6lbGPEdlQoDYsRiKWJXf8FlFy9A90zFVr3PVzSmyQ4EjoUEjgMKEQigBl1lTU uJgHhrFCf2pGedxBeIQCcUU0s8zcZ8Pd4noNR+nCNALAkdVPghUerzRWMljCboScB7nD +jpHK0p7FvDXdnSkBLX5ZJyC5v4qkVzzkMwWpxX4akbo6HVPsnIWHiYu6u/Peq9WI10K 4xlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=1raKFNjtDmWZUZ53GoPC8fYThdZeXmJnPC3/HTIm7ao=; fh=4HMSUSnSCiYzr6IQtTmkLZp1yygCXwm5HFkghxRtwqk=; b=itGMCFIRO7IGAe21DWFwbmINE7TSLleNrQTpPku9dbK1l6bU7xfYdzT+r9gPZqDMCY /X7qSvJlKinUrvjkg8u8IbP99wss+TlIuf1kQpktrBON2KmMegzplfggVV1y4tRRP5wL AEcYi0zgG1wRQHFFyTrc3ohcdMNrYR8B2sp1bzefdz5Tn7+RgRt/lH4DBozPcgclFIC3 9SIX3jbT14NXGmDQClPdna9KQ7hHYQGIH7nVg08KEoy9b9kuhC9lzAv0E7it/rG4vJ9D iUz+yNHA4wC/yIXV+Pku9AMcyZ2QNsZbMMINIg/nr//hUJ8Impev5gKZkisn1X8jsOuh tGIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WKhfXdPX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id d12-20020a170902654c00b001c72476ca30si10524790pln.281.2023.10.09.19.32.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 19:32:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WKhfXdPX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id DD6E1809B74B; Mon, 9 Oct 2023 19:32:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1441843AbjJJCcD (ORCPT + 99 others); Mon, 9 Oct 2023 22:32:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232427AbjJJCcC (ORCPT ); Mon, 9 Oct 2023 22:32:02 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE0AB9E for ; Mon, 9 Oct 2023 19:32:00 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFE85C433C8; Tue, 10 Oct 2023 02:31:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696905120; bh=6o/kjifs3KbWaTn2Ziz1oUxyttEWW/VK6fOR+vDlP+M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WKhfXdPXd4hKZolc8afo6KCkwSDD6WhLH7rwXXpXObKidjQyYtNHlXwKqlcbFht/l wSvUEl5v49s7syQjj7ob+F+oZtM6fZywh61M8OXBU99PJvWytwTMkEVDlEyUcvCWKT 9cuFpsjbxbhENrXR4KrSumFHPs9OWoShBAMqSDjTqVMTfh9OuERP1e/8U/s7bKcxCy FOMAoC/WnBYBgYwmHAHnIZnztnl5w8KJW5DR/UN2U1diXMclcw1kSxGFdSLljTBBUk NGFp/71CmtFTHdOFu3vWO0CqLXZWKjQ1H8+eSfywLLCLpmy4B9cHa65BtqlK2FszRM vzMaETWwxpwOA== Date: Mon, 9 Oct 2023 19:31:58 -0700 From: Jakub Kicinski To: Breno Leitao Cc: jlbec@evilplan.org, davem@davemloft.net, pabeni@redhat.com, Eric Dumazet , hch@lst.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, horms@kernel.org Subject: Re: [PATCH net-next v2 1/3] netconsole: Initialize configfs_item for default targets Message-ID: <20231009193158.28a12cd8@kernel.org> In-Reply-To: <20231005123637.2685334-2-leitao@debian.org> References: <20231005123637.2685334-1-leitao@debian.org> <20231005123637.2685334-2-leitao@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 09 Oct 2023 19:32:11 -0700 (PDT) X-Spam-Level: ** On Thu, 5 Oct 2023 05:36:34 -0700 Breno Leitao wrote: > +static void populate_configfs_item(struct netconsole_target *nt, > + int cmdline_count); Could you move alloc / free_param_target() to avoid the forward declaration? (separate patch)