Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Tue, 10 Oct 2023 11:01:09 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     Meng Li <li.meng@amd.com>
Cc:     "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Huang, Shimmer" <Shimmer.Huang@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH V8 0/7] amd-pstate preferred core
Message-ID: <ZSS+dZKdAGyTbCex@amd.com>
References: <20231009024932.2563622-1-li.meng@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231009024932.2563622-1-li.meng@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2NANINmLvcE8i5FAQeVpxV+2zdRKIoT/MVoLDeI697ZJ5CwhqK1LXbB+p24F?=
 =?us-ascii?Q?MjBomvLYz5eJ/Xr+k8nL7Yrc1Tl4SfvjVIcC8U6Ak71RMeMZrWvD3iJfYKAB?=
 =?us-ascii?Q?sb4JTyTdh1w5xeOrU0P2V7GAoGiJMsd4BPIOnwBZLCw1Uw8vC+rPqfP1YWFb?=
 =?us-ascii?Q?weBtFZ+QgzeSAFubd4aJkOOuGvyZZJQ0iCQqJF6Vax4P/NnL54AV9bEHQgo3?=
 =?us-ascii?Q?eGjeEMnIGU1tSH93qMt4ArWLYCs+A3CKR8OO2rOuOxK+IrexsOHrdmP7NnAZ?=
 =?us-ascii?Q?EsytyGn3b+yq/CWOyTcQ2KUpdJV3oEaHOq+PbLo0OJg050caPDhzWJWt+ihs?=
 =?us-ascii?Q?Fzgd0hyBTCHaXeDkKR8Zucsyw0H87faUDC42xF9CC0Ik1fqKGqNtwwjdh7xi?=
 =?us-ascii?Q?r2U3PHHbIGZVJ05e1lWBESgp80f48V7b5ZPNFWVplK5grFgyRn8Mhijo0q95?=
 =?us-ascii?Q?nxwjRDBPUTNjMp02NUW9mx0FE3XYrjv9Z0+S8XDoXJG7xUzj3FQ1l3xoMycT?=
 =?us-ascii?Q?0ibOm7yBNrcC5i9UT20fr7mBSpLD0oBtdd4KuFKD217tWe+unIH2lgSFPtp4?=
 =?us-ascii?Q?HhH4IEPkDHd/E7ZBqMfWGv9eJz47cAkWbwf7doZrq7i7BfdJpWCKrnQPSnt1?=
 =?us-ascii?Q?/h9zSydA8fy+AKw0TGQuYeLTB5nHEQ2qjIZ/F3YrSLipGUAQbrLlCMhF2nI9?=
 =?us-ascii?Q?Tup3490ppjdXon5hGM+wBRV7zK2dXDf84dO5WbxzAypOj1jXb3kOBioHtLys?=
 =?us-ascii?Q?M+p8+shyScOjP1eotuHggSsQvKhLJuw89I47HvM4B9r9t4y6NZ3TD7mUibbV?=
 =?us-ascii?Q?ZnkZkskHycEZgkoAI4Pu6RIICWTdQ1XfKFFe8TT89EJUgT495a1pwO6qniWo?=
 =?us-ascii?Q?LzD+3b5LCgRR+h/pjO7P2f9wK2TxML9tlDclr1S4MdyoQnzGQDpVTP6RcJXR?=
 =?us-ascii?Q?6oH7r3ZO8bgrlP5eUIIPy7yMHsiRNIRp8yQOGBxPFq7czxtOUiIkeWo83R8h?=
 =?us-ascii?Q?T0k234yJ33dEDZh3arbd1rKtuTcLuxzL9L5K0dFH+dQuUsbuffwPw55jyefj?=
 =?us-ascii?Q?GNxQj+IBpVQfLmQNcAY9CEEqFzCa4ut0l4IFdX1bO/vlSSjjnHubL69MZPfz?=
 =?us-ascii?Q?ax8UmwlRECNDep35yw1Hvxr1hUlcj68Ba421YIOiuZVlByUZib9FGoVQ/n/a?=
 =?us-ascii?Q?+jTAQVCA1eoOy5pTeXbSfp778/Tm8zJLIRoqiLnHJiqV4o5UqSAj23JogQo7?=
 =?us-ascii?Q?WcqanxtZ/8xXbxNCJP9nUzTWn2ZQ0MiB24Yyy5ZDOQNkx8YdsupHvQ92Jirn?=
 =?us-ascii?Q?u5U1Sh7ieUPbrcWVNP1AhnQCn/YP/CVvtqn0v8zJ8Gm8YeXAz9Q3hM+yLaCm?=
 =?us-ascii?Q?sOVLf8UZzNKO+xBLfn+zl026rA9BzcR3MUE30bj4imltCtsZRuthXYvJg1jm?=
 =?us-ascii?Q?uHnWoYTtDeNvKQj5gsWabBuZdZxV4jOzBBy3OE7z5FasxeweThcjQgsjvHsN?=
 =?us-ascii?Q?QcFXwBDd+DaK7IrXSaRXhvALknXFZXIUXE8XnGmC2X6djOHDv14qe8yPwa2d?=
 =?us-ascii?Q?YMlLYa0u851GYzNJnFErD2zU5MoSkFt7ewNjpwdF?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74a5cfa9-77a7-4f71-d901-08dbc93d3508
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8690.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 03:01:32.4466
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QzW7lFjUsGRFH1RjhkIVRTxu/29KR0WDWihlJ0LYzhwSitx2TCToyomIBWePQUaaYaskehQuQ50vcQxm0wSn7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4382
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 09 Oct 2023 20:02:05 -0700 (PDT)
X-Spam-Level: **

On Mon, Oct 09, 2023 at 10:49:25AM +0800, Meng Li wrote:
> Hi all:
> 
> The core frequency is subjected to the process variation in semiconductors.
> Not all cores are able to reach the maximum frequency respecting the
> infrastructure limits. Consequently, AMD has redefined the concept of
> maximum frequency of a part. This means that a fraction of cores can reach
> maximum frequency. To find the best process scheduling policy for a given
> scenario, OS needs to know the core ordering informed by the platform through
> highest performance capability register of the CPPC interface.
> 
> Earlier implementations of amd-pstate preferred core only support a static
> core ranking and targeted performance. Now it has the ability to dynamically
> change the preferred core based on the workload and platform conditions and
> accounting for thermals and aging.
> 
> Amd-pstate driver utilizes the functions and data structures provided by
> the ITMT architecture to enable the scheduler to favor scheduling on cores
> which can be get a higher frequency with lower voltage.
> We call it amd-pstate preferred core.
> 
> Here sched_set_itmt_core_prio() is called to set priorities and
> sched_set_itmt_support() is called to enable ITMT feature.
> Amd-pstate driver uses the highest performance value to indicate
> the priority of CPU. The higher value has a higher priority.
> 
> Amd-pstate driver will provide an initial core ordering at boot time.
> It relies on the CPPC interface to communicate the core ranking to the
> operating system and scheduler to make sure that OS is choosing the cores
> with highest performance firstly for scheduling the process. When amd-pstate
> driver receives a message with the highest performance change, it will
> update the core ranking.
> 
> Changes form V7->V8:
> - all:
> - - pick up Review-By flag added by Mario and Ray.
> - cpufreq: amd-pstate:
> - - use hw_prefcore embeds into cpudata structure.
> - - delete preferred core init from cpu online/off.

Thanks!

Series are Reviewed-by: Huang Rui <ray.huang@amd.com>

> 
> Changes form V6->V7:
> - x86:
> - - Modify kconfig about X86_AMD_PSTATE.
> - cpufreq: amd-pstate:
> - - modify incorrect comments about scheduler_work().
> - - convert highest_perf data type.
> - - modify preferred core init when cpu init and online.
> - acpi: cppc:
> - - modify link of CPPC highest performance.
> - cpufreq:
> - - modify link of CPPC highest performance changed.
> 
> Changes form V5->V6:
> - cpufreq: amd-pstate:
> - - modify the wrong tag order.
> - - modify warning about hw_prefcore sysfs attribute.
> - - delete duplicate comments.
> - - modify the variable name cppc_highest_perf to prefcore_ranking.
> - - modify judgment conditions for setting highest_perf.
> - - modify sysfs attribute for CPPC highest perf to pr_debug message.
> - Documentation: amd-pstate:
> - - modify warning: title underline too short.
> 
> Changes form V4->V5:
> - cpufreq: amd-pstate:
> - - modify sysfs attribute for CPPC highest perf.
> - - modify warning about comments
> - - rebase linux-next
> - cpufreq: 
> - - Moidfy warning about function declarations.
> - Documentation: amd-pstate:
> - - align with ``amd-pstat``
> 
> Changes form V3->V4:
> - Documentation: amd-pstate:
> - - Modify inappropriate descriptions.
> 
> Changes form V2->V3:
> - x86:
> - - Modify kconfig and description.
> - cpufreq: amd-pstate: 
> - - Add Co-developed-by tag in commit message.
> - cpufreq:
> - - Modify commit message.
> - Documentation: amd-pstate:
> - - Modify inappropriate descriptions.
> 
> Changes form V1->V2:
> - acpi: cppc:
> - - Add reference link.
> - cpufreq:
> - - Moidfy link error.
> - cpufreq: amd-pstate: 
> - - Init the priorities of all online CPUs
> - - Use a single variable to represent the status of preferred core.
> - Documentation:
> - - Default enabled preferred core.
> - Documentation: amd-pstate: 
> - - Modify inappropriate descriptions.
> - - Default enabled preferred core.
> - - Use a single variable to represent the status of preferred core.
> 
> Meng Li (7):
>   x86: Drop CPU_SUP_INTEL from SCHED_MC_PRIO for the expansion.
>   acpi: cppc: Add get the highest performance cppc control
>   cpufreq: amd-pstate: Enable amd-pstate preferred core supporting.
>   cpufreq: Add a notification message that the highest perf has changed
>   cpufreq: amd-pstate: Update amd-pstate preferred core ranking
>     dynamically
>   Documentation: amd-pstate: introduce amd-pstate preferred core
>   Documentation: introduce amd-pstate preferrd core mode kernel command
>     line options
> 
>  .../admin-guide/kernel-parameters.txt         |   5 +
>  Documentation/admin-guide/pm/amd-pstate.rst   |  59 +++++-
>  arch/x86/Kconfig                              |   5 +-
>  drivers/acpi/cppc_acpi.c                      |  13 ++
>  drivers/acpi/processor_driver.c               |   6 +
>  drivers/cpufreq/amd-pstate.c                  | 186 ++++++++++++++++--
>  drivers/cpufreq/cpufreq.c                     |  13 ++
>  include/acpi/cppc_acpi.h                      |   5 +
>  include/linux/amd-pstate.h                    |  10 +
>  include/linux/cpufreq.h                       |   5 +
>  10 files changed, 285 insertions(+), 22 deletions(-)
> 
> -- 
> 2.34.1
>