Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp2265234rdb; Mon, 9 Oct 2023 20:24:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFLFW4I+Cqgk8eyKEDquJ6ypVRV5XSFTFNd7yk6xNNmPkFllM7QL5gxpHv2HavqIHMd8dYZ X-Received: by 2002:a17:903:24d:b0:1bd:c7e2:462 with SMTP id j13-20020a170903024d00b001bdc7e20462mr16991441plh.11.1696908270024; Mon, 09 Oct 2023 20:24:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696908270; cv=none; d=google.com; s=arc-20160816; b=WD+U7loys7L3Y9YA/UK4L5Og/HvqaPzDVeX7o3hSEvob3N22vzm8bBTkjaIXSoE/ya Jrt7ipy23h/mD0zHJgrOYb0nCmGCbDTz/gsD0PdnjFD7SKE0JiY3W4NBGll7ke3eBZPB ak39/lnLHC8yBy4tx6qsSMZEl0xmzfhpgdhGrk6nZhlPAmdZr1vgG2UL3nv2cpwd3dfy i1VBREu3IG82N6mRVJLzgcBMxsfF324OuactQjHXasFtZNc/9lZRRafEcx/TQKdzj2Hi m5Vtw9aTSbkAshFek/voLNlhVC1CP9NLiV7Y/9j7y6agCx5PykfB+xfY4udoLLORdqao 0QUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:references :in-reply-to:message-id:date; bh=QjcK9ViUAuI+FjH6k6suopZnQpSb9hmla9tuw3QrIDM=; fh=g66mwGaaEwasfANWCPBZJhFXmC0KrsU+d88cLge1kZM=; b=mhktiVvB5ZUqEYjPfm3nmUkxgMo0bvkD3Ggwfy3RPhcPKFGnoOuA7EpoURa/tdC69I ntwSTB5Z+CKp0hEDk5LgEC10EiLHK1b6gTs1ev7Y4FMLFu6y9+bZjdGmqmMJVQpqDWPq tKmE0xEQuF2VPGPm16qQBphYnG1reKR9AxUEUFH98Ud4Ge8Eidbb/wR/E/e99dnVX4gG hCkKIgLesCB4UzLjgCF7f3JI2GU7n6mVQL8WvIfXFpTJezuYk6RwjWxysxaw5v3Ep0Cb Cj5HFPNSY0tRfuQ9LtLoffihC+63hgKIUikwCHewI74qB7iG6OmpFhCWL1mPk3TSds8W 6Bdw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id li13-20020a170903294d00b001c6182d7d43si10586249plb.21.2023.10.09.20.24.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 20:24:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id A3D4581FADB2; Mon, 9 Oct 2023 20:24:27 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1441980AbjJJDYQ (ORCPT + 99 others); Mon, 9 Oct 2023 23:24:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1441983AbjJJDYP (ORCPT ); Mon, 9 Oct 2023 23:24:15 -0400 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC58BAC for ; Mon, 9 Oct 2023 20:24:13 -0700 (PDT) Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4S4Lpy1sYCz8XrRG; Tue, 10 Oct 2023 11:24:10 +0800 (CST) Received: from szxlzmapp06.zte.com.cn ([10.5.230.252]) by mse-fl1.zte.com.cn with SMTP id 39A3O1FY006580; Tue, 10 Oct 2023 11:24:01 +0800 (+08) (envelope-from yang.yang29@zte.com.cn) Received: from mapi (szxlzmapp03[null]) by mapi (Zmail) with MAPI id mid14; Tue, 10 Oct 2023 11:24:03 +0800 (CST) Date: Tue, 10 Oct 2023 11:24:03 +0800 (CST) X-Zmail-TransId: 2b056524c3d3ffffffffb7a-bc80c X-Mailer: Zmail v1.0 Message-ID: <202310101124033093148@zte.com.cn> In-Reply-To: References: ZSPayGSz6HQBp+3W@gmail.com,202310092030430136422@zte.com.cn,ZSP3cuEsgwWcIKRw@gmail.com,CAJuCfpFabCn8gcuLV322RKC=xzVm0C+64HQP+CkFNJZ4VO42ZA@mail.gmail.com Mime-Version: 1.0 From: To: , , , Cc: , , Subject: =?UTF-8?B?W1BBVENIIGxpbnV4LW5leHQgdjIgMy80XcKgc2NoZWQvcHNpOiB1cGRhdGUgcnRwb2xsX25leHRfdXBkYXRlIGFmdGVyIHVwZGF0ZQogdHJpZ2dlcnMgYW5kIHJ0cG9sbF90b3RhbA==?= Content-Type: text/plain; charset="UTF-8" X-MAIL: mse-fl1.zte.com.cn 39A3O1FY006580 X-Fangmail-Gw-Spam-Type: 0 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 6524C3DA.000/4S4Lpy1sYCz8XrRG X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 09 Oct 2023 20:24:27 -0700 (PDT) X-Spam-Level: ** From: Yang Yang Update group->rtpoll_next_update after called update_triggers() and update rtpoll_total. This will prevent bugs if update_triggers() uses group->rtpoll_next_update in the future, and it makes more sense to set the next update time after we finished the current update. Signed-off-by: Yang Yang Suggested-by: Suren Baghdasaryan --- kernel/sched/psi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c index 143f8eb34f9d..79f8db0c6150 100644 --- a/kernel/sched/psi.c +++ b/kernel/sched/psi.c @@ -704,12 +704,12 @@ static void psi_rtpoll_work(struct psi_group *group) } if (now >= group->rtpoll_next_update) { - group->rtpoll_next_update = now + group->rtpoll_min_period; if (changed_states & group->rtpoll_states) { update_triggers(group, now, &update_total, PSI_POLL); memcpy(group->rtpoll_total, group->total[PSI_POLL], sizeof(group->rtpoll_total)); } + group->rtpoll_next_update = now + group->rtpoll_min_period; } psi_schedule_rtpoll_work(group, -- 2.25.1