Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <b46467de-8ddf-4ff5-a133-c18613d2a34b@amperemail.onmicrosoft.com>
Date:   Tue, 10 Oct 2023 10:28:19 +0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/7] ARM: dts: aspeed: mtmitchell: Add LEDs
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Chanh Nguyen <chanh@os.amperecomputing.com>,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
References: <20231005035525.19036-1-chanh@os.amperecomputing.com>
 <20231005035525.19036-5-chanh@os.amperecomputing.com>
 <65a610df-5030-4dd0-9f04-2089dfe09a3d@linaro.org>
Content-Language: en-US
From:   Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
In-Reply-To: <65a610df-5030-4dd0-9f04-2089dfe09a3d@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekVXbG8rOGNqRW54c3lLWFU4Y3d3L0tIZTdsRXJGQkR3UlhObWJJNXVoZTFL?=
 =?utf-8?B?bkhtNmxWMk5YNVZtYWRoeWMxekV5R2tZNnhZSi9EU0UvcjNjYXlISDJtck9K?=
 =?utf-8?B?amxUVmRkU2g4ZkpxdGZQOCtBZmZMK3Y0Rk5vdUVyTGdLNTEvQlNYR3hYakZD?=
 =?utf-8?B?TDBSN1Y2dnpWU0FGcFYzMFI3SjBLMzRTa2RUaDdweDUxcHdmSTkwWlFhSHNv?=
 =?utf-8?B?SVRrbjNjY2JJeE9xRndwN2tOVjR6QXVSVktiYk5UeWMvN1pnSEdzR3FadjJS?=
 =?utf-8?B?VDZuSWc2aWw2MWQveFdJUFc5cUhhQmo0Sjd4NDhJMWRndnpWV3pEeElOOUFh?=
 =?utf-8?B?QkFzVTRFc3ByM2xjYTNMcHpvS1Qvb0RPSHZjNkhmKy95cGN5dVh3ZHFvUVls?=
 =?utf-8?B?b3lwYUl4bDdvbzkrU0dFMzVGdUdXRXJpQXBOS0ttMUtCOUNZMXQ1cUFkVGFS?=
 =?utf-8?B?U2EzbVBZckJIS1pzZWRHK1VGQXJYeVBDTWF1MTdzbnpuVktISHJ3bU8vdzBx?=
 =?utf-8?B?emVQOElkTnBDNFg3QTZvY1JVdDZUYzJLdjhGZVdXVXFMV2FoWTJkc2JGRzlU?=
 =?utf-8?B?TGRyNlVPL0xCZGZsUldFaStySjM4aVBOc0l6V0xyOEZwajJBSUpsaHhSSXhy?=
 =?utf-8?B?Y0FXbW5xWGJheUlKVWlWZHJUKzJFZVNycTZuNWlvNnhnMkxrYVg1TjVvN21H?=
 =?utf-8?B?UzZGTFhKQ0hNeTdBOUtIR1pxc1JiMCtvUjd1Y1VJR2ZLb2d1ZjFzQy9tZHZH?=
 =?utf-8?B?WUFwUEF6RFhzd1lhZ3FWbUhMZVAzUlhuYm52RmIrWUFPSkthNlBMR1FHRU9C?=
 =?utf-8?B?TWhjRUlpU1I0SUoya2IzUkJHK1pwMi8yNGQvckVOSnFZMFRXOFg4am54TUtM?=
 =?utf-8?B?SUcyYzQyRmc5YWc4Y0ZjSnNxOGJDSnRhcEtXS1J4WG5YNGxnY0ZMZXZLMGh1?=
 =?utf-8?B?NlNRcmdnRXlTaWoxRHBsSlROM0xYOHp5S3drWWdhdkhnTlpucFFGWGFtZSt1?=
 =?utf-8?B?bVJBNk1sUWd2RFk3bXNQN09IRmp1cDZxMjhTaVlMeDNGUHJ1UHVZOHQrRkFR?=
 =?utf-8?B?bWpEN2g5MnZlMHhoU2c0R3NZMWd3QUtaTk54WkJ3QWN5Q3V5Qm5mbDRLd05m?=
 =?utf-8?B?L0V6djBoREVEK1pJVWV1aGxBazFkdGxpZHNMSGVQTGtzZzkxRlhVN2hVWFVJ?=
 =?utf-8?B?MlNYcHg5YjlGSlhYWWxudGp5SlBoVnVHZkFTc1FqbkduS2RpRXc1cUZwQWdQ?=
 =?utf-8?B?L2syNjNlYjZyamJXK09wK2UzU2dEa014TkphbWJHb0crY290ajUxVm9vMEdZ?=
 =?utf-8?B?ZHl1d1gzcHZQTkpLbHZCK25mbXpNOEJtR1RkdmZLQXcwR1JoVmZteENaUjBp?=
 =?utf-8?B?c2hzT2VCSTNDTVRlOE5zOTE4OE9hR0g4VXNYK1d5ei9XWjJnTFRtUkpDQWZY?=
 =?utf-8?B?cVZQamlzZzZlT2NUU0FodU0rRmx6dlNZakNpd0JIWHRYRTRZdUowQzNBL05u?=
 =?utf-8?B?Zk5HM1M1ZTg1ZUVDWGtEbzBIM3F0VHgycXY3QTl6VEF6b2Zwc2ZmWFRobFRI?=
 =?utf-8?B?dW9tcXRWTHE4THIrQThxWmdiQlZCVTgrY2JpcmI5ZC9RdUtWaDFWazl6YUg5?=
 =?utf-8?B?SWFsajZkRHZFcm1iNGxTWlVtYWF0K3VZOHphZk5NM0gvNDRYTjkxMTNpUXA4?=
 =?utf-8?B?QWJxUmp4aVZKa0VvbmZHZUE1Lyt2QklqMG1HK3R2M05FRktjK2NZVWd2TmVi?=
 =?utf-8?B?QVFiUHBGOG5wc3VwR05FRFUzQmcwT1l1OFpUZlk0bkxkVk9mWG4xSGtPYUJH?=
 =?utf-8?B?UmF3c3VvWlVGaUhLUE0yWmFCZjZGTlBaWndSbFNnR2w2NDdFQlpWQXgxZzQ3?=
 =?utf-8?B?UWQwMUt6ZmNxelBlVzVFcC9na293aXpFVDR3Ty8xUkppTk5UYVl4ZURCOE9D?=
 =?utf-8?B?U09xQ3YzbXYxWjVvVVRnay9uK2FPc1ZDL1Z5NitiVXExSmJ1VkZqaWY2VGVC?=
 =?utf-8?B?SUo4MlUwREFydXVxRzcxTDdPZTVmRko3emlSRFNtM3pQR2JhNDhCTlZpRGFN?=
 =?utf-8?B?bEdYRGtKS3FZdHQyaXVYejFGS25sYlBHZGtCWktLemh4M29aL2hlOGZGN0Fm?=
 =?utf-8?B?QUJNd0s2dTc2QnZkRWR3aTRBQ3Jpa0d3T3JiRzdyWHN2Y2hVRG4zTUhUUnJK?=
 =?utf-8?Q?QSw7Y6p5UR918UsTRH0SueI=3D?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40876822-0bf2-49c1-48ea-08dbc940f997
X-MS-Exchange-CrossTenant-AuthSource: DS0PR01MB8010.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 03:28:31.0311
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1+vKVVtwpfN0lkkvS/TYXJBl9/gLqAXy9vor6Crg+JOh23w90mMuA7JxAPBu/pqFPf1b6bKm/6zs7yVbCze2k4HgCkNI52td1iCup+olkAl8sGFImMd/4nzmQXwm9r9K
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR01MB7813
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_INVALID,
        DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,
        HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 09 Oct 2023 20:28:47 -0700 (PDT)


On 05/10/2023 14:31, Krzysztof Kozlowski wrote:
> On 05/10/2023 05:55, Chanh Nguyen wrote:
>> Use gpio-leds to configure GPIOW5 to GPIO_ACTIVE_HIGH and
>> GPIO_TRANSITORY flags as a bmc ready led. The GPIOW5 pin
>> is reset when watchdog timeout occurs.
>>
>> Configure the GPIOS3 to GPIO_ACTIVE_HIGH as an identify led.
>>
>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>> ---
>>   .../dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts     | 13 +++++++++++++
>>   1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
>> index b7c4f7cfad07..88693c2b2dbe 100644
>> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
>> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
>> @@ -51,6 +51,19 @@
>>   		};
>>   	};
>>   
>> +	leds {
>> +		compatible = "gpio-leds";
>> +
>> +		bmc-ready {
> 
> Missing led name.
> 
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
> 
> Best regards,
> Krzysztof
> 

Thank Krzysztof! I'll test the DTS against bindings and update it in 
patch series v2.