Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <522d8a3a-3db5-bc20-198a-c4b142e982d9@intel.com>
Date:   Tue, 10 Oct 2023 11:33:30 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [RFC 8/8] iommu/vt-d: Add set_dev_pasid callback for nested
 domain
Content-Language: en-US
To:     "Tian, Kevin" <kevin.tian@intel.com>,
        Baolu Lu <baolu.lu@linux.intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "Martins, Joao" <joao.m.martins@oracle.com>
References: <20230926092651.17041-1-yi.l.liu@intel.com>
 <20230926092651.17041-9-yi.l.liu@intel.com>
 <BN9PR11MB52766E649727842C98B7396B8CC2A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <04af40a3-1675-4b1c-27de-39d261dcb1cf@linux.intel.com>
 <BN9PR11MB5276CD4C47B3833BAC8B30588CC2A@BN9PR11MB5276.namprd11.prod.outlook.com>
From:   Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <BN9PR11MB5276CD4C47B3833BAC8B30588CC2A@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1B3WHM0QStidTl5bE1Qa2FmeUFZd0RjQUtJK0o4eGNTajQwSEYrZUJCcXZU?=
 =?utf-8?B?cm9pZTF6ZkFKVjFScVo3Zm9OenM4blRHZjNYQm9IM2xVL0NVY2V5UWt3MWl2?=
 =?utf-8?B?cDZVekRaejRkemFIdS9xUTRjdHJYeVlROEo2VlFmMmFla0pSTFRybUs3YWNO?=
 =?utf-8?B?S0JjVlRkNmt2a05hc09OQkNGdlVPcmx5bzI4VkJudXF3RmdsMkpHUkFJWFRH?=
 =?utf-8?B?eThaWmhvV2JQY2djdHJsRWhDclZzQTM5SnNIMXpsaFlNWUJ5WVllWFUzZzRa?=
 =?utf-8?B?Q1dJZmVtU29GcUpIT1hDWGdVMlBnOWR0NVU3NmhVNEJtcjg3SE9BV1BMSnE3?=
 =?utf-8?B?dWZTb0ZmSVR6cURGUzZ6dEh1VmtVL3FRbUQvbzFBRHloektVUndJMzVOdnZz?=
 =?utf-8?B?ZUNBOXhScVN3cnNta01sdDlPNCtSNVQ0N3FYUFFydjZzWTN2VXVtYjhVTmhD?=
 =?utf-8?B?MWFNRFEwNjBtZEVON01IeUU0K1VDeVRBcG9LVWRnMGhzcjJ4UFYzUi9DYmVS?=
 =?utf-8?B?UTliVHJyN1cwcnJvbnMvVWhBYlRLUGdldFZkOUV5NVZ5MmFndUxUM1RSZ2FX?=
 =?utf-8?B?QU15bUNwaU8wSnVKQS9ZY1dHMmwrNmp2U2dxUHQ0TUVlakdLWTlXYXJ1YTBQ?=
 =?utf-8?B?L3l0cjdHM1FWQ3JzN2JyVktDOGo3UWlSVk9VWTBTSlBjamQ2c2lQZnN0ZmFq?=
 =?utf-8?B?Ti9FUE9qZWVESE9iYlRHUXNsbklJekRqcVBBQmRDMjgzclJsQldNRXZRTVlk?=
 =?utf-8?B?RUNncFBpa2pNSzkyajErK2NQNGNHNWxTQTBYbTBGeXVEemJsTS9lUldFMGp3?=
 =?utf-8?B?SDBjWElEZ29ldUJHbThsOHVIbDQzR0Nla0ZsY2w4OWhnSXN6VURDZEpHZkFE?=
 =?utf-8?B?ZEFkOWlvZHlPQnA3L2UxQTdwRzA3MVo2Z1FiRk0wTE9QQ3VvanhXZStkd2tu?=
 =?utf-8?B?RVYxUWdRSENBNWhqancwNHNSVE43b3VoSnU1ZGVTMG4yY1U0dklKMGRJR0ZD?=
 =?utf-8?B?UG54WDRaSGUrMmtuQXkzTzF0and4cUZ6NGNqbkR2dXZoa2JieUdHV21BVGJZ?=
 =?utf-8?B?NmNGNUtvalA2cnc0S1kvMy9hckp0dEZtZlBEUklGa2VpM2pZaWlJaGc4TTVn?=
 =?utf-8?B?ZFpKa3dOZ0VuNllKUFovZUl1Z01vVnBQRWJuWUNPSjNabGY5NUhxMS9Ba05B?=
 =?utf-8?B?N0t0emNLSXdrN0pTTHhyKzJJc0NxQzk3a29pbW1EL2kyS0lIb1hZV3RRdXcx?=
 =?utf-8?B?RjRlWVprdnlvN0QxZ0ZRcU9hbXN0cjhWSHVJRXY1UEVZRWlzQVBvR0VjUnVZ?=
 =?utf-8?B?UFduL21JZjE5YjlSQWdldjhSODJ6dWpJZmE2N2t5WEE2SFlyOHUwaUNLZ0NM?=
 =?utf-8?B?YzAwcW9HakROd3puemNOcjIyZVFQbkJ4NjZPUG90eUtzUmhOaEI3Y3VNMHFR?=
 =?utf-8?B?RXFvSXZUeWQ2U09kUFZIOFhJTm5sUUs4aXZ1T0xkTU5oZDNTWENlMXZDTXRS?=
 =?utf-8?B?Ry9sNjM5NWtPek1wZXJuRXNlZkxrYmprSGtZMkIyVEFJVDg1QVd1MTIxM0No?=
 =?utf-8?B?QmdXZ1VabjJIeTFwZ2tQd0pRbElIZHFCdEFkNkdpUmY2dUdHTVJIY2F3RmV4?=
 =?utf-8?B?SjZmcHhOb1pGelY5eXkvU3pyK1JObXhkTlpnM2Z6NTJIVmZ6YmczVnN4M2lL?=
 =?utf-8?B?bllNekhFZlhzQmZvWG9YR21SQlRyRzJYTTQ1M3VBVEI2bjJjdDE3OUVFV0xS?=
 =?utf-8?B?NXVGaWd1RXoxc3hxV3M5aG96ZlYyd2w4SXlzMGVvUGlHdFgwd0t0OEdONnBi?=
 =?utf-8?B?eTgxUVE0Z1lQY3U2eHUrSDRJT0FXbkhRaHExV295MStyME4zZUpjQmkveTQ1?=
 =?utf-8?B?UW9VR0lHa1FiaVFvRDhEYkYvMFhBWkIwMjFzSm5oOFhEN2dSd1RpNVNEV1Jh?=
 =?utf-8?B?cy9yUWd2aWtmdVJ3TURIdnFlMW1kYmoyQzMyWTRmLzg4Y21SM1lIRWlvaWJ2?=
 =?utf-8?B?UXZVWTZmTFdLbTRxVU9vWGxKWXdQSUhBbW1uTFYrcVRZb3BQU0xNV1pqUkJH?=
 =?utf-8?B?UTNkVFIzWFFEdkxQbG1BLysxWHJCTkRwQ2pwNHFRb3dxclNmT0xXU2VPQk5t?=
 =?utf-8?Q?1dMrqRqfXia2NtMTLtIedRIPa?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c7ffadf6-be7a-4132-3ebd-08dbc9415890
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 03:31:10.2269
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mmI5lIsCFt0gp0eKfhpUEXEpL7lQrE/zxIhR6ZMLkpUUbaEjAZ3UYjqdwne05lw/QciYEGto3u8cIy3/oewJhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6236
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 09 Oct 2023 20:33:00 -0700 (PDT)

On 2023/9/27 16:09, Tian, Kevin wrote:
>> From: Baolu Lu <baolu.lu@linux.intel.com>
>> Sent: Wednesday, September 27, 2023 3:58 PM
>>
>> On 2023/9/27 15:52, Tian, Kevin wrote:
>>>> From: Liu, Yi L<yi.l.liu@intel.com>
>>>> Sent: Tuesday, September 26, 2023 5:27 PM
>>>>
>>>> From: Lu Baolu<baolu.lu@linux.intel.com>
>>>>
>>>> This allows the upper layers to set a nested type domain to a PASID of a
>>>> device if the PASID feature is supported by the IOMMU hardware.
>>>>
>>>> Signed-off-by: Lu Baolu<baolu.lu@linux.intel.com>
>>>> Signed-off-by: Yi Liu<yi.l.liu@intel.com>
>>>> ---
>>>>    drivers/iommu/intel/nested.c | 47
>>>> ++++++++++++++++++++++++++++++++++++
>>>>    1 file changed, 47 insertions(+)
>>> pasid can be attached to either user hwpt or kernel hwpt.
>>>
>>> We should also introduce a set_dev_pasid callback for non-nest domain
>> ops.
>>
>> We already have the code in Linus' tree. The idxd driver uses it for
>> kernel DMA with pasid.
>>
> 
> ah, I forgot. ???? probably can mention it in the commit message.

sure.

-- 
Regards,
Yi Liu