Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Tue, 10 Oct 2023 03:43:08 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Ani Sinha <anisinha@redhat.com>
Cc:     Shradha Gupta <shradhagupta@linux.microsoft.com>,
        linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        Long Li <longli@microsoft.com>,
        Michael Kelley <mikelley@microsoft.com>,
        Olaf Hering <olaf@aepfle.de>,
        Shradha Gupta <shradhagupta@microsoft.com>
Subject: Re: [PATCH v8] hv/hv_kvp_daemon:Support for keyfile based connection
 profile
Message-ID: <ZSTITGaGzR8wR1+h@liuwe-devbox-debian-v2>
References: <1696847920-31125-1-git-send-email-shradhagupta@linux.microsoft.com>
 <DF08C86E-1EFA-4C74-A5E7-190B52698F85@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DF08C86E-1EFA-4C74-A5E7-190B52698F85@redhat.com>
Precedence: bulk

On Mon, Oct 09, 2023 at 05:32:35PM +0530, Ani Sinha wrote:
> 
> 
> > On 09-Oct-2023, at 4:08 PM, Shradha Gupta <shradhagupta@linux.microsoft.com> wrote:
> > 
> > Ifcfg config file support in NetworkManger is deprecated. This patch
> > provides support for the new keyfile config format for connection
> > profiles in NetworkManager. The patch modifies the hv_kvp_daemon code
> > to generate the new network configuration in keyfile
> > format(.ini-style format) along with a ifcfg format configuration.
> > The ifcfg format configuration is also retained to support easy
> > backward compatibility for distro vendors. These configurations are
> > stored in temp files which are further translated using the
> > hv_set_ifconfig.sh script. This script is implemented by individual
> > distros based on the network management commands supported.
> > For example, RHEL's implementation could be found here:
> > https://gitlab.com/redhat/centos-stream/src/hyperv-daemons/-/blob/c9s/hv_set_ifconfig.sh
> > Debian's implementation could be found here:
> > https://github.com/endlessm/linux/blob/master/debian/cloud-tools/hv_set_ifconfig
> > 
> > The next part of this support is to let the Distro vendors consume
> > these modified implementations to the new configuration format.
> > 
> > Tested-on: Rhel9(Hyper-V, Azure)(nm and ifcfg files verified)
> > Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
> > Reviewed-by: Saurabh Sengar <ssengar@linux.microsoft.com>
> 
> Reviewed-by: Ani Sinha <anisinha@redhat.com>

Applied to hyperv-fixes. Thanks.