Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Tue, 10 Oct 2023 07:53:18 +0200
From:   Maciej =?utf-8?Q?Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
To:     Shuah Khan <skhan@linuxfoundation.org>
CC:     <akpm@linux-foundation.org>, <christian@kellner.me>,
        <fenghua.yu@intel.com>, <keescook@chromium.org>,
        <ndesaulniers@google.com>, <coltonlewis@google.com>,
        <dmatlack@google.com>, <vipinsh@google.com>, <seanjc@google.com>,
        <brauner@kernel.org>, <pbonzini@redhat.com>, <shuah@kernel.org>,
        <hannes@cmpxchg.org>, <nphamcs@gmail.com>,
        <reinette.chatre@intel.com>, <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH v4 0/8] Add printf attribute to kselftest functions
Message-ID: <fqfwpd5u3yjnnbojzwonvnesltves7pm6jx2cov5vaqyqsrael@m6bxnoskb6la>
References: <cover.1696846568.git.maciej.wieczor-retman@intel.com>
 <cb1dfcc1-e03e-4517-8f77-d08f10aa507c@linuxfoundation.org>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cb1dfcc1-e03e-4517-8f77-d08f10aa507c@linuxfoundation.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?VAY4BTHnc3z7rUb3Usm2I1PbYLpBJ8C5RKO1TsFEGFfy+CXvjNiCRzvPOI?=
 =?iso-8859-1?Q?4Kt8yo3m4+4Dl2p23WJ0xOLdRfgqOzW1nlezqbd//2A7XdijewuP4NrVMK?=
 =?iso-8859-1?Q?EbQhYX7XK55/bYPau3AOBEws05BbknCnNXamOiIykYYEMqx67JQShxFxbG?=
 =?iso-8859-1?Q?dWSv7rPx1HTBNSJ9O3RiXkZY968K32S3pA0evHG4MRXN+tIeUZMmdubNvR?=
 =?iso-8859-1?Q?l9rlQpI02VQze4uvhJu5WGTrttG9UPMLi/pN7YX58S1hRNJ3clQ7nqPxxv?=
 =?iso-8859-1?Q?gB3CeW+iHmekox2ziJojq7NqxjxCxMjPNXH7r0FEaIeWD4awmoj9Kb3MHK?=
 =?iso-8859-1?Q?iC0gVrxCWmXe5jS4Oz4rsXAaQoxaxi+BaCBKLQGb5KzhXDCwm36jU0p4Yc?=
 =?iso-8859-1?Q?765lChMdl16TYpPmy7s8CNedyn5YGxbMNRzIpbySuGvrdey1Yi9TwsjQ5m?=
 =?iso-8859-1?Q?HNSbD6APHZXllmHufN6EHid0Aeyd08o3jrzGjzL7rn8n4D1vHZh8yvWtCY?=
 =?iso-8859-1?Q?M5J46jecBDCZsFcrHxmCTDtNkt5kRsjqxqeJRZ9infWj0gJdSdEPpT0WXq?=
 =?iso-8859-1?Q?cgZijQjG+xO92spTWzI1l4Wb8+ssnRHCjHeRhTD5CxvklzyfE+8naV2grJ?=
 =?iso-8859-1?Q?M4+uGEMKFMEi6jDUo7a7djTesYxFPmQkNFknBVQxlf3pgHESU4UOgkCp1t?=
 =?iso-8859-1?Q?NdwsQkeTQiUSAFJMvhYkhsn3W4Is0WmlLLriWs2LIpG2ydQPhsMicvb0qq?=
 =?iso-8859-1?Q?IV+NPYIK//1Bd6f/Qou6Ad9HhL6vTN+9G5gVJBT31Sukw0yqldlFUVzH63?=
 =?iso-8859-1?Q?vYqd5/fkD2eHJ/O9lgCaKbPGqVR5q7OoQixuRmZT/9wMRv2zox9ailFLJ9?=
 =?iso-8859-1?Q?NXEu8QnCU7pA9iOY4vjeYo7BaxnNpNnfTlGzm0UXbYpBX09HZ1WTtSUAM8?=
 =?iso-8859-1?Q?igAQk/ZnRpmRAmQUS0f9uSGjRZgMeCuWrrSot2QTbsQrZZ0QdLThCTcddm?=
 =?iso-8859-1?Q?NtezLU0ETx+lV6IkqGQzA52b18tXsvwlajnmMtg4OtbQMUHXtnXqgcmLGt?=
 =?iso-8859-1?Q?3k4ptD4dA88U0PCxoQRnVfFPp8gXN7Onzeki9cS8B9/X8UXla/4YE7eL+3?=
 =?iso-8859-1?Q?zbIAXqYpKvib1KgqZWLMJUhT+OwWVHjKg01CQG0L77I+c991zwWH0+K3nK?=
 =?iso-8859-1?Q?E1z8VCFYgBTCFeDJ1iuFu1zKZAxJP8Qszw21iPVzIB4IxTNXkROoR+x0k1?=
 =?iso-8859-1?Q?MozQWBLVarNxW+jxAKWvUT8cdxKnl7NQ6QYM20px8t9Yw5rya4rkjuvktC?=
 =?iso-8859-1?Q?uXvmckf3pEBIc2lB4bhyoJ8ImHijK2VP6y7LKng2nPL5QNbdV4+ZHKaIC4?=
 =?iso-8859-1?Q?KgqCKKbZ1Dy3vojWEBF51M3WG72RSOkCDWk/P+p6Oux0R8TPjxtGLl7sv4?=
 =?iso-8859-1?Q?zkaRukIN6XiMIqSXidFt2O30WdbM/GzvajblRUHvSa+IK6VAFmdE+kiqAd?=
 =?iso-8859-1?Q?HsUp9maEtCfAbA1XoeeivZaPH/STkZ/7jyBll20vNnNf5wvqSyHdfApERi?=
 =?iso-8859-1?Q?1oJm0R0zev9gKDW9ATNzOfHkCgDTV64lYbCdgUQerv0U4Tq4ARf8T9TEbB?=
 =?iso-8859-1?Q?/ut/6DiJZTyyH92ikE96SDsCoF4Ob6Zy0DBQJTJy2I4MMpFQycFOUyRZt6?=
 =?iso-8859-1?Q?YVfiXTljEjxyWNnoumY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cda01329-381f-4068-d782-08dbc9553945
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 05:53:27.5409
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CXuSaiYBn2gT08ypa9CYPEP0PwdJbcOw/rhyi8W86kjA0rPoB6VwAvyAC7AFYjCy5vkzuIGiUZ2fULnjbeKw0zgdZ67VsIW8KyDVaKfKJvo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7065
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 09 Oct 2023 22:53:53 -0700 (PDT)
X-Spam-Level: **

On 2023-10-09 at 11:28:30 -0600, Shuah Khan wrote:
>On 10/9/23 04:28, Maciej Wieczor-Retman wrote:
>> Kselftest.h declares many variadic functions that can print some
>> formatted message while also executing selftest logic. These
>> declarations don't have any compiler mechanism to verify if passed
>> arguments are valid in comparison with format specifiers used in
>> printf() calls.
>> 
>> Attribute addition can make debugging easier, the code more consistent
>> and prevent mismatched or missing variables.
>> 
>> Add a __printf() macro that validates types of variables passed to the
>> format string. The macro is similarly used in other tools in the kernel.
>> 
>> Add __printf() attributes to function definitions inside kselftest.h that
>> use printing.
>> 
>> Adding the __printf() macro exposes some mismatches in format strings
>> across different selftests.
>> 
>> Fix the mismatched format specifiers in multiple tests.
>> 
>> Series is based on kselftests next branch.
>
>How did you find these problems? I don't see any information
>how these problems are found in the commit logs.
>
>thanks,
>-- Shuah

I wrote the first patch that adds the check to functions with format
specifiers and I compiled all selftests. Then I just corrected any
warnings that were found by the __printf attribute.

Should I mention the methodology in the cover letter?

-- 
Kind regards
Maciej Wiecz?r-Retman