Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp2311182rdb; Mon, 9 Oct 2023 23:01:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFtNPS0E0gQprlUMnlXV+T3E++SbMaxuqEgyQW4wHDUR42unrzgoT+BCe0R4z4QY/BYKjyB X-Received: by 2002:a17:90a:e651:b0:268:1be1:745a with SMTP id ep17-20020a17090ae65100b002681be1745amr13175345pjb.29.1696917696627; Mon, 09 Oct 2023 23:01:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696917696; cv=none; d=google.com; s=arc-20160816; b=KJrq9k7tUcAhbX7L3RKuEDqaqGlnbBSsgpGaVvjI0ZP7+xrE6fbMKOfePuOYXJXnuP B+aMfNvce6rR4gN7KrFzf+1RHZt4SY9O83IQyK489w5DImwkJkor62XozZr7UWgzS615 Z/9Td6tZtNA30WkRijCWDddezgGGwIm+3pIqh8xjCBOCI4ly1EpUBSkxxNxjr/8SOwVZ PCalVETG8t3xb4CS++CGHW82WWiwtKvpjX8AwtHsUeG1v25+ZkA7FqW8nAPE3StNZwuy NSWXycDWKwdF6hWuWtDDqDYDzKZJ/OC24/DSK0KYrdij5MWK1LHqtxKs4Dmk5jZum3/C PPLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xpPGDme7av5FZl7zkQNasjca5N77wGLGagXNd7oouw0=; fh=lXlivUUH9lDDhRDJlz+YsW9b4+1S1zJz7zyIphtBGgU=; b=mfOWcbcvn6hBJ84C0WkFy1lQ5ekGqR1hCjUoUaiySV/RPYRyir1+7iieKd/bU5V3Ba RiSU0BNK3DinxBpe7RV5Q93z72G5/TSG6Tq5tjXMqdcOTePfWSdylnbd7gj21C3cGErl HxXcVCEHGTEjvdVquZRuVbIsYdgqMy37uDRuZoKwceRdTVV8FXB5b5RAKmDW042TuddN 1c2zpnDkJjL4GL4+h+o16Nze+/ZTHyZZhzzyY3QrbgmlakpZLh/t2i1pFNaf7jzz4vL6 qHusxoYAonh2sKf8ijsNbOegihVLHX3NF+Q3GElZi9iDIPWW1+RZzEcITJD4aYIqeicT BgWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kjaij1CK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id lb10-20020a17090b4a4a00b002748c1bbd79si14367479pjb.6.2023.10.09.23.01.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 23:01:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kjaij1CK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 0F3298097A50; Mon, 9 Oct 2023 23:00:46 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442167AbjJJGAV (ORCPT + 99 others); Tue, 10 Oct 2023 02:00:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442205AbjJJGAS (ORCPT ); Tue, 10 Oct 2023 02:00:18 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 391BDC1 for ; Mon, 9 Oct 2023 23:00:17 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55CBAC433C9; Tue, 10 Oct 2023 06:00:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696917616; bh=gQXf/DuKE3gdQ2bmNkAQyrlr4ASiicMGR3NvmU6Ghj0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kjaij1CKbBcWr5w+jLQM24tkojhInog/OnyxdeL0kg/slP8FbEbkGncR/r9nYxeqW ysMPNeBz5JXnRjPWZdGt+aTOt31YPue6ncmY0qwFC8LXR6MQsnGYSNFkSnCSfjanZh HHCFIloNqqwiFhP7RA/f/p89E1Cr3jR58uNLd18I= Date: Tue, 10 Oct 2023 08:00:14 +0200 From: Greg KH To: Javier Carrasco Cc: Peter Korsgaard , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , syzbot+1f53a30781af65d2c955@syzkaller.appspotmail.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: usb: dm9601: fix uninitialized variable use in dm9601_mdio_read Message-ID: <2023101036-fleshy-dude-aec0@gregkh> References: <20231009-topic-dm9601_uninit_mdio_read-v2-1-f2fe39739b6c@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231009-topic-dm9601_uninit_mdio_read-v2-1-f2fe39739b6c@gmail.com> X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 09 Oct 2023 23:00:46 -0700 (PDT) X-Spam-Level: ** On Tue, Oct 10, 2023 at 12:26:14AM +0200, Javier Carrasco wrote: > syzbot has found an uninit-value bug triggered by the dm9601 driver [1]. > > This error happens because the variable res is not updated if the call > to dm_read_shared_word returns an error. In this particular case -EPROTO > was returned and res stayed uninitialized. > > This can be avoided by checking the return value of dm_read_shared_word > and propagating the error if the read operation failed. > > [1] https://syzkaller.appspot.com/bug?extid=1f53a30781af65d2c955 > > Signed-off-by: Javier Carrasco > Reported-and-tested-by: syzbot+1f53a30781af65d2c955@syzkaller.appspotmail.com > --- > Changes in v2: > - Remove unnecessary 'err == 0' case > - Link to v1: https://lore.kernel.org/r/20231009-topic-dm9601_uninit_mdio_read-v1-1-d4d775e24e3b@gmail.com > --- > drivers/net/usb/dm9601.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) What commit id does this fix? thanks, greg k-h