Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <2663c344-4fd6-6fb7-982b-7371be2ede38@amlogic.com>
Date:   Tue, 10 Oct 2023 14:02:24 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 0/4] Add C3 SoC PLLs and Peripheral clock
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Neil Armstrong <neil.armstrong@linaro.org>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>
References: <20230928063448.3544464-1-xianwei.zhao@amlogic.com>
 <51abc760-8d6a-41b6-8a10-e03be5edc486@linaro.org>
Content-Language: en-US
From:   Xianwei Zhao <xianwei.zhao@amlogic.com>
In-Reply-To: <51abc760-8d6a-41b6-8a10-e03be5edc486@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGIxTURDQ0VBZWVNbC9SUlZMaFNJdDFCUTArd2VpUXRmbUdsOG5LaVNxSUty?=
 =?utf-8?B?RUNHUFlFR2ZwRGUxWE1pZ2JIZDBzaFdwd3d1ZkNIRFVLa3Nyb3FlRDNQS1VS?=
 =?utf-8?B?R1lEN0J1Y2FZdzNiTFRNWThZeGF3SS9XdTJXVW9PSU5FZnU4RnRVUkhNeEMx?=
 =?utf-8?B?NzdKM2tvQjdtMXVySnZiaU43Zm9YVGRGL2c4dWIyN1U0a2Z5YUthRFJBV0dW?=
 =?utf-8?B?dDVPVVp0RlRTTzgySTlSLzJoemExQmVqNHYyYVJlL291Skd4dTl3M2ZlQlll?=
 =?utf-8?B?ZGxleW50VFFNek9YNU1KWndQS1EzU1hVWkhubWxaRDFNTUhDcklmN2lHQUt2?=
 =?utf-8?B?d21PNWJQMHB4YkMyQVFuMXhpLzhINlpoYXpJamkwalpja24xNlRTTGZ1MDBt?=
 =?utf-8?B?SWlXd3lGL0hjQlFldjB3dWJtVVRVNlc4a1h1UExocExnU21ieUMxRUkxYTNN?=
 =?utf-8?B?QUZza1pEeGF6Q282M0QvM21DWDhUREE4WG1tTnRMS1BkSk1WenQ5ajdlM2JG?=
 =?utf-8?B?Tkl2WTdRWFdHU3ljYnpjNEVpQ2tvUVQxZ2pVTHEzYzBPekxZOXNiMXZTbWdP?=
 =?utf-8?B?WCtzWU1xN1hCbXRHdzdvSHQ2SjVLaVArSHdsRDRodVNDWk4wenRGZVJnMmxS?=
 =?utf-8?B?L0RJMEY0WnhjWm9GajlHVWd6c2J6ZTBOaDhaenFqSFBydGFGRnhrbGFObzZs?=
 =?utf-8?B?MklCWWlBQWJObnExL3UwRUozczFQejJEQVhlaUNDdFdoNFBLeUxkVExTbmIy?=
 =?utf-8?B?QTczOUpXdlI1RDV0ZzNHOXUxelQ0c2FvVXZBOGdGSWpqMGxyZDB6bEg4SjR0?=
 =?utf-8?B?QXlYRkVHdWVMU2I5ZXkrVTJXV3Ayb0JoL3lFUlBGaDZkcjJzRVRsQmhGYW5q?=
 =?utf-8?B?NjdkN2hTdmdBdUwvUFh2MW5NM3ZjNHFYWENTKzU2SkhnUFVZU3V4Nnh1WjRG?=
 =?utf-8?B?Und3QXdoU2lVSEQzbVB0ZVF4R0hOTU1LWmcwdkRhSVdmV0R3a3htQXpEMGg3?=
 =?utf-8?B?ZFJSQkdGblh0NzFyUHNmb0ViWXNiWXBXb3J5TFA2SDZEUW1nam81dXVYVmJm?=
 =?utf-8?B?cXVNd043NSsyWkg2Sk9qdGYvbXJLYnlIK2pCVXRJS3BWQktzK0F4ZDc2ZlA4?=
 =?utf-8?B?Njc2VnI0L21INDdKRHQ1N3JWTWZKUURieGFiL3lvWmxldEtpNnQwVVJZb3lk?=
 =?utf-8?B?MExKUVRLa1FRd0xWcVhRbnJIclQ0ZDB3MmV1RG1qSUppRlZUY3NEWTJoK3M3?=
 =?utf-8?B?QnJaZEdKakxxWFh6UUF0cUMvcTZBUHJUaFY5SmNoZitZclNDUVFYWElZVUFl?=
 =?utf-8?B?eTAyUlEvWkxScURuVVIwOTI5Z1hMYWI5QmxkWGk1cW5LVEtoc1gxZmFhMmVH?=
 =?utf-8?B?K0JuQUQ2UDJLZ1pBQVk3ZndVa25zRDh3L2FHd2xTYkd5b2xQblFHSzRiWXU4?=
 =?utf-8?B?NVRDdnRBcFVkRENtMWlOa0tVNWlobFU3WCtlek1sZ1l2Unk3d2ExbE5mZXVs?=
 =?utf-8?B?ZWxUSEJPMGtWdkVJVXRZenRFTjVZUTNrTEoxME9XMW1ZR3B6Y3h4QStrVFJy?=
 =?utf-8?B?OVF0eHc3Yzlhb0tCZEU3MFlsWElyV1pOSXRQdjBlek94a2IrL0Z5R1VQUTJu?=
 =?utf-8?B?dm10Y3JKZXpFcGJOUnNtYlBpdTdnRStFeVY1YnFCMGw3RklZSStiRnA4eWs4?=
 =?utf-8?B?K3E4MitpMHpVMjc1YXQvU1o3a1pkMW5FWm1OSVd0NnZaMlY2WmJpOWk2YzFQ?=
 =?utf-8?B?YXVSMjVsZFM2c09tOEhLZVI4QkZTUlZkcEdwMlF5bW1pZWYzb0NqSzNkVG5s?=
 =?utf-8?B?MU82Tk5rTVpXS3VEZGxLcmlpSXhyYjlWS2kyZGZwa3RVZEhSTGxZT2Z2QVJo?=
 =?utf-8?B?WCtzanI4MFhtaVRkT3E2S1lKWE9Jbkd3TWdER3NoeG5DV2p0VzJBa3I4M0hO?=
 =?utf-8?B?ZmR4M0NqYWEwOXFZYVZONHV3dW1UekdqMTJVQXd2Ny8zOHFxaWdtQlF1YjlW?=
 =?utf-8?B?TnF6UXQ1RHRXdzR2citYNHhxZDFCS0oxVlZmNVN5c1ZyWVJoS0UwYitKcjVG?=
 =?utf-8?B?bU1JcVhNMkk4NkVzSGl3a005WFlCeTljOFdsWVdhMWgzYmRJS2h0Y1hST1c4?=
 =?utf-8?B?dmxRUlMwTjg0c0hYNUd5YTFTZm5UL29wUXdQZ3Y1Z1lxUlhSUFhqM0w3VEFa?=
 =?utf-8?B?MFE9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df4caee9-afc6-4542-f670-08dbc9567cc2
X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6896.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 06:02:30.3233
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e12q0Pe0W2OAFnnD0n/FXJOElcr3/QrhZxDpvy4/taKXtFkNGKPOCKmGB2EMFHuSwFKsxoKP4jaLVF73Xlu9KLPsIwt2WtU5K8fZ2FkTCe8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR03MB7753
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 09 Oct 2023 23:03:35 -0700 (PDT)

Hi Krzysztof,
    Thanks, I will fix errors of bindings in next version.

On 2023/9/30 23:53, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 28/09/2023 08:34, Xianwei Zhao wrote:
>> Add C3 SoC PLLs and Peripheral clock controller dt-bindings.
>> Add PLLs and Peripheral clock controller driver for C3 SOC.
>>
>> Xianwei Zhao (4):
>>    dt-bindings: clock: add Amlogic C3 PLL clock controller bindings
>>    dt-bindings: clock: add Amlogic C3 peripherals clock controller
>>      bindings
>>    clk: meson: C3: add support for the C3 SoC PLL clock
>>    clk: meson: c3: add c3 clock peripherals controller driver
>>
> 
> This was absolutely never tested :(
> 
> It does not look like you tested the bindings, at least after quick
> look. Please run `make dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
> Maybe you need to update your dtschema and yamllint.
> 
> Best regards,
> Krzysztof
>