Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp2315198rdb; Mon, 9 Oct 2023 23:11:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6TiikEUC1rjCCRRDBPRp8sTqixXxYuG1+I2rZWg1mW43nTJR0oJbC0Ao3hjZb+xJk9uH9 X-Received: by 2002:a17:90b:1e04:b0:268:352c:9d13 with SMTP id pg4-20020a17090b1e0400b00268352c9d13mr13699385pjb.0.1696918276995; Mon, 09 Oct 2023 23:11:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696918276; cv=none; d=google.com; s=arc-20160816; b=TkF88V3pL0f8/22/AZa377gg9KFDPv4Hxxz1KI1YobiULUKgO+j6r7Ywh2lye02kG5 P5B0LBKuo4vPMOb6n54tOPpwSwdbqg6yEIFYofJLoyBL3/LkS04rNFTNLBvyV2GRdqr3 A66CWAbKph5EYBDNN7klbMPo1kCjH9ANMK2bHC99TC3+bDzoItIJw+TLZK9XkWXWmrWq oAaLJBXfzW/VUgYHPClhlpN5kKDckI8hMlAFHpDGulsf7K7+BgR98i+ZaRSzCDBY4I/q xnGkXrDDIsjP3rioYO4xEjxQI2hB0gcV11whXo9Pl4+DoR8LkcHMsCfyYp3dsCLNRPU6 PvZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=tod03wKj4V9P8UBvaVIReBNYNLT37TapKlqEPyLC27I=; fh=+wKA/eAH0Ov+mjWPn6fKET9W8fwcHIipp/A3cxg2bfc=; b=YWr6X6fvOKHbMk1HilgJHlAcY/UYB8ttK5DCAg2xzcIbF+mKNkSgcjge2hyh0eYfvu gYvaGM5zM618Sdz+5kOjtnYA6R4OBpLckgMp8/bNPvgoANZpf+uycU9JYcXSIp34QBGU RRa49tWc1hT50j2czYdwjiecCFaZ16IhLTtRdlsNluobsDmIPVzXhcOCMZpXrcEfXlOB 3M+m7CH6OEkAZNmxpvPv6LeEgNuIeTKpLoRXDZMJ7w4HYNzTVuAKblPrSnYfA96FMzW+ vpVtRB3Q3r1nlV+agDcm+M4/iLXTxgTMFKRgNxnP8KSVrJ6pJxKyqALF+Nztwcui/fQB 6GcA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id c4-20020a17090ad90400b00273ce975beesi11174229pjv.114.2023.10.09.23.11.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 23:11:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id C230280C3A01; Mon, 9 Oct 2023 23:11:14 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442183AbjJJGLF (ORCPT + 99 others); Tue, 10 Oct 2023 02:11:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379414AbjJJGLE (ORCPT ); Tue, 10 Oct 2023 02:11:04 -0400 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BAC39D for ; Mon, 9 Oct 2023 23:11:01 -0700 (PDT) X-UUID: ce3d942ff2a44ad3b728ecdcedaf844a-20231010 X-CID-O-RULE: Release_Ham X-CID-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.32,REQID:c49a5ea7-1b9b-42fd-a0bb-4dfab2ba0dd4,IP:15, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-INFO: VERSION:1.1.32,REQID:c49a5ea7-1b9b-42fd-a0bb-4dfab2ba0dd4,IP:15,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:0 X-CID-META: VersionHash:5f78ec9,CLOUDID:10d39df0-9a6e-4c39-b73e-f2bc08ca3dc5,B ulkID:231010101005VJRJ2L0N,BulkQuantity:2,Recheck:0,SF:24|17|19|44|102,TC: nil,Content:0,EDM:-3,IP:-2,URL:0,File:nil,Bulk:40,QS:nil,BEC:nil,COL:0,OSI :0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: ce3d942ff2a44ad3b728ecdcedaf844a-20231010 X-User: chentao@kylinos.cn Received: from localhost.localdomain [(116.128.244.169)] by mailgw (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 189130116; Tue, 10 Oct 2023 14:10:43 +0800 From: "Kunwu.Chan" To: kevinyang.wang@amd.com Cc: Alexander.Deucher@amd.com, Asad.Kamal@amd.com, Christian.Koenig@amd.com, Hawking.Zhang@amd.com, Le.Ma@amd.com, Lijo.Lazar@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, amd-gfx@lists.freedesktop.org, chentao@kylinos.cn, dan.carpenter@linaro.org, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, evan.quan@amd.com, kunwu.chan@hotmail.com, linux-kernel@vger.kernel.org Subject: [PATCH] drm/amd/pm: Fix a memory leak on an error path Date: Tue, 10 Oct 2023 14:10:39 +0800 Message-Id: <20231010061039.75878-1-chentao@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 09 Oct 2023 23:11:14 -0700 (PDT) X-Spam-Level: ** Add missing free on an error path. Fixes: 511a95552ec8 ("drm/amd/pm: Add SMU 13.0.6 support") Signed-off-by: Kunwu.Chan --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c index ce971a93d28b..c26e12ff532c 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c @@ -1981,8 +1981,10 @@ static ssize_t smu_v13_0_6_get_gpu_metrics(struct smu_context *smu, void **table metrics = kzalloc(sizeof(MetricsTable_t), GFP_KERNEL); ret = smu_v13_0_6_get_metrics_table(smu, metrics, true); - if (ret) + if (ret) { + kfree(metrics); return ret; + } smu_cmn_init_soft_gpu_metrics(gpu_metrics, 1, 3); -- 2.25.1