Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp2326885rdb; Mon, 9 Oct 2023 23:47:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFbQ53J2TwsuvjQZjeswzyJUvcseJmvfmQzeCnpVbt0f5RXRuv5owb/ZaWBLGpJGfQomPoH X-Received: by 2002:a05:6a21:7742:b0:16c:b5fd:1b58 with SMTP id bc2-20020a056a21774200b0016cb5fd1b58mr9990043pzc.32.1696920444366; Mon, 09 Oct 2023 23:47:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696920444; cv=none; d=google.com; s=arc-20160816; b=nh4sEve5ipHWr5mm6jR+fTfTjAcFIla+WhR72kiFTPuBCZR2IwW0I5BpQkFW9InVf9 JSH0aLYxo9tUDVW2zCQ7hjDuRjqbadV8sJ4LgjLcRlg5CLbsX0AqmjobPre2Iu04/W1C bms2mIEitdEhAdETnYFqijP6mZ9twwwGKX1D3WpBlGnbzgIbW/3rY58XVTlzRBTwK3Sm fHi0m7xLp3fzwqxVPEOg4uxTTz6kzDgbAOQ/dVgQjhIfKbD6+jX9OzE3Jbb5zfgFau+4 KlkrY9c65DvWFUlw75yEWjfyN0RgeHOxGkvimaVQo+Ap2KoDovlPPjfjTU1rQOO/v39B WJuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=fVfwzDbo5Kc4i4rlTbkYOzLkB4fLvg8axYuIJPcNuUQ=; fh=wFvkM9osNU8sYLmqaGTuFInFBWzcJKoGp+WLNOXGmbE=; b=p2E25p9Tjw340wTr0sUkGpNLQAMfWBigZlFUq+Ue6LoQWcfxMyQhurx4uUBd2xvmJK AsrUndaASf49eKdxLmHr4vJP8gsVfu9xv0+6vUaH18IVRaa6aZETf2KHlc3tzKQSFNCK PGyEPH9gBxsSUXf8VYatJDMw62cJ+XikXGhrAVLtt2z3VHW+zJOlg2t5yW4OXuUIFVL5 Fb/LaCaJPeOvhcRtUrsgKTdz5i1lnLSqDYdCy5Eg7BxnnXzuZAYWFnPiYlZNDv7rq/S9 Td7xKd3qHZiYgVi8t0GuprrloqPy1/qKF7qK+ucH2eucMTflL/EIA4YW3gFu6K7goopd pOPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id km5-20020a17090327c500b001c3c75842f1si10662926plb.14.2023.10.09.23.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 23:47:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 3CBCA8129AC9; Mon, 9 Oct 2023 23:47:23 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442156AbjJJGrQ (ORCPT + 99 others); Tue, 10 Oct 2023 02:47:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442275AbjJJGrK (ORCPT ); Tue, 10 Oct 2023 02:47:10 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3436A9E for ; Mon, 9 Oct 2023 23:47:08 -0700 (PDT) Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4S4RCp2SByztT2f; Tue, 10 Oct 2023 14:42:30 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 10 Oct 2023 14:47:05 +0800 From: Kefeng Wang To: Andrew Morton CC: , , , , , Zi Yan , Kefeng Wang Subject: [PATCH -next 2/7] mm: mprotect: use a folio in change_pte_range() Date: Tue, 10 Oct 2023 14:45:39 +0800 Message-ID: <20231010064544.4162286-3-wangkefeng.wang@huawei.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20231010064544.4162286-1-wangkefeng.wang@huawei.com> References: <20231010064544.4162286-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm100001.china.huawei.com (7.185.36.93) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 09 Oct 2023 23:47:23 -0700 (PDT) Use a folio in change_pte_range() to save three compound_head() calls. Signed-off-by: Kefeng Wang --- mm/mprotect.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/mm/mprotect.c b/mm/mprotect.c index b94fbb45d5c7..459daa987131 100644 --- a/mm/mprotect.c +++ b/mm/mprotect.c @@ -114,7 +114,7 @@ static long change_pte_range(struct mmu_gather *tlb, * pages. See similar comment in change_huge_pmd. */ if (prot_numa) { - struct page *page; + struct folio *folio; int nid; bool toptier; @@ -122,13 +122,14 @@ static long change_pte_range(struct mmu_gather *tlb, if (pte_protnone(oldpte)) continue; - page = vm_normal_page(vma, addr, oldpte); - if (!page || is_zone_device_page(page) || PageKsm(page)) + folio = vm_normal_folio(vma, addr, oldpte); + if (!folio || folio_is_zone_device(folio) || + folio_test_ksm(folio)) continue; /* Also skip shared copy-on-write pages */ if (is_cow_mapping(vma->vm_flags) && - page_count(page) != 1) + folio_ref_count(folio) != 1) continue; /* @@ -136,14 +137,15 @@ static long change_pte_range(struct mmu_gather *tlb, * it cannot move them all from MIGRATE_ASYNC * context. */ - if (page_is_file_lru(page) && PageDirty(page)) + if (folio_is_file_lru(folio) && + folio_test_dirty(folio)) continue; /* * Don't mess with PTEs if page is already on the node * a single-threaded process is running on. */ - nid = page_to_nid(page); + nid = folio_nid(folio); if (target_node == nid) continue; toptier = node_is_toptier(nid); @@ -157,7 +159,7 @@ static long change_pte_range(struct mmu_gather *tlb, continue; if (sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING && !toptier) - xchg_page_access_time(page, + xchg_page_access_time(&folio->page, jiffies_to_msecs(jiffies)); } -- 2.27.0