Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp2340766rdb; Tue, 10 Oct 2023 00:23:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG/SuSWjQNoF9dZn/pgJ1kd09UNwHqQbTRg+5gNbmbJG8tQiKdmEKJ7hI5Lvp1ZfiuyRK52 X-Received: by 2002:a17:903:1d0:b0:1bc:844:5831 with SMTP id e16-20020a17090301d000b001bc08445831mr17983097plh.57.1696922610617; Tue, 10 Oct 2023 00:23:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696922610; cv=none; d=google.com; s=arc-20160816; b=UzT/bfi/ThlGGG4xbNXaFwGjNh3J1DmwwpIuDKhVo+iHrmoQYT8KxkdMVHjYBtdtOd l5jlTGNa1G7ESdh7syQjtQEOm6WR7jtjrezitzhNHO2sWT6Kv3s2fKct/JRLhN4aJsLw MUqE9M7TZ4/v0d6LsPgxb/jaHToSfH4a8p+IoUAt46vYNXxq2LFooB6fOHWswnFeoqHL hASnyC9AwX7dxK5K6wIKMuNEpm0xPoO4ISe9AoLglY6WKWduNIO8zA3zNwhtV8s1NFOu DE6HpckX7c784qX25+YdoupQvxrsrsiIlKbzDZ2aPsVMCJlXYacKW9pt/bD3soeDLtV1 CUgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from; bh=2jdLI2KZt85q0oa0Um5JUYSiCrgoKmFcC18bDgOMg4A=; fh=F9H0iZxzs9ULv7Qw84t1qyrbu2FHO3t00opr6uFYwwg=; b=aDwbxFKyiDF843CP7qmRnEuUkI7L/ZH80BCwk03qqG3Iux/0vrMX+OrsVX/FgsKft4 0fWkmlyqbbPKQ/BSZIgzk9g68eCj3qCCnTSN7CuKhSmD/3+oy3d9fFMOyWFTeK+WJz8x o1JYOtpodHqPh4ciF9qNzz6lEPPhcY09N1RoJlVeA238ffmtP32Os9RLJQVobK8zT+Mi D4DnmLXK7whsMFGr2qHvWtlnuLk0mmCLD0pdkH1i+nKr1RQLOGBJxzp+ooKl/FxU5JSE 1VkDr5r47vG2eiJ5mfzCrRyaMpIBQvK+XPmaEPOxrQ35oko2ZSYMqlzibz+zFf8QEtBW UMxQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id t7-20020a1709027fc700b001c7545405b5si4467729plb.519.2023.10.10.00.23.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 00:23:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id EEBF0802D3A4; Tue, 10 Oct 2023 00:23:27 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442424AbjJJHXI (ORCPT + 99 others); Tue, 10 Oct 2023 03:23:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442492AbjJJHXE (ORCPT ); Tue, 10 Oct 2023 03:23:04 -0400 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D684BC4; Tue, 10 Oct 2023 00:22:59 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 124271BF206; Tue, 10 Oct 2023 07:22:55 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1qq74r-00GHj6-Tn; Tue, 10 Oct 2023 09:22:49 +0200 From: Peter Korsgaard To: Greg KH Cc: Javier Carrasco , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , syzbot+1f53a30781af65d2c955@syzkaller.appspotmail.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] net: usb: dm9601: fix uninitialized variable use in dm9601_mdio_read References: <20231009-topic-dm9601_uninit_mdio_read-v2-1-f2fe39739b6c@gmail.com> <2023101036-fleshy-dude-aec0@gregkh> <87v8bfc83f.fsf@48ers.dk> <2023101018-venomous-uncured-47cf@gregkh> Date: Tue, 10 Oct 2023 09:22:49 +0200 In-Reply-To: <2023101018-venomous-uncured-47cf@gregkh> (Greg KH's message of "Tue, 10 Oct 2023 08:33:35 +0200") Message-ID: <87r0m3c56e.fsf@48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: peter@korsgaard.com X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 10 Oct 2023 00:23:28 -0700 (PDT) X-Spam-Level: ** >>>>> "Greg" == Greg KH writes: > On Tue, Oct 10, 2023 at 08:19:48AM +0200, Peter Korsgaard wrote: >> >>>>> "Greg" == Greg KH writes: >> >> > On Tue, Oct 10, 2023 at 12:26:14AM +0200, Javier Carrasco wrote: >> >> syzbot has found an uninit-value bug triggered by the dm9601 driver [1]. >> >> >> >> This error happens because the variable res is not updated if the call >> >> to dm_read_shared_word returns an error. In this particular case -EPROTO >> >> was returned and res stayed uninitialized. >> >> >> >> This can be avoided by checking the return value of dm_read_shared_word >> >> and propagating the error if the read operation failed. >> >> >> >> [1] https://syzkaller.appspot.com/bug?extid=1f53a30781af65d2c955 >> >> >> >> Signed-off-by: Javier Carrasco >> >> Reported-and-tested-by: syzbot+1f53a30781af65d2c955@syzkaller.appspotmail.com >> >> --- >> >> Changes in v2: >> >> - Remove unnecessary 'err == 0' case >> >> - Link to v1: https://lore.kernel.org/r/20231009-topic-dm9601_uninit_mdio_read-v1-1-d4d775e24e3b@gmail.com >> >> --- >> >> drivers/net/usb/dm9601.c | 7 ++++++- >> >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> > What commit id does this fix? >> >> It has been there since the beginning, so: >> >> Fixes: d0374f4f9c35cdfbee0 ("USB: Davicom DM9601 usbnet driver") >> >> Acked-by: Peter Korsgaard > Great, can someone add a cc: stable@ tag for this too please? Cc: stable@vger.kernel.org -- Bye, Peter Korsgaard