Date: Thu, 15 Nov 2007 08:34:35 -0800
From: Greg KH <gregkh@suse.de>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       Alexey Dobriyan <adobriyan@sw.ru>, linux-kernel@vger.kernel.org
Subject: Re: EIP is at device_shutdown+0x32/0x60
Message-ID: <20071115163435.GC24087@suse.de>
References: <20071115091158.GB6216@localhost.sw.ru> <20071115014446.f943d835.akpm@linux-foundation.org> <20071115213345.B3C1.Y-GOTO@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20071115213345.B3C1.Y-GOTO@jp.fujitsu.com>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2260
Lines: 63

On Thu, Nov 15, 2007 at 09:55:34PM +0900, Yasunori Goto wrote:
> > On Thu, 15 Nov 2007 12:11:58 +0300 Alexey Dobriyan <adobriyan@sw.ru> wrote:
> > 
> > > Three boxes rarely oops during reboot or poweroff with 2.6.24-rc2-mm1
> > > (1) and during 2.6.24 cycle (2):
> > > 
> > > 	kernel_restart
> > > 	sys_reboot
> > > 	[garbage]
> > > Code: 8b 88 a8 00 00 00 85 c9 74 04 89
> > > EIP is at device_shutdown+0x32/0x60
> > 
> > Yes, all my test boxes did that - it's what I referred to in the releaee
> > notes.  Greg is pondering the problem - seem he's the only person who
> > cannot reproduce it ;)
> 
> Fortunately, my ia64 box reproduces this oops "every time". 
> So, I could chase it.
> 
> device_shutdown() function in drivers/base/power/shutdown.c
> is followings.
> -----------
> /**
>  * device_shutdown - call ->shutdown() on each device to shutdown.
>  */
> void device_shutdown(void)
> {
>         struct device * dev, *devn;
> 
>         list_for_each_entry_safe_reverse(dev, devn, &devices_kset->list,
>                                 kobj.entry) {
>                 if (dev->bus && dev->bus->shutdown) {
>                         dev_dbg(dev, "shutdown\n");
>                         dev->bus->shutdown(dev);
>                 } else if (dev->driver && dev->driver->shutdown) {
>                         dev_dbg(dev, "shutdown\n");
>                         dev->driver->shutdown(dev);
>                 }
>         }
> }
> --------
> When oops occured, dev->driver pointed kset_ktype's address,
> and dev->driver->shutdown was the address of bus_type_list.
> So, Oops was caused by "Illegal operation fault".
> kset_ktypes is pointed by system_kset.
> 
> If my understanding is correct, this loop can't distinguish between
> struct device and struct kset, but both are connected in this list,
> right? It may be the cause of this.

Hm, no, it should just be a list of devices for the kset, but I'll go
verify that this is correct.

And yeah, I can duplicate this problem here too...

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/