Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp2342616rdb; Tue, 10 Oct 2023 00:28:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG9CszegEI5LzjklvexHA30sMLBwzrSVreUASxKB+q7f2VrZ4o4l0lTQzvE8y1GYTC5teKm X-Received: by 2002:a17:902:904c:b0:1c6:2ae1:dc28 with SMTP id w12-20020a170902904c00b001c62ae1dc28mr13136145plz.36.1696922935092; Tue, 10 Oct 2023 00:28:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696922935; cv=none; d=google.com; s=arc-20160816; b=mg4aqQ+8N0fXZGDCOpVNnQvCH6Z9qyLjzsOvMcUnqlK2rBkZp3Jh7j7bN4bodsld17 6cJylQn4W9N8Au0KTm/G5qwXIj5CtrKQtQ2QoK0Xq5Pa0Be10a274rXJjYf4xXWc7X8e H46jztjaVyyo1DgdH7B+iNJh177cBXU5gJKSpze0MN/xnVzPGgwatNOA8V08AleBGrw6 CEc4jCMvKsfeacnq63ELaSjnxNdh6Wxu2hQ+8qm2sy9JOAqDC/efIZ/fuKoiDxuWBfcc ehT9fV0dUXGM36AyAJ8CUdbVt1vLTjonZa39Gxa1oIMxf3SETi8G6JQ1UM3UaJeEP88U c7bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Wpy9WP/UCBwtgaMbXdX/g7mkd8dZX2MZlNQp7mfQjhU=; fh=8CNBSRFV3xjMAZY8COLF3Jvv14QtuO+QanlN3ZPtSQU=; b=aD2hQGzKva5fETu44DG4Mlyuo/nnZpofXA0tOPxotmHX1W3m7Oq2wejb6vJF9Jj+Q8 TTi99lgKmcx+leabHyuJuTcnqiceOd+AiOhfjlxldjQDkDNCToQfrtZfizoba8OpRhF4 qZTMiKgI5LAluHe3w8x261KIgeQNSL67Tm6M0Jp0EVo1+FhsOlmRQr6/G4GmtNK/OpXa jWMDPV5jqr3rGgVXQcdNEcW0y2XsqeKKUq1VDbDuvEjXmlbtKTfAKYkCAsew9swaZMlJ 5+ik/H6dsqxiqoQpqLu35aAC5NNK7jgLu4WSOSD5H/sc42FQ2MtsnHisct/5WPd0dZ9X 0FNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=i5OxoLlC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id w11-20020a170902e88b00b001b81fe65fa3si12095859plg.569.2023.10.10.00.28.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 00:28:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=i5OxoLlC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 7D056802A6C7; Tue, 10 Oct 2023 00:28:52 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442324AbjJJH2l (ORCPT + 99 others); Tue, 10 Oct 2023 03:28:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442463AbjJJH2j (ORCPT ); Tue, 10 Oct 2023 03:28:39 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3572D99; Tue, 10 Oct 2023 00:28:37 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F57CC433C8; Tue, 10 Oct 2023 07:28:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696922916; bh=gh5hIh6rcBaHimJNcY2gva6GLzaDoxHgSRNJiNo7RBU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i5OxoLlCPxFh60ea+ER9v1u+E22jBWcfkzZZqqwa3gVu9IMowq4ekLryPn82LRKXB RZhtFQor8AeHTqdxwAxC0ogHo42hYBMzZy39xNbWDMUOBaWS62ffUMinogwJTXTC3c FGJ2/X94dIi9ubf5eFPbn7K98vlgxNGo8C55x2Lc= Date: Tue, 10 Oct 2023 09:28:33 +0200 From: Greg KH To: Peter Korsgaard Cc: Javier Carrasco , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , syzbot+1f53a30781af65d2c955@syzkaller.appspotmail.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] net: usb: dm9601: fix uninitialized variable use in dm9601_mdio_read Message-ID: <2023101025-sulfur-blurred-93ab@gregkh> References: <20231009-topic-dm9601_uninit_mdio_read-v2-1-f2fe39739b6c@gmail.com> <2023101036-fleshy-dude-aec0@gregkh> <87v8bfc83f.fsf@48ers.dk> <2023101018-venomous-uncured-47cf@gregkh> <87r0m3c56e.fsf@48ers.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r0m3c56e.fsf@48ers.dk> X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 10 Oct 2023 00:28:52 -0700 (PDT) X-Spam-Level: ** On Tue, Oct 10, 2023 at 09:22:49AM +0200, Peter Korsgaard wrote: > >>>>> "Greg" == Greg KH writes: > > > On Tue, Oct 10, 2023 at 08:19:48AM +0200, Peter Korsgaard wrote: > >> >>>>> "Greg" == Greg KH writes: > >> > >> > On Tue, Oct 10, 2023 at 12:26:14AM +0200, Javier Carrasco wrote: > >> >> syzbot has found an uninit-value bug triggered by the dm9601 driver [1]. > >> >> > >> >> This error happens because the variable res is not updated if the call > >> >> to dm_read_shared_word returns an error. In this particular case -EPROTO > >> >> was returned and res stayed uninitialized. > >> >> > >> >> This can be avoided by checking the return value of dm_read_shared_word > >> >> and propagating the error if the read operation failed. > >> >> > >> >> [1] https://syzkaller.appspot.com/bug?extid=1f53a30781af65d2c955 > >> >> > >> >> Signed-off-by: Javier Carrasco > >> >> Reported-and-tested-by: syzbot+1f53a30781af65d2c955@syzkaller.appspotmail.com > >> >> --- > >> >> Changes in v2: > >> >> - Remove unnecessary 'err == 0' case > >> >> - Link to v1: https://lore.kernel.org/r/20231009-topic-dm9601_uninit_mdio_read-v1-1-d4d775e24e3b@gmail.com > >> >> --- > >> >> drivers/net/usb/dm9601.c | 7 ++++++- > >> >> 1 file changed, 6 insertions(+), 1 deletion(-) > >> > >> > What commit id does this fix? > >> > >> It has been there since the beginning, so: > >> > >> Fixes: d0374f4f9c35cdfbee0 ("USB: Davicom DM9601 usbnet driver") > >> > >> Acked-by: Peter Korsgaard > > > Great, can someone add a cc: stable@ tag for this too please? > > Cc: stable@vger.kernel.org This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.