Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
MIME-Version: 1.0
References: <20231009111633.2319304-1-yajun.deng@linux.dev>
In-Reply-To: <20231009111633.2319304-1-yajun.deng@linux.dev>
From:   Eric Dumazet <edumazet@google.com>
Date:   Tue, 10 Oct 2023 09:31:10 +0200
Message-ID: <CANn89iLAEHW1yH9bP+kBqG=TbeXjsYH7JzMqPLXzBc-wXEzsZw@mail.gmail.com>
Subject: Re: [PATCH net-next v8] net/core: Introduce netdev_core_stats_inc()
To:     Yajun Deng <yajun.deng@linux.dev>
Cc:     davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Oct 9, 2023 at 1:16=E2=80=AFPM Yajun Deng <yajun.deng@linux.dev> wr=
ote:
>
> Although there is a kfree_skb_reason() helper function that can be used t=
o
> find the reason why this skb is dropped, but most callers didn't increase
> one of rx_dropped, tx_dropped, rx_nohandler and rx_otherhost_dropped.
>
> For the users, people are more concerned about why the dropped in ip
> is increasing.
>
> Introduce netdev_core_stats_inc() for trace the caller of
> dev_core_stats_*_inc().
>
> Also, add __code to netdev_core_stats_alloc(), as it's called with small
> probability. And add noinline make sure netdev_core_stats_inc was never
> inlined.
>
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> Suggested-by: Alexander Lobakin <aleksander.lobakin@intel.com>

Reviewed-by: Eric Dumazet <edumazet@google.com>

Thanks.