Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp2346497rdb; Tue, 10 Oct 2023 00:39:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHzyN0oaS5CEa0AvEZsTkC86djYGs52jYygzZglupcUYjgIFF4xxzvlM0283rjOECvRmPLu X-Received: by 2002:a17:90a:2f65:b0:279:6fbf:ff6f with SMTP id s92-20020a17090a2f6500b002796fbfff6fmr17227103pjd.37.1696923570837; Tue, 10 Oct 2023 00:39:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696923570; cv=none; d=google.com; s=arc-20160816; b=noXmPOe5QN8YP451RhFZPJD+8wNTxitxDPmwpYHRHvNsizfan1yt0MmoFX3YQak+2i dW8ZCUcmbPlZQoUjeLV5MoMn5t7E7OBBn7jYFFOqFhvbFRaVJPD3tcgWvlUD+rF26PdN FFNzkci2wWW91npo9dSCPOdktTcvPIYI5ss5JiFwbqA/vrcYz3vlo1lZrf+JnoiV8gyB dIqKQkldmMXbCPen5kOD1IsbiceD49R089r50Mj0vo3mJxuuj2hUa+magPp1R4bYeIRY VMkwR3K52ZoYZ3ziOOBH6HjJPXy/AyoM0NBe+JvyqtJ9GVy1/oFV5UiqUDBs+vdqd3Aj BaOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=g9HLjKQphoF1al/8pr129PFMpYKqfXvTRFbRdIYZSXY=; fh=JbrZmKu/AkvmKmL1gXCveXYv47ueMVobCi/48jko0C4=; b=ZT1fLSHtIals+LeaJPM0+zlxe8qVC80Jeg3o7F+JVfelMgajFblWtBmdjF6XFnEqwi CblV3/ZjsiYx9+E4/o7cvrl0ewWTFGNRh4BeD4mSY/VkLVwGP7P16uvBkDQJc9UndbKJ xZM9ToSyi9FscSXxhKl/lCwPmJbAkV/Tls7S2imJ3u3frGHJ1WUYC+aPEoTd/XSiuVqy j6nwOk+rZCqhBXkQU5cM87XapSn5lKxNeyUacirONtW9sjEAhRtlTe/ilhv2Y5XXR/1q 0twSAsVpxrVlZbDH1LKvWxQhTp1maIdNamAVNBlGGBUPh4iV7YyfSa8tn+o/4PBKheGU SVbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ionos.com header.s=google header.b=WBfuEJXC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=ionos.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id pf12-20020a17090b1d8c00b00278f81e54cdsi14913769pjb.19.2023.10.10.00.39.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 00:39:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@ionos.com header.s=google header.b=WBfuEJXC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=ionos.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 80802802A36F; Tue, 10 Oct 2023 00:39:28 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442562AbjJJHjP (ORCPT + 99 others); Tue, 10 Oct 2023 03:39:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442547AbjJJHjO (ORCPT ); Tue, 10 Oct 2023 03:39:14 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8AC1AF for ; Tue, 10 Oct 2023 00:39:12 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2b95d5ee18dso64705521fa.1 for ; Tue, 10 Oct 2023 00:39:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ionos.com; s=google; t=1696923551; x=1697528351; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=g9HLjKQphoF1al/8pr129PFMpYKqfXvTRFbRdIYZSXY=; b=WBfuEJXCLueaZuWoYq7WZtqSz5XtQzFmIlkkIoGm5+pPyIJNqCfBpTaOpImhbFCYBY Q+ahHeiGEJc1LmOcEkKXedqqU9hGv39B6Y4WIrc+Xh63PpQ+CW16eqxuMm5XMEyU4DTh YggdI8jY/TP8cLlcc0P/MJ99ZXNK/2putFhzLmgtPM55Hnnwtq0JJ84VDWisdLQEe/0B aMtm8BUbJWa6VGzwJRY3uD5P+hTubOHnGfLH+0oZa/Q1NS2lb74fRW1OJ7CFt5KPjjTp p4HPLGo6v/NPuyczsJtv7JkAigCug9A6Fk+MJe7Q1UTnyMwEORp/yjfGVg+FhIWlKfMa cuvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696923551; x=1697528351; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g9HLjKQphoF1al/8pr129PFMpYKqfXvTRFbRdIYZSXY=; b=tYvLFk1cZ75cgwL5hgtHi8eaMaJ43ALRPfP/GEaf2UsCkkNF/TMl/xXHBcU4hZgAEO SLW290Ah6t2c9kSb7Exz8B8eo/z+cFjpcxn5vVSY/OA+DF8X/w6myaHO8ZmMbZmeckdT d/T5oSJnRrzmC9ZK05jDYq/LsQrHMHR8qSnOjJGdxR8FCzmON0u9Gr4xj8d9PJD7LMfD 9lX/6ufpSrDxiAn8wKatkN04HQBqO/SWQMHK1wyEWy2Bv2fovkBIKDef8DRM/YFWraQA ho/O5CtAG/Bj1qcKylbjEPJUeSz+tZKgBfvkqtuagsnlGb8lyu2ykTG+ew2mvFDoqzke 4x1A== X-Gm-Message-State: AOJu0YwQNQcFjJgweuZ7WlKQXszxES5GyDlqDpmk+F6k3AowYgdn7a5x wFopA+z2gn+4x6SJG5d3tlFfpP26BYLcuIXL2eDQEbxMp3xh5D5hhTE= X-Received: by 2002:a2e:9bd2:0:b0:2bf:e855:8cbf with SMTP id w18-20020a2e9bd2000000b002bfe8558cbfmr13923869ljj.35.1696923550959; Tue, 10 Oct 2023 00:39:10 -0700 (PDT) MIME-Version: 1.0 References: <20231009165741.746184-1-max.kellermann@ionos.com> <20231009165741.746184-6-max.kellermann@ionos.com> <264fa39d-aed6-4a54-a085-107997078f8d@roeck-us.net> In-Reply-To: From: Max Kellermann Date: Tue, 10 Oct 2023 09:38:59 +0200 Message-ID: Subject: Re: [PATCH 6/7] fs/sysfs/group: make attribute_group pointers const To: Joe Perches Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 10 Oct 2023 00:39:28 -0700 (PDT) X-Spam-Level: ** On Tue, Oct 10, 2023 at 8:48=E2=80=AFAM Joe Perches wrote= : > My opinion is that const use in the kernel should almost > always have whitespace before and after it except when > preceded by a open parenthesis or a newline. So it shall be "void * const foo" (16k occurrences in the kernel) instead of "void *const foo" (3k occurrences)?