Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <5375f92abe85a49012c6bafbb21b579154d09f34.camel@perches.com>
Subject: Re: [PATCH 6/7] fs/sysfs/group: make attribute_group pointers const
From:   Joe Perches <joe@perches.com>
To:     Max Kellermann <max.kellermann@ionos.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Date:   Tue, 10 Oct 2023 01:01:51 -0700
In-Reply-To: <CAKPOu+_xPGdKuSdwh9NdKT+RGw1=JbpkBB3+GK0qnC8KbTyY7Q@mail.gmail.com>
References: <20231009165741.746184-1-max.kellermann@ionos.com>
         <20231009165741.746184-6-max.kellermann@ionos.com>
         <264fa39d-aed6-4a54-a085-107997078f8d@roeck-us.net>
         <CAKPOu+8k2x1CucWSzoouts0AfMJk+srJXWWf3iWVOeY+fWkOpQ@mail.gmail.com>
         <f511170fe61d7e7214a3a062661cf4103980dad6.camel@perches.com>
         <CAKPOu+_xPGdKuSdwh9NdKT+RGw1=JbpkBB3+GK0qnC8KbTyY7Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-10-10 at 09:38 +0200, Max Kellermann wrote:
> On Tue, Oct 10, 2023 at 8:48 AM Joe Perches <joe@perches.com> wrote:
> > My opinion is that const use in the kernel should almost
> > always have whitespace before and after it except when
> > preceded by a open parenthesis or a newline.
> 
> So it shall be "void * const foo" (16k occurrences in the kernel)
> instead of "void *const foo" (3k occurrences)?

I think so.

$ git grep -P -oh "\bconst\s*\*" | sort | uniq -c | sort -rn | head -3
   2538 const *
    349 const*
     20 const	*
$ git grep -P -oh "\*\s*const\b" | sort | uniq -c | sort -rn | head -3
  16677 * const
   2912 *const
      8 *   const

Documentation/process/coding-style.rst doesn't mention const.
Maybe it should.