Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "Martins, Joao" <joao.m.martins@oracle.com>
Subject: RE: [RFC 3/7] iommufd: Add iommufd_device_bind_pasid()
Thread-Topic: [RFC 3/7] iommufd: Add iommufd_device_bind_pasid()
Thread-Index: AQHZ+o3RxhI7HHkgwkmih2zPzlCqT7BCrnxA
Date:   Tue, 10 Oct 2023 08:19:36 +0000
Message-ID: <BN9PR11MB5276BCF486E9E4F24913883E8CCDA@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20231009085123.463179-1-yi.l.liu@intel.com>
 <20231009085123.463179-4-yi.l.liu@intel.com>
In-Reply-To: <20231009085123.463179-4-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Vu8mq/mUZHUr6yV8BpUJvaqBdf5Xn/w0JV5qH+xwK/4kG74CEk34dYm/bDfz?=
 =?us-ascii?Q?YOeobH67uIm+DVnksZ+RUA1Sp30mV15wKIhG9G9osJG+9IIkYbdEU+QJHEqO?=
 =?us-ascii?Q?Wst42UJU0StuxCDtWKoP93SQ4LmYiRwFxrh/OtFgYAZEFSk3i7XLb/HYuZeB?=
 =?us-ascii?Q?A48KMa05W4fgA6PN8FNP3rLFI63rxlxiunB/woiFvi3ookYLv2iuLKeJYsJM?=
 =?us-ascii?Q?EKWFgRi1LMyLmnoHGOcAZjrCEGq5PRPqr66gDRvX/uCxnW5SvkzrvCDygzOR?=
 =?us-ascii?Q?Ur07XDE5NzOtgENaUUDtF3P4UjaY1zPO6KRlH83xamusoAhRHJ3NCNujhXx6?=
 =?us-ascii?Q?AW/cKhmFVrIEKQpdA5syOmttRrK3NS4/xnOLdqfKIOFuaXb1098rL3galbo+?=
 =?us-ascii?Q?0tcukHHpqqOPfK6mYX4wKIOJACj2yml/K9ZUsFGltS1tnnC7CIUWaOa9y3JG?=
 =?us-ascii?Q?OZLJywrnyQpTv+CUXIfTrVuj6qRUwBZ8I2HSfldvShCQDn0j8YSqcI4B+5su?=
 =?us-ascii?Q?XMzVO7NI89viVjw39fPSjULH6EDyzg0iy+j67BPw9tcP0ScraCNhI6kMy/hj?=
 =?us-ascii?Q?3o6yUTsrXzDGWinSfs37JgT/2mDvnJ/oO9tozt5Ezimh7zRCW3E2JM+XRw3o?=
 =?us-ascii?Q?9+Fb+NHsPstew4XLDzPdiMUN3CucHZcG0XR+c/40YV83cUD8PUnTApPRgTxm?=
 =?us-ascii?Q?AidW+kNK1UgXAlDf4SV9rfDXswtrQXsRySgZk8zuVSyYiAZp4vMAYh/PhlOx?=
 =?us-ascii?Q?M40h/f2pY+gDmqeHGeOZ+ftSdVuxLLlp11z+DQhXxfwdcuyn9UP167q4qtD1?=
 =?us-ascii?Q?nb31gmwD1lj/Jsp9hIrOLurL2h7lSG+QDK3c8Sh7IxKL4/wok+SVyOKbAKAw?=
 =?us-ascii?Q?HJM+UXdNWK50lIFPZM+EjbtzmQiJ0GdohCC1sJqh2CV9J9GfUK8xidV1C/Yf?=
 =?us-ascii?Q?jb4xCNjJwwfE1/C1Gn+Nkc8U1Mb1LKcYv2N5R/TdXTA33sG/XKcWGG1VwLou?=
 =?us-ascii?Q?cKKr19RvLg7hH0/XWH2zMDze31eGKnTjNcThzcUEAYJ2EKBLUT6Xw0jueS6v?=
 =?us-ascii?Q?HlE7K9CMr4t9z0gvX/073qltS+nk1tod7dV1adirQbPJmRk3QflufPO0YrHx?=
 =?us-ascii?Q?ZuwPFSZNw8An419GACTCmKiKL6eRQdIAph9cKQqGxhpYWKn4F4MNv4QZ9Htf?=
 =?us-ascii?Q?cadcnIbxC8LgiMXF1yv+N3MaMz761DaCTpZ79ULBKP6wodq/tgXlcCSgePOa?=
 =?us-ascii?Q?0OqPqfFL7DWeDMecJ+9l5r4RT61C357JggcgJQUg/D9ob6ByOoWlTyleBtft?=
 =?us-ascii?Q?l1F8a9HGXrZq+aal0oU+BkXkTGg3BiwJ//Gl4lHKWqfF3vQ0TNqP8M5Q5NPT?=
 =?us-ascii?Q?crly3xpUJWwfAPd2ONKOGbc6x6Im5vqClXQA7wTGXWspVb373mIZ+qnMAh8w?=
 =?us-ascii?Q?MJ377tBATMTRdL/uwJw7l+ojXKgEJWhhLZKNSohKqpKOIQ99zNHn0PpKHnPO?=
 =?us-ascii?Q?ZZvlLFypMoJeqU3+dGHywpnv/D6QnHpZBAEYkE397qKzfhdDK71MDfZwO3Zt?=
 =?us-ascii?Q?QqXWCagkQY9IsuWOgSlkphCUmRAqtEbC+h7LSqcf?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30280b16-291d-4f19-574b-08dbc969a463
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2023 08:19:36.9549
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yhbAfhf2A8Iz/NwsA1KrsAM6rdfrj69Nk3JNFe+Ebzz9hkA933fsphGRDzjOF8OO0T1djzRxTlqVbxp1caGLNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7425
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 10 Oct 2023 01:20:38 -0700 (PDT)
X-Spam-Level: **

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Monday, October 9, 2023 4:51 PM
>
> +struct iommufd_device *iommufd_device_bind_pasid(struct iommufd_ctx
> *ictx,
> +						 struct device *dev,
> +						 u32 pasid, u32 *id)
> +{
> +	struct iommufd_device *idev;
> +	int rc;
> +
> +	/*
> +	 * iommufd always sets IOMMU_CACHE because we offer no way for
> userspace
> +	 * to restore cache coherency.
> +	 */
> +	if (!device_iommu_capable(dev, IOMMU_CAP_CACHE_COHERENCY))
> +		return ERR_PTR(-EINVAL);
> +
> +	/*
> +	 * No iommu supports pasid-granular msi message today. Here we
> +	 * just check whether the parent device can do safe interrupts.
> +	 * Isolation between virtual devices within the parent device
> +	 * relies on the parent driver to enforce.
> +	 */
> +	if (!iommufd_selftest_is_mock_dev(dev) &&
> +	    !msi_device_has_isolated_msi(dev)) {
> +		rc =3D iommufd_allow_unsafe_interrupts(dev);
> +		if (rc)
> +			return ERR_PTR(rc);
> +	}
> +

Only MemWr w/o pasid can be interpreted as an interrupt message
then we need msi isolation to protect.

But for SIOV all MemWr's are tagged with a pasid hence can never
trigger an interrupt. From this angle looks this check is unnecessary.