Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "Martins, Joao" <joao.m.martins@oracle.com>
Subject: RE: [RFC 4/7] iommufd: Support attach/replace for SIOV virtual device
 {dev, pasid}
Thread-Topic: [RFC 4/7] iommufd: Support attach/replace for SIOV virtual
 device {dev, pasid}
Thread-Index: AQHZ+o3TGRj6hZeZREyTEbCUScXqbrBCsA6Q
Date:   Tue, 10 Oct 2023 08:24:25 +0000
Message-ID: <BN9PR11MB5276EE3482E71D50B3296FAC8CCDA@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20231009085123.463179-1-yi.l.liu@intel.com>
 <20231009085123.463179-5-yi.l.liu@intel.com>
In-Reply-To: <20231009085123.463179-5-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8UZCDjEAqsDLfe++Wuz7EQKcbqqSuB9Uo8SLVGiCVSPvhB34W1smQRVEC/aL?=
 =?us-ascii?Q?b6hrOeRQ2y9EKwOKGq2t5XQ7odmi1Um/77pi5OP6rII7rZ5sGNZ3U+MbVTLQ?=
 =?us-ascii?Q?KPxQYFi5B3dQSnRZIIfuksMXRHM3hYF0+RngM5fPkqYgy+dxQG+DdezgbeEX?=
 =?us-ascii?Q?D4YDTVLw1l7/zmBspeLFSw0nVdpVaigI8KIUuYRv8PxWYmTrOfshmxT6B28i?=
 =?us-ascii?Q?SWI1aCIKokpL39/Y3uNSmxaN/6U4NX2XSnQpL6e3eIZAUUSbrkxcVAU1ZO3c?=
 =?us-ascii?Q?XnzJsNj1SRl6DowfI1H2o5BkR4xy0UKdRa+6LKPsEL+PDgJ6xKlmbr/Gx05I?=
 =?us-ascii?Q?fnMcUdlZF2o/uQikqh3ayEapgLgwdq0VVuByiJLIqdHW+FsGPgawUVZ9NTU9?=
 =?us-ascii?Q?4iVrtEOZuwMWpRMPXPT2FNiNncje7hUaGnFxyLuq4QK2xpF6mE0SX+5XZRde?=
 =?us-ascii?Q?rC3dnr0Ea2zVBgquM76hjb1q9kwKSfVd94S6GTgdZgPMVpcscn5w19cAPixW?=
 =?us-ascii?Q?UEthn9s9VtvxDvwD91DTvtgTVaaFq1pUYqr3czmJvCCax8l97CG7/BM8HJHv?=
 =?us-ascii?Q?30PnpYRUd3s/iIGwe34hcm8FTSUDMgex2NCzzJ1czTOhtHc/o8rOYj+wwlka?=
 =?us-ascii?Q?DuTGTPenQZjBP5D4ziQbMaY3rypL5Xe/MMZp+I7xH48oSNJc5il5JTrP1O/f?=
 =?us-ascii?Q?q1jbNViUgdgHQFtcOdKt1I4zyWSrWbm4pI8b4+Vj0Rcuh7RVH3vHnCyogxwg?=
 =?us-ascii?Q?z/6cxDXM38LLzUI1jyi49msw4tWF5R6XOTbBtHW6wU1LHq9zWnPLDunPVTRW?=
 =?us-ascii?Q?qViBDJ3oRQudWKWgRuvpse+zd4b89YW3CYcS6/fxMZ6e5w3utoKBk5AUWiuJ?=
 =?us-ascii?Q?/cD4JVkSgaAWqHU36BI92Tm2eiuhGcGNGSTOsMSrE9Hf87CrbuLg4zZ9Zle3?=
 =?us-ascii?Q?hrTkF9odVhw8KSrWY7IoMzsDFiHoSyvY5ucfDQ7akD7VYkAXd9hZj35WUYhT?=
 =?us-ascii?Q?7+VZC6HfFC3J8CknWtIGN2tLGWx39yocDpSu2COpEkC3SmLCw4/A4xfvKg7K?=
 =?us-ascii?Q?nbhsRIy2lsfWQhq+TwxAJ+KSUmd9VVA1pMDYNf8JUiyDKY8z1TaDMYhFrM/U?=
 =?us-ascii?Q?DjtCaYfRxRLSRXGAKY8fe5aydTpD9ynr8Z8Bqfyczt4l+zZ7yjJzTwJZiTB0?=
 =?us-ascii?Q?EjQbJBGtWeUrue27mtxb0OX/Hko11PVa6WIxvYnlEidfaL6k8mQgYmatEAvl?=
 =?us-ascii?Q?lzC04f2HLIPLdx+ZFQ1HwqXZOQ4r0+vbex6UdBpqQgkGGLk3p2+KHrQ/5JPE?=
 =?us-ascii?Q?cTfqX6uF7X92V9RJpoy4170G6qT/xEqTDHTOVG2ry6moCFo5PzYbmTkSXG+l?=
 =?us-ascii?Q?wgGo1dWKRE/yz+c+99BaagWFvlSR3IJu2FGSVTb1ralHYWpMj8ZejAgXOxqK?=
 =?us-ascii?Q?m1Zn80wiufPuaXsX4aWNoO3bLcPNdGwkCNCR+8pbDadldx4xZVj4CVLjMRd5?=
 =?us-ascii?Q?g2suD48DeybSsWUNlsy078lf52KFLsDXLzDvYB54ozp2ZES7CMvA4/HRM/5U?=
 =?us-ascii?Q?r64lWgPu4dMZF7sAd/HXKHC4Qz7HXZrGhywi7uCp?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d0f083b1-e50f-4aba-cb5d-08dbc96a507d
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2023 08:24:25.6511
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nV2n7m8Xe+vURblXItLJ/VykBx4oQDmn7yUoRuRHwJaSDozZDGiDnh/hKBVv+yevPFpFe5HWIgBZYQCBToP6yw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5316
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 10 Oct 2023 01:25:24 -0700 (PDT)
X-Spam-Level: **

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Monday, October 9, 2023 4:51 PM
>=20
> From: Kevin Tian <kevin.tian@intel.com>
>=20
> SIOV devices allows driver to tag different PASIDs for the virtual device=
s
> within it. Such driver should call iommufd_device_bind_pasid() to connect
> the pasid of the device to iommufd, and then driver is able to attach the
> virtual device to IOAS/HWPT with the iommufd_device_attach() API.
>=20
> Unlike physical devices, for SIOV virtual devices, iommufd_device_attach(=
)
> eventually uses the idev->default_pasid when the virtual device is attach=
ed

s/default_pasid/rid_pasid/? or just call it idev->pasid. 'default' adds sli=
ght
confusion instead...

> to an IOAS/HWPT. Also, there is no need to do immediate_attach per iommu
> domain allocation in the attach/replace path if any iommu domain allocati=
on
> happens since the attach/replace is eventually pasid attach/replace.

immediate_attach rationale belongs to earlier pasid attach series when
iommufd_device_pasid_attach() was introduced. Not here.