Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Tue, 10 Oct 2023 10:25:52 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Zhiquan Li <zhiquan1.li@intel.com>
Cc:     Ingo Molnar <mingo@kernel.org>, x86@kernel.org,
        linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        patches@lists.linux.dev, tony.luck@intel.com,
        naoya.horiguchi@nec.com
Subject: Re: [PATCH RESEND v2] x86/mce: Set PG_hwpoison page flag to avoid
 the capture kernel panic
Message-ID: <20231010082552.GCZSUKkHrtqxHfqol4@fat_crate.local>
References: <20230914030539.1622477-1-zhiquan1.li@intel.com>
 <ZRsUpM/XtPAE50Rm@gmail.com>
 <5b6bdf6a-760c-4ba3-95ec-2d4482ad9bac@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <5b6bdf6a-760c-4ba3-95ec-2d4482ad9bac@intel.com>
Precedence: bulk

On Tue, Oct 10, 2023 at 08:56:38AM +0800, Zhiquan Li wrote:
> 3. The solution in this patch overcomes all above drawbacks.  It set the
>    flag just before the production kernel calls panic(), which would not
>    introduce additional overhead in capture kernel or conflict with
>    other hwpoision-related code in production kernel.  Furthermore, it
>    leverages the already existing mechanisms to fix the issue as much as
>    possible, the code changes are also lightweight.

And the kdump kernel reads the page poison flags and so it avoids
copying them?

More comments as a reply to the patch.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette