Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "Martins, Joao" <joao.m.martins@oracle.com>
Subject: RE: [RFC 6/7] iommufd/selftest: Add test coverage for SIOV virtual
 device
Thread-Topic: [RFC 6/7] iommufd/selftest: Add test coverage for SIOV virtual
 device
Thread-Index: AQHZ+o3TxDEbyXSioEilwXFwg8S19rBCsXMQ
Date:   Tue, 10 Oct 2023 08:30:45 +0000
Message-ID: <BN9PR11MB5276A82597B194611BE01DFE8CCDA@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20231009085123.463179-1-yi.l.liu@intel.com>
 <20231009085123.463179-7-yi.l.liu@intel.com>
In-Reply-To: <20231009085123.463179-7-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KadJkG+sb/He/mSkG/C4PCx/eKvtC3ratz01uUgOUbwUn1kft2KWt45DV0GW?=
 =?us-ascii?Q?e5DCL6dYePKf90pzLrGCbbg+9op87sF6prtoscUHelRPSBQk1j284lk+BOgz?=
 =?us-ascii?Q?H+Zc0NXkut6vUzmioOCRRslX3ktSu5tLI0Oqa1ezkoDSAQTY0WQWLtkRp6Ty?=
 =?us-ascii?Q?0QYskCueYjOlUtrLCPDnDBlQWQJwAd4rrA/YZvD0WLyIHzZlG2Pj1excVzsN?=
 =?us-ascii?Q?w3Z7mvP5oXzHQQipZlcg8UdoDwBLOTxGm1IX3Gxl4heDxbzLFsTpjdQHgsxH?=
 =?us-ascii?Q?VLXp5bNoHbZebO1zMkm+LGUKMTt1euuQUykn67n1luMJ+vhWRTLGj1mwJ+8W?=
 =?us-ascii?Q?WHJ3IyXPZVbmvSzrZE50lkIypJwtzUiC4JbY7m2uJb4Xd/zn9me4Jozkt4dG?=
 =?us-ascii?Q?hwjw1RPg6lSqk3Rmih5d8EJGX7T1FEv2ErWEnS+L8/BBRkAF6yoPuRQdHgzp?=
 =?us-ascii?Q?RXMFLSToA7VnMKxBtfcVjGVJJEZwBZIeLQ7UdpNiwBkbq5ohrb0IfULQa/sZ?=
 =?us-ascii?Q?A7ukJCu2Ltl3x7aDVSGD4nTRytoF5ZEilPPNrAG+CDLZCMOjXItwPQPi64q0?=
 =?us-ascii?Q?p6Z2yfHU6Z6zuyCNXHRnHPepTLoutNDIfKoIde1HeuARrb+u8GP2TLbu+D+S?=
 =?us-ascii?Q?7kFh1Lk+XcB9hPDThD09FW7gnNMSjhQLJ2/lBGMG3HcM2zEAnkRqGSrrAh83?=
 =?us-ascii?Q?LyNtWeLYS5Dy/pBIirQJSz4dCMJOH60xVG4eJjnhcMJBw7CZyVMGnEkjSCzJ?=
 =?us-ascii?Q?BtwiakMakMdOu9nvluVot6pOt9HkHDURBT2ONCbDktAsQg9HGG9804CpAScv?=
 =?us-ascii?Q?Kn95oIPpGK4O+HGoI/o+ousM8FWeljwoRSp97qkWYL0jR9387SVPAMmtQe0y?=
 =?us-ascii?Q?GCFub/cV8/sic+73vKR5fWVxJ543Kb0OMZcnSoJvn/EJoT6GGv7Jn1r/aOJd?=
 =?us-ascii?Q?qNVxxUjL/zYOLXQV0dDCq75v0lmdFSZWnZ3bFszidd+EzuVsWMCjJuvNDzJb?=
 =?us-ascii?Q?IO/3osSCkq8bF94B0pSmoos5eJWJXImyWPoUPOaUax2OaNiR/Drr+ghXMCdx?=
 =?us-ascii?Q?YvLWbLy6yIMowMvi4BcCpXvBCSuI7MpYSDJsNzHikF8cLWaxfcwWfXb4rZEk?=
 =?us-ascii?Q?7mJrkxubejDWky59MwBedr4wmshpDIiGZS/a+1ZJRMaazewCg0lx6eqJ6+hG?=
 =?us-ascii?Q?xoxFKOkfhxCncySxRQr1L3JS5qGZoy8pIZ6eDwW9USBg6tRyYfIMdFh7+ZGR?=
 =?us-ascii?Q?YlVpSGNwRxLvR4RoYtKOZ7esbeyO8D7VL/ytcyXTU5dj6G99goCyLNZ7eMVE?=
 =?us-ascii?Q?c6A0Nn6icM90LoFPlAWeRyx6YSVLmmkmvuuV0AKL/k6L21hGFX8rxi1k5TsU?=
 =?us-ascii?Q?79h7axwXrBZKVrU6zQEpSusTMdKi4c+HA3o4NIMUnxUjNpRuAKK33jiPo5tJ?=
 =?us-ascii?Q?pqYrxDhwYl4xtyHeM86MV9IkbLI9JW4a52yo2SJVvZuk1P1yo1gbQr+bY+wq?=
 =?us-ascii?Q?xY89pkHsGNTOu107nfdeShcxVqq2d//DafxeEEVxIESQeDas/9OliGyBNvAz?=
 =?us-ascii?Q?91EvZGbLftuO1KBtrIzLZXBJMuyKNlSfwdmyRev7?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5baedeff-31dd-4e8f-d481-08dbc96b32d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2023 08:30:45.4491
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vFOrgnzgkYD+A4nFUArwlNzcR+L2uTApNEl6i1982a6zml9x22H4c4K8evfjVrzSEZvDM4CS1raVLuy9gXtLDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5316
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 10 Oct 2023 01:31:09 -0700 (PDT)
X-Spam-Level: **

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Monday, October 9, 2023 4:51 PM
>=20
> @@ -2071,6 +2083,43 @@ TEST_F(iommufd_device_pasid, pasid_attach)
>=20
> IOMMU_HWPT_ALLOC_DATA_SELFTEST,
>  					   &data, sizeof(data));
>=20
> +		if (variant->pasid) {
> +			uint32_t new_hwpt_id =3D 0;
> +
> +			ASSERT_EQ(0,
> +				  test_cmd_pasid_check_domain(self->fd,
> +							      self->stdev_id,
> +							      variant->pasid,
> +							      self->hwpt_id,
> +							      &result));
> +			EXPECT_EQ(1, result);
> +			test_cmd_hwpt_alloc(self->device_id, self->ioas_id,
> +					    0, &new_hwpt_id);
> +			test_cmd_mock_domain_replace(self->stdev_id,
> +						     new_hwpt_id);
> +			ASSERT_EQ(0,
> +				  test_cmd_pasid_check_domain(self->fd,
> +							      self->stdev_id,
> +							      variant->pasid,
> +							      new_hwpt_id,
> +							      &result));
> +			EXPECT_EQ(1, result);
> +
> +			/*
> +			 * Detach hwpt from variant->pasid, and check if the
> +			 * variant->pasid has null domain
> +			 */
> +			test_cmd_pasid_detach(variant->pasid);
> +			ASSERT_EQ(0,
> +				  test_cmd_pasid_check_domain(self->fd,
> +							      self->stdev_id,
> +							      variant->pasid,
> +							      0, &result));
> +			EXPECT_EQ(1, result);
> +
> +			test_ioctl_destroy(new_hwpt_id);
> +		}
> +

I wonder whether above better reuses the device attach/replace cases
given default_pasid is hidden inside iommufd_device. this pasid_attach
case is more for testing user pasids on a iommufd_device which hasn't
yet been supported by SIOV device?