Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Tue, 10 Oct 2023 17:03:48 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Cong Wang <xiyou.wangcong@gmail.com>
Cc:     Ma Ke <make_ruc2021@163.com>, steffen.klassert@secunet.com,
        davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ipv6: fix return value check in esp_remove_trailer
Message-ID: <ZSUTdBpSTgNz5CA8@gondor.apana.org.au>
References: <20231007005953.3994960-1-make_ruc2021@163.com>
 <ZSLh0vtpbP81Vh7G@pop-os.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZSLh0vtpbP81Vh7G@pop-os.localdomain>
Precedence: bulk

On Sun, Oct 08, 2023 at 10:07:30AM -0700, Cong Wang wrote:
> On Sat, Oct 07, 2023 at 08:59:53AM +0800, Ma Ke wrote:
> > In esp_remove_trailer(), to avoid an unexpected result returned by
> > pskb_trim, we should check the return value of pskb_trim().
> > 
> > Signed-off-by: Ma Ke <make_ruc2021@163.com>
> > ---
> >  net/ipv6/esp6.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> We need the same change for net/ipv4/esp4.c?

Please verify that it can actually fail first.  Note that I'm
busy right now so I haven't looked at it at all.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt