Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Tue, 10 Oct 2023 02:36:14 -0700
From:   Breno Leitao <leitao@debian.org>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     jlbec@evilplan.org, davem@davemloft.net, pabeni@redhat.com,
        Eric Dumazet <edumazet@google.com>, hch@lst.de,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        horms@kernel.org
Subject: Re: [PATCH net-next v2 1/3] netconsole: Initialize configfs_item for
 default targets
Message-ID: <ZSUbDibPcpd4TqCq@gmail.com>
References: <20231005123637.2685334-1-leitao@debian.org>
 <20231005123637.2685334-2-leitao@debian.org>
 <20231009193158.28a12cd8@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231009193158.28a12cd8@kernel.org>
Precedence: bulk

On Mon, Oct 09, 2023 at 07:31:58PM -0700, Jakub Kicinski wrote:
> On Thu,  5 Oct 2023 05:36:34 -0700 Breno Leitao wrote:
> > +static void populate_configfs_item(struct netconsole_target *nt,
> > +				   int cmdline_count);
> 
> Could you move alloc / free_param_target() to avoid the forward
> declaration? (separate patch)

Yes, this is a good idea. I tried to avoid the forward declaration, but
I didn't find this solution. Sending a v3 with this change.

Thanks for the review!