Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <ae210957-4a72-24b3-2f11-8d5824041e85@gmail.com>
Date:   Tue, 10 Oct 2023 12:45:15 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Content-Language: en-US, en-GB
To:     Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Paul Gazzillo <paul@pgazz.com>,
        Conor Dooley <conor+dt@kernel.org>,
        Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>
References: <20231008154857.24162-1-subhajit.ghosh@tweaklogic.com>
 <20231008154857.24162-3-subhajit.ghosh@tweaklogic.com>
From:   Matti Vaittinen <mazziesaccount@gmail.com>
Subject: Re: [PATCH 2/2] iio: light: Add support for APDS9306 Light Sensor
In-Reply-To: <20231008154857.24162-3-subhajit.ghosh@tweaklogic.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/8/23 18:48, Subhajit Ghosh wrote:
> Driver support for Avago (Broadcom) APDS9306
> Ambient Light Sensor with als and clear channels.
> This driver exposes raw values for both the channels and
> processed(lux) values for the als channel.
> Support for both with or without hardware interrupt
> configurations are provided.
> 
> Datasheet at https://docs.broadcom.com/doc/AV02-4755EN
> 
> Signed-off-by: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>

Hi Subhajit,

To my eyes this driver looks nice. Just spotted two minor things.

> ---
>   drivers/iio/light/Kconfig    |   12 +
>   drivers/iio/light/Makefile   |    1 +
>   drivers/iio/light/apds9306.c | 1381 ++++++++++++++++++++++++++++++++++
>   3 files changed, 1394 insertions(+)
>   create mode 100644 drivers/iio/light/apds9306.c
> 
...

> +
> +static int apds9306_intg_time_set(struct apds9306_data *data, int val2)
> +{
> +	struct device *dev = data->dev;
> +	int ret, intg_old, gain_old, gain_new, gain_new_closest;
> +	bool ok;
> +
> +	if (!iio_gts_valid_time(&data->gts, val2)) {
> +		dev_err(dev, "Unsupported integration time %u\n", val2);
> +		return ret;
> +	}
> +
> +	intg_old = iio_gts_find_int_time_by_sel(&data->gts,
> +						data->intg_time_idx);
> +	if (ret < 0)
> +		return ret;
> +
> +	if (intg_old == val2)
> +		return 0;
> +
> +	gain_old = iio_gts_find_gain_by_sel(&data->gts, data->gain_idx);
> +	if (gain_old < 0)
> +		return gain_old;
> +
> +	ret = iio_gts_find_new_gain_by_old_gain_time(&data->gts, gain_old,
> +				intg_old, val2, &gain_new);
> +	if (gain_new < 0) {
> +		dev_err(dev, "Unsupported gain with time\n");
> +		return gain_new;
> +	}
> +
> +	gain_new_closest = iio_find_closest_gain_low(&data->gts, gain_new, &ok);
> +	if (gain_new_closest < 0) {
> +		gain_new_closest = iio_gts_get_min_gain(&data->gts);
> +		if (gain_new_closest < 0)
> +			return gain_new_closest < 0;

Returning the truth value on purpose? :)

> +	}
> +	if (!ok)
> +		dev_dbg(dev, "Unable to find optimum gain, setting minimum");
> +
> +	ret = iio_gts_find_sel_by_int_time(&data->gts, val2);
> +	if (ret < 0)
> +		return ret;
> +
> +	ret = apds9306_intg_time_set_hw(data, ret);
> +	if (ret)
> +		return ret;
> +
> +	ret = iio_gts_find_sel_by_gain(&data->gts, gain_new_closest);
> +	if (ret < 0)
> +		return ret;
> +
> +	return apds9306_gain_set_hw(data, ret);
> +}

...

> +static int get_device_id_lux_per_count(struct apds9306_data *data)
> +{
> +	int ret, part_id;
> +
> +	ret = regmap_read(data->regmap, APDS9306_PART_ID, &part_id);
> +	if (ret)
> +		return ret;
> +
> +	if (part_id == apds9306_part_id_nlux_per_count[0].part_id)
> +		data->nlux_per_count =
> +			apds9306_part_id_nlux_per_count[0].nlux_per_count;
> +	else if (part_id == apds9306_part_id_nlux_per_count[1].part_id)
> +		data->nlux_per_count =
> +			apds9306_part_id_nlux_per_count[1].nlux_per_count;
> +	else
> +		return -ENXIO;

I think we should be able to differentiate between the IC variants by DT 
compatible. (Commented that on bindings patch). Not sure if we need to 
support cases where the sensor is instantiated without device-tree. I am 
not super happy when code requires the part-id to be known if we have 
separate compatibles for variants. Can we in dt-case just print a 
warning if the part-ID is not what we expect - and proceed assuming the 
nlux_per_count based on the DT information? (Sometimes we see new 
variants with same part-IDs - or many part-IDs with no SW changes 
needed. Hence maintaining the part-ID lists may be tedious). This is 
just some pondering though, no strong requirements from my side

> +
> +	return 0;
> +}
> +

Yours,
	-- Matti

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~