Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Tue, 10 Oct 2023 11:03:50 +0100
From:   David Woodhouse <dwmw2@infradead.org>
To:     Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Like Xu <like.xu.linux@gmail.com>
CC:     Oliver Upton <oliver.upton@linux.dev>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v7=5D_KVM=3A_x86/tsc=3A_Don=27t_sync?= =?US-ASCII?Q?_user-written_TSC_against_startup_values?=
User-Agent: K-9 Mail for Android
In-Reply-To: <169689823852.390348.16203872510226635933.b4-ty@google.com>
References: <20231008025335.7419-1-likexu@tencent.com> <169689823852.390348.16203872510226635933.b4-ty@google.com>
Message-ID: <D764860F-5DBC-49DD-8909-D08A3C24BC42@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 10 October 2023 01:44:32 BST, Sean Christopherson <seanjc@google=2Ecom>=
 wrote:
>On Sun, 08 Oct 2023 10:53:35 +0800, Like Xu wrote:
>> The legacy API for setting the TSC is fundamentally broken, and only
>> allows userspace to set a TSC "now", without any way to account for
>> time lost to preemption between the calculation of the value, and the
>> kernel eventually handling the ioctl=2E
>>=20
>> To work around this we have had a hack which, if a TSC is set with a
>> value which is within a second's worth of a previous vCPU, assumes that
>> userspace actually intended them to be in sync and adjusts the newly-
>> written TSC value accordingly=2E
>>=20
>> [=2E=2E=2E]
>
>Applied to kvm-x86 misc, thanks!  I massaged away most of the pronouns in=
 the
>changelog=2E  Yes, they bug me that much, and I genuinely had a hard time=
 following
>some of the paragraphs even though I already knew what the patch is doing=
=2E
>
>Everyone, please take a look and make sure I didn't botch anything=2E  I =
tried my
>best to keep the existing "voice" and tone of the changelog (sans pronoun=
s
>obviously)=2E  I definitely don't want to bikeshed this thing any further=
=2E  If
>I've learned anything by this patch, it's that the only guaranteed outcom=
e of
>changelog-by-committee is that no one will walk away 100% happy :-)

LGTM=2E I forgive you for not respecting my pronouns=2E :)

Thanks=2E