Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Tue, 10 Oct 2023 19:09:20 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        David Airlie <airlied@redhat.com>,
        Gerd Hoffmann <kraxel@redhat.com>,
        Gurchetan Singh <gurchetansingh@chromium.org>,
        Chia-I Wu <olvaffe@gmail.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Akihiko Odaki <akihiko.odaki@daynix.com>,
        =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@gmail.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Ragiadakou, Xenia" <Xenia.Ragiadakou@amd.com>,
        "Stabellini, Stefano" <stefano.stabellini@amd.com>,
        "Huang, Honglei1" <Honglei1.Huang@amd.com>,
        "Zhang, Julia" <Julia.Zhang@amd.com>,
        "Chen, Jiqian" <Jiqian.Chen@amd.com>
Subject: Re: [PATCH v2] drm/virtio: add definitions for gfxstream and venus
 capset
Message-ID: <ZSUw4IY+13Yfd+Tx@amd.com>
References: <20231010032553.1138036-1-ray.huang@amd.com>
 <245f993a-72f2-7834-34b4-345f97737be1@collabora.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <245f993a-72f2-7834-34b4-345f97737be1@collabora.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SUvZ64aE1KfJAHLda60z83s7NmivTwgsWDT2F7gwj5nUayXLVelHeYdSJx/e?=
 =?us-ascii?Q?Fadm5jj5HS6sG4n5A8UxF+XD8xByYhfzwSJuNbjWP/Rbvs7zthABkdTFCU61?=
 =?us-ascii?Q?HE+MLvvl0ZTNWJl6MxBkRKLa/7H1q8Y4z2mpmmdBmbI2XxWSX2ZcMLCsXEtK?=
 =?us-ascii?Q?Cw9odFxlyBmPCzIeLF30j6yEvULmoyT0OG4yL/WMJhBKmrRE1Sg/e5dxRFsy?=
 =?us-ascii?Q?QmEpyXeEilP0GkUJRZ8EBIXOvhnBWflsaZNv8etGQfZoKGLN1mkB7WfOwaUT?=
 =?us-ascii?Q?5jfqfx3AQ7RvTgefm11StOBb+EhPWOY5rEPOxhvKNC7Kx6JZnlXCIEQ9VU1Q?=
 =?us-ascii?Q?QJa27G+WXW1oO2xbErS+0ozMzZ+57VoOlhJfEVlwLNE0DFhdWDZV/asYqVi2?=
 =?us-ascii?Q?KF2KDdyAAJ55/12s0WQQSSiariwvOxZdFklL881O2EPDWkpDcUV8aQCaA249?=
 =?us-ascii?Q?X/6z1AWG+X7EhXEOBQ7YsCSCBtaebu3nrk4USsPZBHWi0MJSqsVfPKvV+qei?=
 =?us-ascii?Q?k9DbrxkZIcTUR0pqeuVHMb8CsZcol7/xXuc8+LaKJiiwfAVKPd9ClRYLuc5b?=
 =?us-ascii?Q?8XoqVNByBrJtcY9w6TcFUvAzm+k4Q/HQbJbsTlu1oVj6XAQ23vTK5GsIbeQo?=
 =?us-ascii?Q?Z2mjJlUkYBYV/KnBngv79Nb2dU0FCFnwbxuCF6cpOzLqjoeiDjWeSxolyDn7?=
 =?us-ascii?Q?0w4TfK7mpUsVKsSJ3RKDiT9AgZz/sWguXo32ml7zXPqiKcs3VtfNTi/Sv34/?=
 =?us-ascii?Q?j6Pd5rkHVdB432o+cZUpnJ293raSA4eD6m8LfYCeNKoBm9gOuXLxDjNshrsJ?=
 =?us-ascii?Q?D8xoTJgmG2S/eX5ywmoHivrWf8+OjTWOtS4EFu2LRX0mjaGdWmcksRHpLk6z?=
 =?us-ascii?Q?W7vI7SXYE76bHxpW4wmWVABg90co0YV0CfZ1T+iC8atAmXn5uxsPm5syEAMi?=
 =?us-ascii?Q?MS9kvIJyZhdnenzO5RmfFiyIAoRKQAZzOhBpNDBCp2R2CsrDDufzBt1Beb5Z?=
 =?us-ascii?Q?PRo5Vh96kmD81fXYwFkSp5zrZo8t6bceGTCB04pv/oZxih5u7QHUolhV0e7m?=
 =?us-ascii?Q?eTwKZt/d3fwk1TSa0SA8l+ycXN4yR4XV6HpYmnM1miW08ZXCE5YeQSc9Jju9?=
 =?us-ascii?Q?HiGxeGZvpu5q/Ob1zq53z1jn/7Stq7y3Xa2iza5ZWt0M4z5sxEnHsPcQwpoi?=
 =?us-ascii?Q?RbY1JUYuDJulecAWNKnRnXv2utPJDpT7V/Wluxxx0R7SQ7c8DuJc+wqZ49T8?=
 =?us-ascii?Q?vZ/GHR1fETShSCYVMD2SjfssKxzCNjLRaQ7y8tkk9hCjA+tXjZcRl2fR08L3?=
 =?us-ascii?Q?Y6/oJnUA8h/8/Pd6clC2gCGIEqfGXZ+w/Mxo0Uj0ClbhIOIcQ4G7VpMm+Usq?=
 =?us-ascii?Q?hNEdaSspR+2Ps7cnpYZUesNc5ge3oQqg8YlbbU0/mCkCGIuDESwl99FjNrJj?=
 =?us-ascii?Q?TP+ebAKfXAqR9OjJvhMrOb6cbjOw6XEXyJSMpOzt/sJiiyapxK+Flzp2ZMFC?=
 =?us-ascii?Q?hDcPrm5EgGgHxiVqVgJB1NGpoHmaATWxNQJxz9u8aEKp3WDUFIv8u5PpNm14?=
 =?us-ascii?Q?BcjeHaJkyElm+fmLmUoeVQXpN0ARz6yHIaOmPg/w?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8733a9ad-e760-4ae9-1846-08dbc981698e
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8690.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 11:09:46.7189
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jDZtH9vXp+BO3Gqn26iQBvAs6QM30KIeVqwe0qcMt/teQnJMgtiZGxgkeeJyJmzVTHfIMXU/uxctCD9t1I10VQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6627
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 10 Oct 2023 04:10:11 -0700 (PDT)
X-Spam-Level: **

On Tue, Oct 10, 2023 at 06:20:03PM +0800, Dmitry Osipenko wrote:
> Hi,
> 
> On 10/10/23 06:25, Huang Rui wrote:
> > These definitions are used fro qemu, and qemu imports this marco in the
> > headers to enable gfxstream or venus for virtio gpu. So it should add it
> > even kernel doesn't use this.
> > 
> > Signed-off-by: Huang Rui <ray.huang@amd.com>
> > ---
> > 
> > Changes V1 -> V2:
> > - Add all capsets including gfxstream and venus in kernel header (Dmitry Osipenko)
> > 
> > v1: https://lore.kernel.org/lkml/20230915105918.3763061-1-ray.huang@amd.com/
> > 
> >  include/uapi/linux/virtio_gpu.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/include/uapi/linux/virtio_gpu.h b/include/uapi/linux/virtio_gpu.h
> > index f556fde07b76..327792658bdc 100644
> > --- a/include/uapi/linux/virtio_gpu.h
> > +++ b/include/uapi/linux/virtio_gpu.h
> > @@ -309,6 +309,8 @@ struct virtio_gpu_cmd_submit {
> >  
> >  #define VIRTIO_GPU_CAPSET_VIRGL 1
> >  #define VIRTIO_GPU_CAPSET_VIRGL2 2
> > +#define VIRTIO_GPU_CAPSET_GFXSTREAM 3
> > +#define VIRTIO_GPU_CAPSET_VENUS 4
> >  
> >  /* VIRTIO_GPU_CMD_GET_CAPSET_INFO */
> >  struct virtio_gpu_get_capset_info {
> 
> By the "all" capsets, I meant to pick up all definitions from crosvm.
> There should be VIRTIO_GPU_CAPSET_DRM at minimum, could you please add it?
> 

Sure. Thanks for the reminder.

Best Regards,
Ray