Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   John Ogness <john.ogness@linutronix.de>
To:     Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Steven Rostedt <rostedt@goodmis.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Todd Brandt <todd.e.brandt@intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] printk: Reduce unnecessary wait times by pr_flush()
In-Reply-To: <ZSUPBiTXY486H1FV@alley>
References: <20231006082151.6969-1-pmladek@suse.com> <ZSUPBiTXY486H1FV@alley>
Date:   Tue, 10 Oct 2023 13:44:38 +0206
Message-ID: <87cyxmso5d.fsf@jogness.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On 2023-10-10, Petr Mladek <pmladek@suse.com> wrote:
>> This is an updated version of the patch
>> https://lore.kernel.org/r/20230929113233.863824-1-john.ogness@linutronix.de
>> 
>> Changes since v1:
>> 
>>   + Split reduction of the pooling time into separate patch.
>>   + Use jiffies to count the real sleeping time.
>> 
>> Note that my original POC counted jiffies spent in the entire cycle.
>> It would count also the time spent by console_lock() and by flushing
>> the legacy consoles in console_unlock().
>> 
>> The current version counts only the time spent by msleep(1) aka
>> the pooling interval.
>> 
>> 
>> John Ogness (1):
>>   printk: flush consoles before checking progress
>> 
>> Petr Mladek (1):
>>   printk: Reduce pr_flush() pooling time
>
> JFYI, the patchset has been committed into printk/linux.git,
> branch rework/misc-cleanups.
>
> I am going to push it in the next merge window for 6.7.
> IMHO, the issue is not critical and we are already at 6.6-rc5.

It is a real regression. I think it is important that it goes into
6.6. At least the first patch is simple enough and fixes the regression.

John