Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
MIME-Version: 1.0
References: <20231009211356.3242037-3-robh@kernel.org> <CAGb2v66ZHD8mMMNVwp+sTYT6DAFDUrP8ydeTo7KW+uUtBRM3bQ@mail.gmail.com>
In-Reply-To: <CAGb2v66ZHD8mMMNVwp+sTYT6DAFDUrP8ydeTo7KW+uUtBRM3bQ@mail.gmail.com>
From:   Rob Herring <robh@kernel.org>
Date:   Tue, 10 Oct 2023 06:44:38 -0500
Message-ID: <CAL_JsqJ4yCNnvg=CfY6_NbcgED9FuExK6SDTxDERFHK7Hp9-+g@mail.gmail.com>
Subject: Re: [PATCH] mfd: Use device_get_match_data()
To:     wens@csie.org
Cc:     Lee Jones <lee@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Tony Lindgren <tony@atomide.com>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-arm-msm@vger.kernel.org, linux-omap@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Oct 10, 2023 at 3:27=E2=80=AFAM Chen-Yu Tsai <wens@csie.org> wrote:
>
> On Tue, Oct 10, 2023 at 5:14=E2=80=AFAM Rob Herring <robh@kernel.org> wro=
te:
> >
> > Use preferred device_get_match_data() instead of of_match_device() to
> > get the driver match data. With this, adjust the includes to explicitly
> > include the correct headers.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> >  drivers/mfd/axp20x.c           | 22 +++-------------------
>
> I'd keep the error message, but otherwise for axp20x,

Why? It can't happen. We already matched successfully in order to
probe, so matching again in probe is redundant and won't fail.

> Reviewed-by: Chen-Yu Tsai <wens@csie.org>

Thanks.

Rob