Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <f30ee046-82b2-ad7e-f173-1ac9e8b29370@intel.com>
Date:   Tue, 10 Oct 2023 13:53:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v6 08/12] ASoC: Intel: avs: Move snd_hdac_i915_init to
 before probe_work.
Content-Language: en-US
From:   Cezary Rojewski <cezary.rojewski@intel.com>
To:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        <alsa-devel@alsa-project.org>
CC:     Maarten Lankhorst <dev@lankhorst.se>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Mark Brown <broonie@kernel.org>,
        "Daniel Baluta" <daniel.baluta@nxp.com>,
        <linux-kernel@vger.kernel.org>,
        <sound-open-firmware@alsa-project.org>,
        =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= 
        <amadeuszx.slawinski@linux.intel.com>
References: <20231004145540.32321-1-maarten.lankhorst@linux.intel.com>
 <20231004145540.32321-9-maarten.lankhorst@linux.intel.com>
 <4374f40f-b1ab-a009-8d7f-1f4b6f6355ee@intel.com>
In-Reply-To: <4374f40f-b1ab-a009-8d7f-1f4b6f6355ee@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHpFNHg0cjVVNGczd0MvNzNwRzFhQ0R2ZmpNQ3NuQ1lXb0oyNnNkaDI1RlpH?=
 =?utf-8?B?SmlMSnRFMjNmK3l5ME9mbXp1c2d3Wm5UWFVJMUhxZmlNbUpEcldPN1gxZDVk?=
 =?utf-8?B?aFlTRlNoeVJOK0tKdDhxM2puUGVJMUV4K1pxbFVvZkxDekNmdVF2SlFZRXJJ?=
 =?utf-8?B?NWdPQWZ1MUN4WHpaaW9aR0djT2dMWlhoblBWRGdnMTdHSExzZmtVelV4blVn?=
 =?utf-8?B?MnIvVVlBTVdndkpxUC90WkJ0aGtOMnBYc3lJaTc3Yk5xVjVxWmVJMFFiUlBP?=
 =?utf-8?B?VXQvTU1PU0NKWkFQYjlkRENRNXAzdUlqS202ZkRJcVRNUVlyeTd6SWcxVWo0?=
 =?utf-8?B?Zml0MGNSa09RRFRjcXdDU0pOaGdDdm4rcVd5bkhNWHdJRjFqWHdVWHdVMHhJ?=
 =?utf-8?B?TEJCK0U4Y2VYdmNWMVpRTmdadjNwSGNQUWRoV0VzSUYrbkVtZXVzSzFYR0Rs?=
 =?utf-8?B?VFBDOVdqOGFQazYvc1JtYy81cEpiQ3NuWHEwdEN1bXJpZTduWnRPMlVZSmhv?=
 =?utf-8?B?Yy91VXc0WVFPTHg4bHl6QjRPelVYZ0ZwSlZLSklVRnFOYmpkcXhqSUZTd0tU?=
 =?utf-8?B?VktSL2w3ZnNEUDQyVGJ2YUVlcWE2NTBnUHEyUUlxUHFEWnBZR0xvNFN1Rjho?=
 =?utf-8?B?bXA1R1lRMHRsMHRpSkhMNEx5U3paYm5XOERMNS9rcWJxYytnWEZ4SjdNWWFt?=
 =?utf-8?B?TEJBUEVKazllRGxVdG14dzlpNlNieXFCMEVkNWQwN1dLRUVEZlJpMlBTejBl?=
 =?utf-8?B?dDZvS1RsN1lwTG9wcjQxaFJXdXVxU0V4MjU1V0NwbmF2U2xQNnFJYldtS2Za?=
 =?utf-8?B?NGREUTB5RU1XTHZoRDhDbUp5NlhhZWdTd3hYazRZNjRtZGZyYkx6cERpSTBj?=
 =?utf-8?B?RmVGenRIY0M1OVUrdFduaTEyTVhtOWNMTlhCWFQxcDkydkxjS2ZNU2g0N1RW?=
 =?utf-8?B?NUYrcWEwZWdzeXB2bFk2aTU0d0Roa044U1JETUg3VmJ3UGMwZ21lWVVpQi82?=
 =?utf-8?B?dzVJK3ZhL1JWRmt6SUdZS0lqaGhOdWxkV3dwUWE0aXpkeENCNHNraTdWWHBj?=
 =?utf-8?B?cVlLRy9HK0hiT2w3a2ZaM1gvOFl2bFV2azFFWUFJUGVjTkoySy9sQWFCdmtO?=
 =?utf-8?B?Y3JpVVNOamlzMUdGQWIzZmU1cUlJcXlQNlVwOW1wOWxwSFJrQUtoYU9CNldX?=
 =?utf-8?B?cGYySDhuazVrM1FWT01MOHdtUkFsYTNMZTZ6SW1raEpWaWhwM3dTR0tWMGlw?=
 =?utf-8?B?M1czeXhDdVZYRFN0blRCMTVSUEZteVdWK2xHejdkVHgzRjUzV2s3eVZWRXVD?=
 =?utf-8?B?bHU0NFJVQTlMSTNPOGxwei9YOUpCTVJjS0dTcFBaVXowRGEvL1BPdUQ4STZa?=
 =?utf-8?B?bkJ3bjhzNStaTFJYWTVJNGhTZi9QR0JwM3NUNjl1Tk43K0hGOGVFYzU4Z2pB?=
 =?utf-8?B?VUFwODMreG91clhxbFJiUjlPd1B4QXcvWlVFdUNGSjAyejdpOUdpbDlETDRN?=
 =?utf-8?B?aUlJNnVML0RRcWlVSDlXMUtoVFMwN3FEdHpWblRJRUxydkxENzBPOVNjTXZB?=
 =?utf-8?B?RDFVN1owUlF6MEQ5NkxsOWh4clVZbjNTRG52YWRwdU5QdU9tc3NlVDM0dVhB?=
 =?utf-8?B?RG01MzBnSFNHN0tWa3Y2MDMwclVwb0toRzRPdFFhRVFrMUs1QXhDLzU2cUZy?=
 =?utf-8?B?cUNVTHl4RkZTaFpmbm1Pb2d4enRYaGF3ZG5SVkJnUWRDUVBJNGpMNWdyNWZE?=
 =?utf-8?B?VzdoMjJ5RXBsc3dpSkc2UDJ5cjg0amlRZWJoMmgyMmRRaWFqWDBJU2NnQkRm?=
 =?utf-8?B?ajYzNTlDQytLMzJ5d0hQcHR1YndmNHNYQWhjSSs2N0l6V0gwaVRocFFld0JK?=
 =?utf-8?B?RFMxYUwxVG9Pb2lvRUVsOHVmaXZITFgxUVdOdXhpV0h2cE1tdGtRandGV0wy?=
 =?utf-8?B?cXJoZkFlRGlXZkZ0aTYzK0FPSkM0NDQ2NGFLT3pTckp6d2Y1aEVJSkRmUTFO?=
 =?utf-8?B?ekVzTW1YVjFIbm8wd1BhZzgwUjVFQ0ZYRzNpVDg4SG9qcDJhS0hseEpLTk5F?=
 =?utf-8?B?blRPaTZsVXdlUzJHVStNL3NFcERWSFRSdUtBYkZVOVkyNkhrSkFkR3V0TDd1?=
 =?utf-8?B?MnFhUDhCVUg2azlQYlZFTjVHMXVTR0FVUmxJZENLS2U0U1lxUlJWa3pwYnhZ?=
 =?utf-8?B?OUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6af0044f-9705-423f-a741-08dbc9878926
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 11:53:36.8312
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fT7MAvCU80s5zK0DgNH35CZ1Byo+viMJwDEzBJtltZDQrCi/e//L6DSQROgT+aUFhZVIDn4REP+SHXciGZGdyqxO/VIvsgw+C21YbZOndTI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5618
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 10 Oct 2023 04:53:52 -0700 (PDT)

On 2023-10-10 1:43 PM, Cezary Rojewski wrote:
> On 2023-10-04 4:55 PM, Maarten Lankhorst wrote:

...

>> @@ -465,10 +461,19 @@ static int avs_pci_probe(struct pci_dev *pci, 
>> const struct pci_device_id *id)
>>       pci_set_drvdata(pci, bus);
>>       device_disable_async_suspend(dev);
>> +    ret = snd_hdac_i915_init(bus, false);
>> +    if (ret == -EPROBE_DEFER)
>> +        goto err_i915_init;
>> +    else if (ret < 0)
> 
> The 'else' part seems redundant. s/else if/else/.

Spelling error on my part. What I meant is s/else if/if/.

>> +        dev_info(bus->dev, "i915 init unsuccessful: %d\n", ret);
>> +