Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <d4f3e1fb-e419-4bdf-8fa9-47e60f596a85@amlogic.com>
Date:   Tue, 10 Oct 2023 19:55:45 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mmc: meson-gx: Remove setting of CMD_CFG_ERROR
To:     Jerome Brunet <jbrunet@baylibre.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc:     linux-mmc <linux-mmc@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-amlogic <linux-amlogic@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <20230927072544.764285-1-Rong.Chen@amlogic.com>
 <202309271651027503622@amlogic.com>
 <1jil7wkl39.fsf@starbuckisacylon.baylibre.com>
From:   Rong Chen <Rong.Chen@amlogic.com>
In-Reply-To: <1jil7wkl39.fsf@starbuckisacylon.baylibre.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDZXeHoya2tkd1JVeitPWGZrZTNZR3NKVmdOUjBDbDcyY2pQU1B6VWV4U1Jp?=
 =?utf-8?B?SVJOOWpIb1B0VTNlZkgyNWowbEtuNDM0NFM3M0lUOXNpZ1FqWkVYTnRyQWVk?=
 =?utf-8?B?MkxRQ3pGSThhcVdVSEdQQ25kWXZYenVEM0hEVGVzN1hlVnZjeVIvbm40Q0hp?=
 =?utf-8?B?MHdpZ2wyQTNPUGtPRzdmeVYwLzVja1FUaFdPemVZQlFpT2hFdnhBUnJ4YXJK?=
 =?utf-8?B?RjM0a2VwREZSdk5veE94ZllDdy9FVFRwblJmVHkxRXZac09ZZFkvdktxQ01R?=
 =?utf-8?B?LzBMRFNXM0ZkNUd1Vm1aQVR3ZHRSQmtpMktMVTRlNGMxWDhJWEtPN212Wi9u?=
 =?utf-8?B?ZFQ0b0JTZ2dXTFo0ZGE1Ky9ZZUZvWDhYaldGOEROS1Z6WFphdGN5NGkyay9I?=
 =?utf-8?B?dnpUOUdHaThPam1RNlI1cTJHczMzeVo5Y3dzWVEvakhsekFROTJnT3Eyckc0?=
 =?utf-8?B?eUxzc2NXQ083K0Fsd2JxRTJtQkpqUUZJWDJIMjFxWWtvaDJQV3U4Wjh3Ymd6?=
 =?utf-8?B?ZjFqWC9KUUFPeHZwcXVkQ0JSSEE0b0d5dVUwUTlQcGJXTG1KZWtMSTBMR3ha?=
 =?utf-8?B?QVhMVGlaWWpiWGIzanE0MS9pQWxNL0I4ekx0ZWIzRjhNK2tYeWZUN0ZjRk43?=
 =?utf-8?B?SmpvYjJIVzV5NTEra2JwV1Vvb3l5NUFqeDZ5MEFhSVBkMXg0RVYxc2dvaWh2?=
 =?utf-8?B?VURPWnlWeWJHTTBKRS8rdzYyRXlIM0ZyMUpHMUdxYVdPSmhZKy9ORjdzMndJ?=
 =?utf-8?B?RU9MUG9aUW5FYWNOc0p6ZzJ0UDYyUzVteVQ5dzR1ZGpUbUt3VXJ1SkxVekg2?=
 =?utf-8?B?SXNjUTVKczZObXhMcGxvV3FGamEzMzlZR0tJSEl6ZXFva1h4bGhDNTgxL0hz?=
 =?utf-8?B?ZTcrQ3Ivd0djbXJ6UFZycXMzVjB2QUsySklqejU4NUE2dmhvY1paM1JHMWlB?=
 =?utf-8?B?ejdpTVFSaW83dDBzNGttdG0yUjBzclFyb3dOcFJnR3hwNE15SmFKQUIzVG5u?=
 =?utf-8?B?WHZOaThoRWtUdzFSSmtwSmxpTTZTako5Z0V1b0orSldDcjdYQzZEcVRqTUNN?=
 =?utf-8?B?TWNvK1FLNUhFZkVDaFNqWUxaci9oQmdsT2dMNTc5cnFJbnVIVUpTbGFWUkdH?=
 =?utf-8?B?M2xmTGFsYjVTRXdsMmFDaldMbGpYNUJXcngxNU90cFBWSThWUVovY2xZWW8z?=
 =?utf-8?B?ZHVpV0dZWUx0YmxaV1F3NmI0aXFyQkFsRE9FQTVEdklMTHRpcGZ1bkhjdjMz?=
 =?utf-8?B?T3VFU1lrQUt4dFd4ZnRzRzJOdkZ0dllHREVacWc5d1dFNlZXNGM0ckgxZ28x?=
 =?utf-8?B?djlnSmFjTDQxTnNoWmNLcWI1VmIvejZZZmwvWEhiNVhmV3BUaVN3bzZzamVS?=
 =?utf-8?B?QlFRUUdMRU0xOWNTMFRYdEV3cnJvU2E3eDlRaThwTVRxNDlwTzJGYmdmcEx6?=
 =?utf-8?B?Y0tMVER5UDVyazV6V3I5TS9XV0tSOThNZlV4c1Z5WmI2STJmUGprSElZVENJ?=
 =?utf-8?B?TXNkM3FkcTlNNHM2OTJtKy9xNjQ5ZExHazhqNDdheGx3RUVNMENCUkUwOW1Z?=
 =?utf-8?B?MXVaa3FZWnhjWTN2bzFnbllYblNrYlBtb0ZaMEttTUtaeGYrYVZodFNtNlZC?=
 =?utf-8?B?RWlaTW9wSFgzSGhYeFZYdWlCMjlyVlBCSFpndGh4R2Y5Y0R3cTRRaFBKUU5u?=
 =?utf-8?B?SkZMNEh4WnFIc1NHYVJZc2lzOTBRdjJmczRyRzRQWG1JMEZJa29HYyt2cWh1?=
 =?utf-8?B?WGhKcWNOTnd3SjlDMk5YMHNpVnViNlBBS1N0c2NXS25mcDBWVUpWQ0JwcGxp?=
 =?utf-8?B?emVCQ1JjZmZHR1F6aFBJUnFFSVRLeWQwbWEzMjdSbUVuU2d6WnFOMHBJeDE1?=
 =?utf-8?B?bUJHUTBYWmlicE0waGNkcHh3bnlCOFFzL1dPcVZEY1M2WnV2YTYzUWxIdUF2?=
 =?utf-8?B?bnN0L2pSc2J3YTc1dDBHcmFZTkhGWlc4SVpxbVdCQnBrbWQ0ZVllTmp3anRu?=
 =?utf-8?B?VmRTVXlUNTdrNEJjd0hxMkNUMnZOZ1NlZmloblM4TkpEYUFVMXErLzJqNm8z?=
 =?utf-8?B?UGIrSmlrdjY0U0lON1hzSGMvdVg2SXNNUHFBRVg1aFQxaXI4NytJUVV3emVk?=
 =?utf-8?Q?JxyKXaQi7xv90qVFRscoyPMj9?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d6aa105-fa08-4a39-4adc-08dbc987e2b0
X-MS-Exchange-CrossTenant-AuthSource: SI2PR03MB5943.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 11:56:07.0854
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sT14UKKGj/QBii5+vzwSDyCt4DSTOdLOoTXCQSl3W+aqXJ8bqAC7rDMT3ixarEy41dOFCsoZ+GIMbjMO4yKB+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR03MB6965
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 10 Oct 2023 04:57:10 -0700 (PDT)
X-Spam-Level: **

Hi Jerome,

For the t7 and older SoC families, the CMD_CFG_ERROR has no effect.
Starting from SoC family C3, setting this bit without SG LINK data address 
will cause the controller to generate an IRQ and stop working.

在 2023/9/27 17:30, Jerome Brunet 写道:
> [ EXTERNAL EMAIL ]
>
> On Wed 27 Sep 2023 at 16:51, "Rong.Chen@amlogic.com" <Rong.Chen@amlogic.com> wrote:
>
>> Hi Jerome,
>>
>> Socs containing previous controllers are gxl, gxm, gxbb，g12b，g12a，sm1，axg, a1，s4 and t7.
> That is mostly all the SoC we know of in mainline ... This why the way
> you explained is confusing.
>
> And below, you say 'on latest controllers', okay but which ones ?
>
>> The bit CMD_CFG_ERROR is used for selecting SG LINK of data address on latest controllers，but
>> data address don't use SG LINK at present，so it will cause an IRQ and stop working on latest controllers.
>> Therefore, remove this setting.
> Not totally sure what SG LINK but okay.
>
> While the change itself is fine you really need reformulate the description.
> Based on your explanation, something like:
> ---
> For the t7 and older SoC families, the CMD_CFG_ERROR has no effect.
> Starting from SoC family XYZ, it will select SG LINK on error but this
> is causing a problem with the data address ... blablabla
> ---
>
> Please expand a bit on this, try to make it clearer.
> Also, please insert the proper fixes tag
>
> Last, make sure tp reply with plain text emails, otherwise lists will
> drop your reply and please do not top post.
>
> Thx
>
>> Thanks.
>> -------------------------------------------------------------------------------------------------------------------------
>> Rong.Chen@amlogic.com
>>
>>
>>   From: Jerome Brunet
>>   Date: 2023-09-27 15:43
>>   To: Rong.Chen; Ulf Hansson; Neil Armstrong; Kevin Hilman; Martin Blumenstingl
>>   CC: linux-mmc; linux-arm-kernel; linux-amlogic; linux-kernel
>>   Subject: Re: [PATCH] mmc: meson-gx: Remove setting of CMD_CFG_ERROR
>>   [You don't often get email from jbrunet@baylibre.com. Learn why this is important at
>>   https://aka.ms/LearnAboutSenderIdentification ]
>>
>>   [ EXTERNAL EMAIL ]
>>
>>   s
>>   On Wed 27 Sep 2023 at 15:25, "Rong.Chen" <Rong.Chen@amlogic.com> wrote:
>>
>>   > From: Rong Chen <rong.chen@amlogic.com>
>>   >
>>   > Setting bit CMD_CFG_ERROR has non effects on previous controllers.
>>
>>   Which previous controllers ? v2, v3 ? Can you list the SoCs please ?
>>
>>   > However, it will cause an IRQ and stop working on latest controllers,
>>
>>   Isn't it desirable to stop on error ? seems like a sane thing to do.
>>
>>   > This bit is used for selecting SG LINK of data address.
>>   > Don't set the bit CMD_CFG_ERROR anymore to resolve this issuse.
>>
>>   I'm not sure I understand the actual issue being resolved.
>>   Could you provide more details please ?
>>
>>   >
>>   > Therefore, remove this setting.
>>   >
>>   > Signed-off-by: Rong Chen <rong.chen@amlogic.com>
>>   > ---
>>   >  drivers/mmc/host/meson-gx-mmc.c | 1 -
>>   >  1 file changed, 1 deletion(-)
>>   >
>>   > diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
>>   > index 9837dab096e6..c7c067b9415a 100644
>>   > --- a/drivers/mmc/host/meson-gx-mmc.c
>>   > +++ b/drivers/mmc/host/meson-gx-mmc.c
>>   > @@ -801,7 +801,6 @@ static void meson_mmc_start_cmd(struct mmc_host *mmc, struct mmc_command *cmd)
>>   >
>>   >       cmd_cfg |= FIELD_PREP(CMD_CFG_CMD_INDEX_MASK, cmd->opcode);
>>   >       cmd_cfg |= CMD_CFG_OWNER;  /* owned by CPU */
>>   > -     cmd_cfg |= CMD_CFG_ERROR; /* stop in case of error */
>>   >
>>   >       meson_mmc_set_response_bits(cmd, &cmd_cfg);