Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp81641rdg; Tue, 10 Oct 2023 05:04:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFKgHhOYBBYBPTABLz6BrlfZozmHHK98yfu4Mmc4GR6Y30XhZOFhIHhhskWoaan1WKNqLNz X-Received: by 2002:a17:90a:8c5:b0:269:7eea:d7f6 with SMTP id 5-20020a17090a08c500b002697eead7f6mr13148953pjn.49.1696939493376; Tue, 10 Oct 2023 05:04:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696939493; cv=none; d=google.com; s=arc-20160816; b=Gar0nlqyzWXEU4jOSPf4Om3UlDEWJipDOCkp0EnP/+oySXUKrjTEBUVSadc6h+o+gv CgdQpQ4NQZUtOqbRLYsxIa+q8mvRM8RrPJMbiKSH0He6TUAJnC86yRpglFFKXIMYTL7L EobHeFX6ZblYolQz7pRjktgrlHhBz1QyKKwZRZsfrjaIGUiG3BG24KWDDUsC1YB6h4J3 5KH7pCHLbp1PTlSvApbOrtRvjRivjEvGNs2TU4DvS5Sjtpk0OR8fwzu9Cx4NEWz5u7/+ dmTu1SLxFIgLBcjlOIvU67WdKV2HjgqgI2ED/yozJ2en2FvaqIDCexn/7Ihwt33ATiQc wdSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=oRm5xwGlZJf/KJnLdBDBwdoT05gZC5H+vASV2Jvu/KQ=; fh=RfNQaKGaoe3J5KEtWA8ioicOImMjrB099V34Skivxq0=; b=U0rsXYKR9JtadrLEeRl2W4zAEkdtdNgvGG6AScWiuXgAoIwQgSvdJ2TBXmFDxZkeaZ Xe3Ykw6M01XNI/IlkfUPXvne9KF7sZKa/l0J5CMbH16zytq4MHOFVEYpq8JYKnszIOCD uSuEqnFwr38I0Zia0PRHZF4VcoX5kbD7Gc4dDFwyNSaFuWg3JtpglvTDITfoD0lYNsaS a3ablZ8Opxvp4bLtMGSi+OSrdWKtjupIv1OeU9vTcm9Ul/8grSW8CZi5w6sIHqSeRu6I zZD5igj9A7xLA1NqRbrRUGdVg3pjSTCqncZ6PYBuCVTPlNpSJkbzVNbuaUae+jXFCjK9 nJFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TyNTCWuo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id bv8-20020a17090af18800b0027740192bc9si339196pjb.152.2023.10.10.05.04.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 05:04:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TyNTCWuo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 7E0D781603BF; Tue, 10 Oct 2023 05:04:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231348AbjJJMEk (ORCPT + 99 others); Tue, 10 Oct 2023 08:04:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231607AbjJJMEh (ORCPT ); Tue, 10 Oct 2023 08:04:37 -0400 Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F23B5FA for ; Tue, 10 Oct 2023 05:04:32 -0700 (PDT) Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-5a7bbcc099fso9599277b3.3 for ; Tue, 10 Oct 2023 05:04:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696939472; x=1697544272; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oRm5xwGlZJf/KJnLdBDBwdoT05gZC5H+vASV2Jvu/KQ=; b=TyNTCWuo266bHgiNm+q+Hok6E3nyqyNcwNpxUwClJIBu6FUZQJ9r3f4Xk8y/hqkwGf qRSjkMVrO0VR+p6idEIXDjV6LhE9LfIUZUlRZTcw4EcFUHP3s0w7ZUV7kwl0j0wbHsKa 80I8lDp1kZBikaZfdIFLlBZB6XQVIZumNEaeM3EiPccynX3UR7MKnnGQor4R/XNt4uIy 9otCZXVPvCJV+VSTmOBD/Srq1H35UEBTWXRCw+VjxQmNBH25AsaZqKCF3I0Elpx4f2Ss YxaoSuejDQnQPibdgMoF2GXw7kT6pjYq2YG4WWNTolSN2Qzx7u1VtZmZ0DsKOoWBold9 uQLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696939472; x=1697544272; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oRm5xwGlZJf/KJnLdBDBwdoT05gZC5H+vASV2Jvu/KQ=; b=JOFUb8S8MSY5SBp7PcHG6R2b6/Zl/SruVRXyp9rJgMz0VM0cH7B/qwRkZIDHfuCURr g9Sda4njEQK67x07rAMlASsev8ha31FfkoX21HcWLW+JeRD8oGaKNrdlHZ+30bB5V7z4 w9iP9tXu/YiqnjeEtb03h97JhETkaYSdwxUG+x4UxkIlxoIuG5rkw8QFzx1lMPO6kUcL 0H5RQsl9kQxGgAtSB62K4qLHqwWH8SqkZmajEnZTnURc4GTkKDgllp5J1Y6Qp+pXBcXz 4hFymSMkzYTEyq5TnQPbmIC2UabzGUx/WL2o0h3gLRDD3AMfAVYjkr1WRFCxAYzC2Pnl J9mg== X-Gm-Message-State: AOJu0YztFEqTkS2DYFiyqXpmq2M6KQw46wD8FiKhgzQHrgJvyvFpUeoV GjzXVb63RCAjhVtQX+htMO2utpRJ4BVp4W1kNVQzKA== X-Received: by 2002:a25:a101:0:b0:d4e:4103:7807 with SMTP id z1-20020a25a101000000b00d4e41037807mr16143064ybh.60.1696939471954; Tue, 10 Oct 2023 05:04:31 -0700 (PDT) MIME-Version: 1.0 References: <20231004183906.97845-1-brgl@bgdev.pl> In-Reply-To: <20231004183906.97845-1-brgl@bgdev.pl> From: Linus Walleij Date: Tue, 10 Oct 2023 14:04:21 +0200 Message-ID: Subject: Re: [PATCH] spi: bcm2835: add a sentinel at the end of the lookup array To: Bartosz Golaszewski Cc: Mark Brown , Florian Fainelli , Andy Shevchenko , Ray Jui , Scott Branden , Broadcom internal kernel review list , linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski , Hans de Goede Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 10 Oct 2023 05:04:49 -0700 (PDT) X-Spam-Level: ** On Wed, Oct 4, 2023 at 8:39=E2=80=AFPM Bartosz Golaszewski = wrote: > From: Bartosz Golaszewski > > GPIOLIB expects the array of lookup entries to be terminated with an > empty member. We need to increase the size of the variable length array > in the lookup table by 1. > > Fixes: 21f252cd29f0 ("spi: bcm2835: reduce the abuse of the GPIO API") > Reported-by: Hans de Goede > Closes: https://lore.kernel.org/lkml/29764d46-8d3d-9794-bbde-d7928a91cbb5= @redhat.com/ > Signed-off-by: Bartosz Golaszewski OK my bad (I think?) Reviewed-by: Linus Walleij Yours, Linus Walleij