Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20231003075512.2081141-1-milkfafa@gmail.com> <1e5bb09f-be36-4fc6-88f3-8f6565b6147f@xs4all.nl>
In-Reply-To: <1e5bb09f-be36-4fc6-88f3-8f6565b6147f@xs4all.nl>
From:   Kun-Fa Lin <milkfafa@gmail.com>
Date:   Tue, 10 Oct 2023 20:30:47 +0800
Message-ID: <CADnNmFqqOOo75hmt6FKGFjC2XcQD53SuX3gHEqnifWcCas-m-g@mail.gmail.com>
Subject: Re: [PATCH] media: nuvoton: npcm-video: Fix sleeping in atomic context
To:     Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc:     mchehab@kernel.org, dan.carpenter@linaro.org,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        openbmc@lists.ozlabs.org, avifishman70@gmail.com,
        tmaimon77@gmail.com, kwliu@nuvoton.com, kflin@nuvoton.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Hans,

Thanks for the review.

> > -     list = kzalloc(sizeof(*list), GFP_KERNEL);
> > +     list = kzalloc(sizeof(*list), GFP_ATOMIC);
> >       if (!list)
> >               return NULL;
> >
>
> I'm not really sure this is the right approach.
>
> Looking closer at the code I notice that npcm_video_irq is a threaded
> interrupt handler, so wouldn't it be easier to change the video->lock
> spinlock to a mutex?
>

Agree it's better to use mutex. Will send v2 for this.

Regards,
Marvin