Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <9a6ccef5-3a35-ae0d-2a9c-1703c5038c81@linux.alibaba.com>
Date:   Tue, 10 Oct 2023 21:06:07 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.0
Subject: Re: [PATCH] erofs: fix inode metadata space layout description in
 documentation
To:     Tiwei Bie <tiwei.btw@antgroup.com>, linux-erofs@lists.ozlabs.org,
        xiang@kernel.org
Cc:     Jonathan Corbet <corbet@lwn.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        ayushranjan@google.com, Yue Hu <huyue2@coolpad.com>
References: <20231010113915.436591-1-tiwei.btw@antgroup.com>
From:   Gao Xiang <hsiangkao@linux.alibaba.com>
In-Reply-To: <20231010113915.436591-1-tiwei.btw@antgroup.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Tiwei,

On 2023/10/10 19:39, Tiwei Bie via Linux-erofs wrote:
> Xattrs, extents, data inline are _placed after_, not _followed by_ the
> corresponding inode. This patch fixes it

Thanks for the patch and sorry about my terrible English...

> 
> Fixes: fdb0536469cb ("staging: erofs: add document")

I'm not sure if it's necessary to tag document fixes anyway
since docs.kernel.org already uses the latest version and
`.rst` format is adapted much later..

I will drop this tag for the next merge window if not urgent.

> Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com>

Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Thanks,
Gao Xiang

> ---
>   Documentation/filesystems/erofs.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/filesystems/erofs.rst b/Documentation/filesystems/erofs.rst
> index f200d7874495..57c6ae23b3fc 100644
> --- a/Documentation/filesystems/erofs.rst
> +++ b/Documentation/filesystems/erofs.rst
> @@ -199,7 +199,7 @@ may not. All metadatas can be now observed in two different spaces (views):
>                                           |                  |
>                                           |__________________| 64 bytes
>   
> -    Xattrs, extents, data inline are followed by the corresponding inode with
> +    Xattrs, extents, data inline are placed after the corresponding inode with
>       proper alignment, and they could be optional for different data mappings.
>       _currently_ total 5 data layouts are supported:
>