Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp142776rdg; Tue, 10 Oct 2023 06:36:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHADs6iDVLgvORZ+RCMW+FzWfOWjHKMxAg1ehYC1/p5n6g0WE4Fy2Bn68axLl+TegFkIYEX X-Received: by 2002:a05:6a20:7487:b0:14e:43b0:5f99 with SMTP id p7-20020a056a20748700b0014e43b05f99mr17655905pzd.52.1696945008435; Tue, 10 Oct 2023 06:36:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696945008; cv=none; d=google.com; s=arc-20160816; b=XSk+DXtGwAx8XHaFnstjpldzdvBiiNVEjfy7vlcV1gWecd4eXH+2KrCy/W4gc7oUUp d2YZbpvGaGhTVOjnvz9UAf77tv5uojAHgxu5oWGsIcpR4MYZjnmylbpW5bIjgAqiBezT 1wxly5AtG6VOtCgOlOaPoJAbg6yD9nHthM3/GAULF6Wj1YilWyNCCF5jFAxs6WrzAgGa E8vEAo18bzVr6CU5tc2+N5flS3vU+JV9zq+6zLuaj0FjdR7Od6VPwy/uEVf9OsWv8PQu ddB4rEO/fstN46ZRBzjdUOVMiIzMpiWv/bkGf+pJN4xavHewjJh/lK97ypjC/CKx9Z1Y LPDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=6wXiqvYDT0weE8ui/Sbgni0MhTf5BD51PKqeFfPGPxw=; fh=Hwp4KLY9DkEJ1SlzqXXv3K/RTOqKE+x3Llh+5sKkJeA=; b=ERN8tTRBoFLZkANVlrkgV6GPEGChF3NVS3jK3SZTvb4l40zUlMInWGhod1i/L6NZf1 NOV/1fbj9D0LQ0xVvQZw1nDDPrfOTH4A7S0c0v13zdY3cXjOg6Yf6prnTWa/RHI85FUl 3OGuHikrjitlVS0DmZUxStCn0WXcuFaju/0Uww1cFlh6Jp7FNDheLulciFd1A+3mySF1 Py2kiZc8KuZazuK09wTDjp+Qfs+In0puyVLeiYP/Gtd92kaFUdpQy5hmT2p5AFi2pnsh glZe44nME6ZkIJTCTHTNXIFVY8YoLYUZ0bBk5FrsZbLynqCDDKFEyd2BPtRaRU961eNj IggA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n6W295mv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id bv3-20020a632e03000000b0057745d87b50si9300016pgb.139.2023.10.10.06.36.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 06:36:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n6W295mv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id EC65B80A9DCF; Tue, 10 Oct 2023 06:36:44 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232169AbjJJNgi (ORCPT + 99 others); Tue, 10 Oct 2023 09:36:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232255AbjJJNgg (ORCPT ); Tue, 10 Oct 2023 09:36:36 -0400 Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A36F1B0 for ; Tue, 10 Oct 2023 06:36:34 -0700 (PDT) Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-59f6e6b206fso70773617b3.3 for ; Tue, 10 Oct 2023 06:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696944994; x=1697549794; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6wXiqvYDT0weE8ui/Sbgni0MhTf5BD51PKqeFfPGPxw=; b=n6W295mv4kAxT9n/ho2+UbufdEmNyndozwP6FgRjEa8aH0Mjk/ceZTEENT/j9bmCUJ E8bJPfBqw3kNOvwfw2CyxoQleamYkajrCK4DTw48dYp2mxLdwokgvjmcjLmubwaCFiRk nYMwFSdP0xkXnHVvzj+1585P7bkPbcw7kBbupIA7HmUa99FWZF8VQIrOcWJZtFdGFiH5 R7DGskUmFA9ERrkGf6HbrtAz5Z/oMTct98b8HA1v19P26AjCaIsrf/QMsAeQVy6nMPkj sL1J+dzSYsTybPwMzx+HKmvklAxDkoogQ2LwnkJ4P4WhdKCf8R5BbiF2guApA1upY+jr S4MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696944994; x=1697549794; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6wXiqvYDT0weE8ui/Sbgni0MhTf5BD51PKqeFfPGPxw=; b=rV2DtBnuVrsOAISmjWhGsrdLaJ1XRqt4qAFAW0J3/GM1QkdkqUTveJjfXFgucejCV0 e3oMkEo2Y64a+c75PAZM0FQ5iIERdPCdYc7tli1Bb6ncRTPklVaKfTkzTDgbxmmwQMKD ES7sk0ur/NTZg7AsCsEftUBsU++IsHTrNHXH30DWo7mDAsBi2V3w+83OnadgnYttF6yh JLRK92voP8YJxtNQ8KCYymHYjNWjKZGqn8fwktLjTDuxjxfedPnci7sgFxBqd6/PQe+f 9/QpMSy0g2K0WnpdeS98OITG8tJNMXaw8iFoliTz1djZKd00GLDv0o5TfsgWo6pjIkCK 4+8A== X-Gm-Message-State: AOJu0YwlDdxieaO9PJ/AapuI7G2qc2Shd6b27IEBdYn8Kq15o0FVRxfa VqvrX5tubPSp8X3u00AOdMq8+3LAeFYVjgBbbeGvfg== X-Received: by 2002:a0d:cc90:0:b0:5a7:d016:bffa with SMTP id o138-20020a0dcc90000000b005a7d016bffamr634809ywd.8.1696944993840; Tue, 10 Oct 2023 06:36:33 -0700 (PDT) MIME-Version: 1.0 References: <20231009083856.222030-1-u.kleine-koenig@pengutronix.de> <20231009083856.222030-3-u.kleine-koenig@pengutronix.de> In-Reply-To: <20231009083856.222030-3-u.kleine-koenig@pengutronix.de> From: Linus Walleij Date: Tue, 10 Oct 2023 15:36:23 +0200 Message-ID: Subject: Re: [PATCH 02/20] pinctrl: single: Drop if block with always false condition To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Tony Lindgren , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 10 Oct 2023 06:36:45 -0700 (PDT) X-Spam-Level: ** On Mon, Oct 9, 2023 at 11:22=E2=80=AFAM Uwe Kleine-K=C3=B6nig wrote: > pcs_remove() is only called after pcs_probe() completed successfully. In > this case platform_set_drvdata() was called with a non-NULL argument and > so platform_get_drvdata() won't return NULL. > > Simplify by removing the if block with the always false condition. > > Signed-off-by: Uwe Kleine-K=C3=B6nig Patch applied. Yours, Linus Walleij