Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp143729rdg; Tue, 10 Oct 2023 06:38:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG/7nsy48TFKb3DtLWIt6jgvaXVozrL47HKm87geW1PoJc8Q+t4+etVReELnornVzRaZUv4 X-Received: by 2002:aa7:8889:0:b0:691:1eb:7dda with SMTP id z9-20020aa78889000000b0069101eb7ddamr18173052pfe.7.1696945095896; Tue, 10 Oct 2023 06:38:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696945095; cv=none; d=google.com; s=arc-20160816; b=b2YLyIiTKVgQ6OJqGgXTXW0VB24t9+b5ighzzwCUGC+B+0CZJrJRm94GM+tRFZZSwI ialjLIZR6TGCQ6/gVEOJiGBBiVC43o9iWkMnK1KxpRvekFvoMZFXazjYWI7ZkSelxDwl kmQ+7GvSG1haYBG+hnbIyMn0Q0t1MMTz1iKl1VziyW1Mj8T5RPOquWwkKrsRDzyI9uk9 TiYBx6rhjc+BNmUYQE9Nm5CFN4922RZ2FhxsqUJIk9T4k5ebrsPz87oMCa4LEXCZ2RXW bUtLxKWyefdotp02EPnNKkSoDRgf8OqCkKOFRyOGgfRoLDM4kglz/E6dND8EvLV6ciOa /8gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=2BcYWTkK3Zq4RaJ6QSiIWDLjJKh5RkW4qWVPOlMXZYQ=; fh=yVn5jxXv1Q32aMyjqbzpHPVp0K4dGAztm1TPIBcD7AA=; b=UGZvkW7Mb9hEtfAQrk+r4HTim5oRJaZr07CeLyBpvH/ITyBHvN++gkzHHJvEMxBA7n WYuceYW0S/So8YCJPvdkiMS+75XA/Zm2tdk4FOH57AVXXG6bp9YM2JJmocJ2K4mfqtJo ywZE2P0mUWiCd44dMMqLhD4qqdo+Nk2yke7dY/mbt5LI+ouQHc13rtaU4Im/ILlZxaJW WvsslUE7naTWlEK6UIQOEfUpQXQtu493So1wktoqdXWAnUnzOFQYYzGusMVpcKdx6Muk h7g91xZMCY9pRRMqZqNBqyqMZOmb/bHfhr3iBTRld60RkGwaqHG/Ld6Wa071buTIR49V rRBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="FyN6/fI2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id o15-20020a656a4f000000b0056c297d1640si2847707pgu.528.2023.10.10.06.38.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 06:38:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="FyN6/fI2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 91B71803AC95; Tue, 10 Oct 2023 06:38:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232296AbjJJNhu (ORCPT + 99 others); Tue, 10 Oct 2023 09:37:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232311AbjJJNhs (ORCPT ); Tue, 10 Oct 2023 09:37:48 -0400 Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B0AFAC for ; Tue, 10 Oct 2023 06:37:47 -0700 (PDT) Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-5a7ad24b3aaso16719977b3.2 for ; Tue, 10 Oct 2023 06:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696945066; x=1697549866; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2BcYWTkK3Zq4RaJ6QSiIWDLjJKh5RkW4qWVPOlMXZYQ=; b=FyN6/fI2sWxqtiTy/l2QDF+qmUdUeSdbtPzkMPjBP402HQ0A9u4G0gKj3Wrd9hXKVr 9s3qzs4d9/At5k4xQBfOuZub0YqXkvkXtnRI3OQC5w7HeNBW+SyZSarEsqvmkiL9sgYN GNvTZn/z8qJj3bIVmMP3IwgnX+PrdmwvwzEztcHE0cDChYG3U9YAbdOzwjlhR6ufeJBU /MN7obYdzzWV9rLsxWGVAo+xhmOt36j0dY3vie6B/6o3+pSy7+OVsTjTwbAPxE6kw/k9 j0uG8QMZIZ6cUkJezhGTbdttlKPaZbjb+cihDv+COxJZmqKbVpNgDBv/7wDhnr2fSDWO BzoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696945066; x=1697549866; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2BcYWTkK3Zq4RaJ6QSiIWDLjJKh5RkW4qWVPOlMXZYQ=; b=vqhsWotOrwwp2FmyejS66h3L0jU9D/fSZmvKxQ7LoefF37kp+2mNLTntMTWvddLnlp JojrkpKzUMKhJofn247Ie38th1ShE1cf6DgcOYw5gb0c/CjnTFx364ODbo9Dk2q/wv4k Ei2CDE/hAzqFriWX7Po6xWCbhCn5UKDs82gjNlI6CKkAXkyKccQqjPfaC01GsUGPCxEh Vo7oQvy1RuSLA2HfYCTzZ9I5/H2EKHq/DilVRX9J3MjkkhwxHY8zp5iti/BxJM9sbEOv IWqgPObPfmzepeWMNiOr7YqIn14Vjq9/YUN1X8UjBpM/Zk+dra4xmfRebQCHU2tMGvAq 4s1A== X-Gm-Message-State: AOJu0YxHZxo+WsRpw39055s0lXBaH5DYReKUSwwaUc2n/b+FULny1Bnv LTSfdwML+VuaV/awV9vIC5U9eV37+EZGekQ4m/QsQxLxosN8idtc5Jk= X-Received: by 2002:a81:7c86:0:b0:59f:687c:fb36 with SMTP id x128-20020a817c86000000b0059f687cfb36mr18746618ywc.45.1696945066223; Tue, 10 Oct 2023 06:37:46 -0700 (PDT) MIME-Version: 1.0 References: <20231009083856.222030-1-u.kleine-koenig@pengutronix.de> <20231009083856.222030-5-u.kleine-koenig@pengutronix.de> In-Reply-To: <20231009083856.222030-5-u.kleine-koenig@pengutronix.de> From: Linus Walleij Date: Tue, 10 Oct 2023 15:37:35 +0200 Message-ID: Subject: Re: [PATCH 04/20] pinctrl: cirrus: madera-core: Convert to platform remove callback returning void To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Charles Keepax , Richard Fitzgerald , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 10 Oct 2023 06:38:13 -0700 (PDT) X-Spam-Level: ** On Mon, Oct 9, 2023 at 11:22=E2=80=AFAM Uwe Kleine-K=C3=B6nig wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-K=C3=B6nig Patch applied. Yours, Linus Walleij