Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Ma Ke <make_ruc2021@163.com>
CC:     "dlemoal@kernel.org" <dlemoal@kernel.org>,
        "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] ata: sata_mv: aspeed: fix value check in
 mv_platform_probe()
Thread-Topic: [PATCH v3] ata: sata_mv: aspeed: fix value check in
 mv_platform_probe()
Thread-Index: AQHZ+4JDiYrIXbxR9Uql7BwJKWL5mA==
Date:   Tue, 10 Oct 2023 14:01:27 +0000
Message-ID: <ZSVZNlQMFa7hjtNJ@x1-carbon>
References: <20231010122916.4080132-1-make_ruc2021@163.com>
In-Reply-To: <20231010122916.4080132-1-make_ruc2021@163.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7RZk+Ux/yy9a9sO77NZ68gpGGXDs5BrPJ9PpWsBPd/wMTr0yWgyUjQfMQiSj?=
 =?us-ascii?Q?BVXdgZo1M51ivAlq+IqmvJbnjjQNHGBJRQELuPxcAEXFQRF8KAYnQIvy3t41?=
 =?us-ascii?Q?zDT4jVoqmWhbMtsBi7sliFVCA9LH6yZMa0OLw2mxJt0wP32rH5x2iKsb9Dqo?=
 =?us-ascii?Q?5Nvaim+PEFNUAyOko8XyLB9KanbqaB49q3fmPam4iEHB/gJtR90Pex/NRJeO?=
 =?us-ascii?Q?gwH4AF3saeNwpPK3JMJVE7HfWoVUGcSwtbiPIYalZKOVlKmA929nOz3de0t8?=
 =?us-ascii?Q?+ou8YwDEUwATqfhqB1XMPtotqoKU0J9vMslFZxReJ8mCOGoewWKPSNrZe62u?=
 =?us-ascii?Q?DRCs47X/wLkR0xOZZrmCkZY+ZQHo8RJYJUwRXphIeUx2NVAFyvpm0NgHJhBY?=
 =?us-ascii?Q?EQksWbUrJ24PcxkLNm46IN1VeydJ2zZKlnr4PlR8aNEE9/jh0LpbpQppcamn?=
 =?us-ascii?Q?Iepo+/ZokfR5NHPzVjiGR+ka+JXhz6pW9TdaQsrhTWo2wxIoNToMUOlxLc/1?=
 =?us-ascii?Q?ZXHsoxhmEiqG29SKHQIU+NpLt9MBZH6Tns6h+pmxINO7UldYOrH6PgzZY2Dj?=
 =?us-ascii?Q?+vlzUnx0KsbZ2Vz8XoumPJKgmLrw4ydBn+7youWT0ECs0HsVGol5ONbbHkN4?=
 =?us-ascii?Q?MX5ngmE4LEBTm4n7bWRwg2V7o2wBZxeQNMR5RP15Ielw/VjHXpTlRQnelJ+m?=
 =?us-ascii?Q?7QAKJlzAMjlJOjy0uHDG1G4/V3OPXtY47TwuJcYdnKmLgW4VisdVCBWIj+/4?=
 =?us-ascii?Q?OIDk0coYl/cy7rqR9wPwS2HJ2zPoK43dYKsEaqGjlLTodDJE+LW5cz+D+JW1?=
 =?us-ascii?Q?Ipsnq8/tBWFXi0TOYbdTaLd+F7/eOZd9VYuDSUNNu7yNTHkScPicGbQwQqNd?=
 =?us-ascii?Q?rjBQJuzzolLdN0Y3Sg8iqbNuQN2UE0VMkNqQErHLOu0Tzs1DxYOUhRKTZhyi?=
 =?us-ascii?Q?O7nRIjpW1zWdwy3cBSrOJPyDVRlB2GEfPDqo4Voc/vha4UNif47QI1g6oWvU?=
 =?us-ascii?Q?k2Ync7yDLB7gRgEYHsFnBKSuI/izgJyokP54Xug6Fbx4hSGTSKcX1hLvBNSI?=
 =?us-ascii?Q?yYAjsJHBpzXJNykVDnAVDmebPhEfL5ZbU3XO4DJ9jDtVp+nGU0Lasc5I7mOA?=
 =?us-ascii?Q?82dg3B9v3s/UeP3f+CLRLoGNOLTTSeOYPMNwLzhpJCaUCxma3s66ZnFFfO6p?=
 =?us-ascii?Q?mhnUAGJw4B07vkJAXKCqW5/KWk2SWdmq3M9JCXvgPVoiV1zqq8SiNDxUGL/R?=
 =?us-ascii?Q?dI06fyJWn9oPMyo3PFBW/Wti9JsQI89qNfLqaNikzENcW2T1wJ23Al6x7zFR?=
 =?us-ascii?Q?tOUHVyYH8u8rN2ZcifPjtc/42K01oFUXjIAl4X/bzOC0oiBCIUSSW4kkAhHs?=
 =?us-ascii?Q?npFmMlr9URUPRth+BuCKDJ0mFimh//OmozsdfL+0+cAQ8dI/Jx8MnEFhXIGv?=
 =?us-ascii?Q?LFGCd8oR5YMuCRL+B6ycbx5+E65oRHGBomujouPpjoGuovMlIcw2TMzYsFaz?=
 =?us-ascii?Q?dDkCsKhpiM/JX+jYiOHdh8sgIm3czlu4Qu6miFiwFLyqQGd1rZnhwh26g6iQ?=
 =?us-ascii?Q?55+z2hmtc6JQQXk+jIstTLQA2tHrzwa0DFQnOxlANEbXBfgJo7/ik3YTpsBY?=
 =?us-ascii?Q?QQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F66A34522DC8094AAF83835BED4EB223@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: yxYA6hXmEhgLpw3w5qIEffhEA5Eg00kZVb8yGxdjG+BxFJRYsbeELsY0BHFY0NpZANwM5sqf5LF+MXLxrf8/WnmkAQ4cmXlkLIRGR75WcB6R3Q6ZbT1C6V/kesVZajbOL3poivaiET9WhL81aIf5QlVw/ep94rGdqPVHFGLGMdRcLym1fGdy8Z7uFFtB0M0WmqudfL9GLeWxacI12wfW+ogml1qfRJ9dYtBPQS0ABznOQNVxuw6YHEzsSuJl0JAxivZrwhxZu0dLqUhwOiyn+yQ9AoXmAW9mF8qvrdJHgsP9Pq2abgMdTEPCrjO7CTAUZvXmu5Qu7rtpN8zg8ouR0MaoFX6Vi46/LLEP12pZcKTw/UIJQFBw+xyzyDoDje/ohLraZ27PwOip7cDDC8D8ozdKN6NTZx51SOMhbl0/ApRXqAc6NsUePROcuJHv1xfw/JKDL8GGW0ub/zSopyBea+d9HBjn4lY4KcT9SGzpBLI6710KMrXPT7CtjaX8uj0y6u0xGf9O7B8nmk/wlxFR+cRaqhlFFFjxJJVeIN+bNIhrOz08Smv9wEqPnC9r1i2qRfD8Se/3VVW1kJuf0aU4+q1AoVVBlMXTozH/Mv4eJOuY2oRq/ttvSz6Bfd4oyEIcdjX54NRoEUSb7V9wMJNFTQ9kDm81ePkZTvHYs2MtlBzqkqhMrE6BrIC5yzTJMmAAYP0Myi2GxYXoHpzIYFvh92xGi6brewCVv7gofYa5lt1D2MBNo0CP33aydM0LYPNwqSnPQK9hzvZxuYJVbFKeAezhde9qpYBl7TXS9T70P/faTyMhPR1gpDtOxsL6GU/HVwLDciTsxAHk/c07Lw7rzg==
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6272.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 278362f2-44fe-4a71-6939-08dbc99965bb
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2023 14:01:27.6987
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zJhOhtdtknr4vpFeQ6eoPQQhaFw13A4c5Gck3ZDZjpmPMo+u+nrAL8iCVoW1Z7BZdyP9MPA2JWgPhQB1zMGYdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6945
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        SPF_HELO_PASS,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 10 Oct 2023 07:01:38 -0700 (PDT)

On Tue, Oct 10, 2023 at 08:29:16PM +0800, Ma Ke wrote:
> In mv_platform_probe(), check the return value of clk_prepare_enable()
> and return the error code if clk_prepare_enable() returns an
> unexpected value.
>=20
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
> ---
>  drivers/ata/sata_mv.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
> index 45e48d653c60..e82786c63fbd 100644
> --- a/drivers/ata/sata_mv.c
> +++ b/drivers/ata/sata_mv.c
> @@ -4123,10 +4123,13 @@ static int mv_platform_probe(struct platform_devi=
ce *pdev)
>  	hpriv->base -=3D SATAHC0_REG_BASE;
> =20
>  	hpriv->clk =3D clk_get(&pdev->dev, NULL);
> -	if (IS_ERR(hpriv->clk))
> +	if (IS_ERR(hpriv->clk)) {
>  		dev_notice(&pdev->dev, "cannot get optional clkdev\n");
> -	else
> -		clk_prepare_enable(hpriv->clk);
> +	} else {
> +		rc =3D clk_prepare_enable(hpriv->clk);
> +		if (rc)
> +			goto err;
> +	}
> =20
>  	for (port =3D 0; port < n_ports; port++) {
>  		char port_number[16];
> --=20
> 2.37.2
>=20

Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>

Nit:
Instead of:
ata: sata_mv: aspeed: fix value check in mv_platform_probe()
something like:
ata: sata_mv: aspeed: check clk_prepare_enable() return code

Might be slightly more descriptive.

Will leave it up to the maintainer though.


Kind regards,
Niklas=