Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <0f66769bb82bdba201ddfc7a826aacf3dc6b2296.camel@iokpp.de>
Subject: Re: [PATCH v4] mmc: Add quirk MMC_QUIRK_BROKEN_CACHE_FLUSH for
 Micron eMMC Q2J54A
From:   Bean Huo <beanhuo@iokpp.de>
To:     ulf.hansson@linaro.org, adrian.hunter@intel.com,
        beanhuo@micron.com, jakub.kwapisz@toradex.com,
        rafael.beims@toradex.com
Cc:     linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Date:   Tue, 10 Oct 2023 16:14:35 +0200
In-Reply-To: <f9beb373-a6c8-ba07-f3d1-c72ecc058806@gmail.com>
References: <20231001194943.658299-1-beanhuo@iokpp.de>
         <f9beb373-a6c8-ba07-f3d1-c72ecc058806@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Precedence: bulk


Hi Ulf,

ping you again, have you recieved this mail?

Kind regards,
Bean


On Wed, 2023-10-04 at 21:07 +0200, Bean Huo wrote:
> Hi Ulf,
>=20
> Any comments on this version?
>=20
> Kind regards,
>=20
> Beam
>=20
> On 01.10.23 9:49 PM, Bean Huo wrote:
> > From: Bean Huo <beanhuo@micron.com>
> >=20
> > Micron MTFC4GACAJCN eMMC supports cache but requires that flush
> > cache
> > operation be allowed only after a write has occurred. Otherwise,
> > the
> > cache flush command or subsequent commands will time out.
> >=20
> > Signed-off-by: Bean Huo <beanhuo@micron.com>
> > Signed-off-by: Rafael Beims <rafael.beims@toradex.com>
> > Cc: stable@vger.kernel.org
> >=20
> > ---
> > Changelog:
> >=20
> > v3--v4:
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 1. Add helper function for this quirk in
> > drivers/mmc/core/card.h.
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 2. Set card->written_flag only for REQ_O=
P_WRITE.
> > v2--v3:
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 1. Set card->written_flag in mmc_blk_mq_=
issue_rq().
> > v1--v2:
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 1. Add Rafael's test-tag, and Co-develop=
ed-by.
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 2. Check host->card whether NULL or not =
in
> > __mmc_start_request() before asserting host->card->->quirks