Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Tue, 10 Oct 2023 10:18:29 -0400
From:   Frank Li <Frank.li@nxp.com>
To:     Manivannan Sadhasivam <mani@kernel.org>
Cc:     hch@infradead.org, bhelgaas@google.com,
        christophe.jaillet@wanadoo.fr, imx@lists.linux.dev, kw@linux.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        lpieralisi@kernel.org, minghuan.Lian@nxp.com, mingkai.hu@nxp.com,
        robh@kernel.org, roy.zang@nxp.com
Subject: Re: [PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask
Message-ID: <ZSVdNXBiUxIq/87p@lizhi-Precision-Tower-5810>
References: <20230926140445.3855365-1-Frank.Li@nxp.com>
 <20230927124621.GD18050@thinkpad>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230927124621.GD18050@thinkpad>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXZVaVh6S0kyRjZlTTRXL0ZqcmprR2RWeFJub2lGbTdXVmxIMDNzbEpFODZw?=
 =?utf-8?B?MERxa1NwSWNTeklEK2M1YWxDREJvUXU0bjJNeElNT0hoRFdSKy92dVJpTFo5?=
 =?utf-8?B?ZGx4anVKS0dlazhuWUNsaFhVRzB5UmhmNUNKT3gyekdCZlN5OWdCT2ZSaWZI?=
 =?utf-8?B?cWdTWDJMMTR0WktreHg5RnBkSkJmODBxdGlkQ3kvMzdzOE9LMTg4QXIwUHZO?=
 =?utf-8?B?VmU4aHM5M0x4UXhPUTRMNm5uRU1xYzM5TVZOQ2dvcUtUUytLb1oyWVJEbjBF?=
 =?utf-8?B?cEEvNGV2OWlPemVjcXZYL3QzSnUwcWJWMEtrOEloalA4WktTdHljMzJYRDla?=
 =?utf-8?B?YktZOFRIcTJDaVBHYWRmWnh3QnU4cUQvVkRsRWcwcy9yNUcyaEJEUTUzVGxZ?=
 =?utf-8?B?eXFKNnpHRGpDc09QMmZidld2RkwrdTk4eW1KSXZVZUZnMzJGVzRYWnNSOUdF?=
 =?utf-8?B?TWNab3lJLzh0dHpQbFdWNEFOa3JXQ2ZLTnBGbnFPWlJDTTdtY2JWZDl1WkVu?=
 =?utf-8?B?K1RSbSsvL0dJdWVxRVRSdjlKTG4rUys4a0FVaHVMRytsakpNUUplY0J6YnNK?=
 =?utf-8?B?YXdUK2ZCallEOUxDT1lXOGpPZ2hkOWJ5dEhtdGk4MHlHVmppbll0aUFNUDlw?=
 =?utf-8?B?RSsyZGphN2ExMzJqMnZKam8rWUgwWEZpY2RSdmN2bG1zUVc0UTQ5WkMxVHZi?=
 =?utf-8?B?WmNTQkVzYTRjVnQzSFNuK2hDc3ZzNHIzSHN6elpNWWdQdzRwcFR0ci9VMHU3?=
 =?utf-8?B?YzFXR09GUXgzUDlBdEY0aFh0d0tmMlArL2toNEtjQ0RKZVFiQnBSTk9zbjlO?=
 =?utf-8?B?dnFwSmdXVzlWMnF0dG9VcUNKNFc0YkFRWWJWd1RFRzg0Nkx3aXJUbUN4VytC?=
 =?utf-8?B?YUk2bEFqWEZwZG9IYmFyT1ZpVzU1RUR4Z3YvV3NLZGw2UFF2ejZKOGVwSTdU?=
 =?utf-8?B?YmRDWlVnZURWakVWdTRSWlZLTnhkb0FORDNnUkNRdU5ZeVNWRUpYZnovNUtV?=
 =?utf-8?B?c2NoTngzcWNVYlNzc3ZWTzhwLzNFcWpUaS9MV0RKbnJQdm1UZFhHYmpuU0NM?=
 =?utf-8?B?bkdjOVF3TFd5dnRDOEdwbGJEbXR6R01kaDhTb2hGNzBxK2xLZlNrZnRkb3ln?=
 =?utf-8?B?Ym1WbG5ERVBHbHBTNDBTcFp0K0g5dWVKYXkvemVNMlUzRTFYYXVYZ3pWYkRs?=
 =?utf-8?B?M3RRbFVyVDNyR0xQV3ZHVU9JYVk4cnlRYjVYZDlCTzE4dnIxY0JCbnlrQ3V0?=
 =?utf-8?B?L1JEaFB6Vnl2ME1tWkxOc1pqNVM5cTh5c0ZHMkhNYm8rSjhBWlFGNUgrZ1Ax?=
 =?utf-8?B?N3JjL0N2S1hGQ3lHR0crSEltNE4zSDRiSDhiYXJsN0JhWkJyaXllaUExb05z?=
 =?utf-8?B?Snd3eE1nWEtycTB3ekRVakVTM1VEcStreG4yZHhTVUNCZC9JenAyYkRxYjVI?=
 =?utf-8?B?Q2tOcEphY0FvZ0FyTjd3SDk5Mk81dGFheXZ3TmpTS0FsZFVCS083bDBldXQw?=
 =?utf-8?B?RlIzME9sSmJqOFI5VTVBalJmQy9yS2RybVJOT2taWmJTQ0ttNmZKTDZiYUJ0?=
 =?utf-8?B?ZXRxQ0UzTWZsUmUvL0orNS9lK0FadUlnYXJSRmJJd2t4T0NRSmVrVEpaTWNN?=
 =?utf-8?B?cWs5R29TZkZpWklNTTVHS2w4SHA1Z1VPNGNGNlcxMmNBUWhuYXhpSWV0UE1I?=
 =?utf-8?B?Mkdpa2hxQlBDN2xOTFJmN0I0Z1lReStZTGFLY1hyaVAwSHhQT1JTY1NxZHBJ?=
 =?utf-8?B?d2llWWhtR1AxQ2pVSTVEbS9TOUxHZ3dUUFA1WlNqR1ovdkZVMU5sU3Zub051?=
 =?utf-8?B?OFczMGxGQUxEUndDd01iS2Y3WVM0V2FsM1d0YVQreGhDaHJhbERMRVlPZi9n?=
 =?utf-8?B?bWV2cFBZbHROY1g2VnBOQldjN0R6akZ1M2tRTDh6a1NMSnZ2VXFCTVo0NGRv?=
 =?utf-8?B?U2U4cVBYdWppczROOHJmcHZVd2dSUE45aFhlVGtCamFSM1E4dG84WXdjZXhy?=
 =?utf-8?B?dmRzZHcwSEt4SDNYTWJGdnE5SDM4Sm5UbGFVM0NjOG02czBZOXFDaWg0MTgw?=
 =?utf-8?B?bWZCS1ZHVCtnSHc4dkUxY1gvMnVFYjV4SlVQdEJ6UmxFcDZWdk1xSzI3WmE5?=
 =?utf-8?Q?ZwiATBWKrRQvfi5vZxGiZ3caM?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf3e999b-8f9d-46a3-5b1a-08dbc99bccc8
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 14:18:39.7446
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qLGx9Ml+zdzHnii9XaCvsNG3mHM2nv/0kClLCBc6ebagT8O80DBx5Ma2xmMcEvDjv6sW7amkficFVebxt7nSLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8997
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 10 Oct 2023 07:19:08 -0700 (PDT)
X-Spam-Level: **

On Wed, Sep 27, 2023 at 02:46:21PM +0200, Manivannan Sadhasivam wrote:
> On Tue, Sep 26, 2023 at 10:04:45AM -0400, Frank Li wrote:
> > From: Guanhua Gao <guanhua.gao@nxp.com>
> > 
> > Set DMA mask and coherent DMA mask to enable 64-bit addressing.
> > 
> > Signed-off-by: Guanhua Gao <guanhua.gao@nxp.com>
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> 
> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

@Lorenzo 

Could you please consider pick this patch?
Manivannan already reviewed and only impact layerscape.

Frank
 

> 
> - Mani
> 
> > ---
> > 
> > Notes:
> >     change from v2 to v3
> >     - remove check return value of dma_set_mask_and_coherent. 64bit mask always
> >     return success.
> >     - remove redundate comments
> >     change from v1 to v2
> >     - Remove 32bit DMA mask set.
> > 
> >  drivers/pci/controller/dwc/pci-layerscape-ep.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > index de4c1758a6c3..2c2c9aaa8700 100644
> > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > @@ -249,6 +249,8 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
> >  
> >  	pcie->big_endian = of_property_read_bool(dev->of_node, "big-endian");
> >  
> > +	dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
> > +
> >  	platform_set_drvdata(pdev, pcie);
> >  
> >  	ret = dw_pcie_ep_init(&pci->ep);
> > -- 
> > 2.34.1
> > 
> 
> -- 
> மணிவண்ணன் சதாசிவம்