Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Tue, 10 Oct 2023 10:21:24 -0400
From:   Frank Li <Frank.li@nxp.com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc:     aisheng.dong@nxp.com, bhelgaas@google.com,
        devicetree@vger.kernel.org, festevam@gmail.com,
        imx@lists.linux.dev, jdmason@kudzu.us, kernel@pengutronix.de,
        kishon@kernel.org, kw@linux.com,
        linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
        linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
        lorenzo.pieralisi@arm.com, lpieralisi@kernel.org, maz@kernel.org,
        s.hauer@pengutronix.de, shawnguo@kernel.org, tglx@linutronix.de
Subject: Re: [PATCH v2 0/5] Add RC-to-EP doorbell with platform MSI controller
Message-ID: <ZSVd5GN7lJUfdF8L@lizhi-Precision-Tower-5810>
References: <20230911220920.1817033-1-Frank.Li@nxp.com>
 <ZQtmpL2vCMgR+Upu@lizhi-Precision-Tower-5810>
 <20230930090249.GB3564@thinkpad>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230930090249.GB3564@thinkpad>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UG9UWHF2UGZiSmRoeGd4UjZNcUE3b0dCMk5lV3dOczlNUG1iaHJZQllDdDlu?=
 =?utf-8?B?Y08rS0xxQjVTV2FqZ2UreFV1MWo3b3hIYzcxWUt4bm5HZElYQzF1SDBsbmcr?=
 =?utf-8?B?OE5lZzVROFVmNjhQM0NVQ3pWL0JKZHB0Ky9NandpOTR0MGJDaEtnYjFnU0Vt?=
 =?utf-8?B?ZEVuKzhFdWJHdWowMWdYNVM3aE5JMURHai9DL3lYcC9pOHhhcitGUjUwbk1N?=
 =?utf-8?B?eVltL2pyb3h0QzNqT1N4dU1pSTd4ZkhVRkd1NXhxQTVGb01oUW5qOW1QTHI1?=
 =?utf-8?B?SUJUMGphakQwamN5N1JvUW9PaHE3Rk5CWStpb05rZUJTdmRtancycTk1K0g3?=
 =?utf-8?B?NUVDdEViTThrVXNrWmtaNE8zKzU3SjFuVURXOVV5VmNiNjVhcVJIaWhKdWJO?=
 =?utf-8?B?SU1QNU1WNGZsYTNaM1Q1VFJTd2RlTUZzTGdxdGpUK1ZibFpQcW1xTU82Z2I2?=
 =?utf-8?B?R0pLNlA0ZVU5RlprT0xIdlZDWHAxZHo2Tk9RU3dTZEJpVlpubGl0WlB0R2cz?=
 =?utf-8?B?Tkw5dlFBczVPMkZ5VTlxUW5TQVJnc0tBVEo5LzYrNEYwZmlZVkd3M0hLNjZh?=
 =?utf-8?B?TTVwQzJ6TEszWjBDcFFPK1VEZUF4WHZnZkFHdE9YaFdIbWlpMk9DZjR4Znpj?=
 =?utf-8?B?ek93ZUczem53cURlR052UVVmK05Pa2ZKeExKKzZRa3VUWGs1b2ZFdnl2d0dQ?=
 =?utf-8?B?NmNwcGwrSG9zUEljd3ZwV2NrYXR2bnNvYi9mVjUvQS9RTkdlelNVUVF3TXJt?=
 =?utf-8?B?aW4rVk5PMnJoam1xTzN0bW1XZTRNVVdIZnVDYmx0RzEvcXovb1djTFBqTCt6?=
 =?utf-8?B?ZTZyTU9id0YrSlVGTmUrVXJXc0ZOQXlrazg1dE9PVDNZS2prT1Iyem5zOGVC?=
 =?utf-8?B?TzFmU3d1K0VKSWY0Z1FBcGFXYjNLQ3NWbCt6MWtuK0ZKNFB0cjR0OG9iU21I?=
 =?utf-8?B?dDJvSTBGc0dCdENaLzFRZ0tkcWY0K3V0UWtNOEQ5S2ZXL1B4amdaeXBmRmYx?=
 =?utf-8?B?dHFyODlNeE1UTmRLYUgxSHRtT2t6MEV0M3UvdWl5REl0TXU0VWRQV2l6UnRC?=
 =?utf-8?B?ZkQ0QUNnditHT1V0S2gxNCtMejhvMmM1MExDYVg3RjU5R0VYWjNMbERlNWpG?=
 =?utf-8?B?RnlHWDVKS0tFRENCb0M3a1dOQktZZ2xqUk1IcUFQMEpodDJyMVNPc1F2UFps?=
 =?utf-8?B?N0E5UVl1bGhPT203c0g3dVg3Y04rTlcvbGUzSWhkWGMwN01JYURndUxzYitk?=
 =?utf-8?B?anB5czRuQ3hIQTJMKzVyeWl4TGkxeGVSbVFPOTJZd3JVNUVVd05JbFoveEpv?=
 =?utf-8?B?UE1XMnQyTkZIOE9QU2FKWmgyNzZxc2RBSjVrRThVVE1hd0JoS1FNRFpzbEww?=
 =?utf-8?B?WGZRY25PK3RiK2ttUituMG9oRW9EaDRVd2RST2Q2UktRdHVaMFEvVzZFaFZM?=
 =?utf-8?B?cDRKUnV4bzhWdEVjTmEyOU5BK3Uya0NIYmpvalpoaGNvSDRMYzNlK0QzWTFI?=
 =?utf-8?B?dW9wMVZEVTJKNHh0OHhqcENRUHllajRJa2JEZ1NKTVZRY2FueDI1Z0tjOEcy?=
 =?utf-8?B?ZU8wS1BMQ3RkN0hKaVdVcHk0clBXbVdiQUZVeXMxZHZ2QkFURFFZS2lWN3FE?=
 =?utf-8?B?dTdQYWs4Y0ZpcVlMczJmVGpVZWlkQ3Rvc2oxYnVUSVk4WU01VDVpb01UQzlE?=
 =?utf-8?B?N1RWVU1jaUEyWUdXTXhYWUFIQ1ZpY2hvVStydHJkL2U1TFpleU1INlRrTHJH?=
 =?utf-8?B?czdkV2pwL3NZNVdiNmZtRjZ0VXhsbEFrd2tIOW1yd3B1NllQZVc5MGluU3JI?=
 =?utf-8?B?S2J5TTcxeEtIaSs1WnNtUkJTbEJIS0RHeURhUXhJQ3hnSXR6aGRFdDVGZnpQ?=
 =?utf-8?B?T1h4a3hIOTFXRmVGMFM2UlNNRmY5TThjbjFTNE9MTkdCOE5VMEVmV0NOajhS?=
 =?utf-8?B?L0tQK0N1S0dWOU1TZmNqalJWUVoxUDdPdVRJSWtPWEdLT0tIK01jMWRFMkpT?=
 =?utf-8?B?ZzVEanphU2pKaUtydE9oYzNyL1NCV0ZVRHI5NzB0SlFsZ1hvK2JRUGQ0bk9W?=
 =?utf-8?B?VVBvWE5KUmQzUmdDUnFFbmNSbUpGc055dGhRR2JwMjkxRnIwYVBqbGZiM21J?=
 =?utf-8?Q?tpSqgMjmGUENH7kICZvQGJERn?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af9d53cf-3115-462a-ff50-08dbc99c333a
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 14:21:31.6396
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bHo7EjSjeY6b54JTGpUFWxE7hxq8mWy9Zx82eRaEzittO89kAh6SLudcwXt49YEd14DuUNnjMR1iZ7gcRrnVtQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8997
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 10 Oct 2023 07:21:54 -0700 (PDT)
X-Spam-Level: **

On Sat, Sep 30, 2023 at 11:02:49AM +0200, Manivannan Sadhasivam wrote:
> On Wed, Sep 20, 2023 at 05:39:48PM -0400, Frank Li wrote:
> > On Mon, Sep 11, 2023 at 06:09:15PM -0400, Frank Li wrote:
> > > ┌────────────┐   ┌───────────────────────────────────┐   ┌────────────────┐
> > > │            │   │                                   │   │                │
> > > │            │   │ PCI Endpoint                      │   │ PCI Host       │
> > > │            │   │                                   │   │                │
> > > │            │◄──┤ 1.platform_msi_domain_alloc_irqs()│   │                │
> > > │            │   │                                   │   │                │
> > > │ MSI        ├──►│ 2.write_msi_msg()                 ├──►├─BAR<n>         │
> > > │ Controller │   │   update doorbell register address│   │                │
> > > │            │   │   for BAR                         │   │                │
> > > │            │   │                                   │   │ 3. Write BAR<n>│
> > > │            │◄──┼───────────────────────────────────┼───┤                │
> > > │            │   │                                   │   │                │
> > > │            ├──►│ 4.Irq Handle                      │   │                │
> > > │            │   │                                   │   │                │
> > > │            │   │                                   │   │                │
> > > └────────────┘   └───────────────────────────────────┘   └────────────────┘
> > 
> > @mani:
> > 	Do you have chance to review this patch again?
> 
> I was on vacation for past few weeks. Will take a look in the coming week.

Ping?

Frank

> 
> - Mani
> 
> > 
> > Frank
> > 
> > > 
> > > This patches based on old https://lore.kernel.org/imx/20221124055036.1630573-1-Frank.Li@nxp.com/
> > > 
> > > Original patch only target to vntb driver. But actually it is common
> > > method.
> > > 
> > > This patches add new API to pci-epf-core, so any EP driver can use it.
> > > 
> > > The key point is comments from Thomas Gleixner, who suggest use new
> > > PCI/IMS. But arm platform change still not be merged yet.
> > > 
> > > git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git devmsi-v2-arm
> > > 
> > > So I still use existed method implement RC to EP doorbell.
> > > 
> > > If Thomas Gleixner want to continue work on devmsi-v2-arm, I can help test
> > > and update this patch.
> > > 
> > > Change from v1 to v2
> > > - Add missed patch for endpont/pci-epf-test.c
> > > - Move alloc and free to epc driver from epf.
> > > - Provide general help function for EPC driver to alloc platform msi irq.
> > > - Fixed manivannan's comments.
> > > 
> > > Frank Li (5):
> > >   PCI: endpoint: Add RC-to-EP doorbell support using platform MSI
> > >     controller
> > >   PCI: dwc: add doorbell support by use MSI controller
> > >   PCI: endpoint: pci-epf-test: add doorbell test
> > >   misc: pci_endpoint_test: Add doorbell test case
> > >   tools: PCI: Add 'B' option for test doorbell
> > > 
> > >  drivers/misc/pci_endpoint_test.c              |  48 +++++
> > >  .../pci/controller/dwc/pcie-designware-ep.c   |   2 +
> > >  drivers/pci/endpoint/functions/pci-epf-test.c |  59 +++++-
> > >  drivers/pci/endpoint/pci-epc-core.c           | 192 ++++++++++++++++++
> > >  drivers/pci/endpoint/pci-epf-core.c           |  44 ++++
> > >  include/linux/pci-epc.h                       |   6 +
> > >  include/linux/pci-epf.h                       |   7 +
> > >  include/uapi/linux/pcitest.h                  |   1 +
> > >  tools/pci/pcitest.c                           |  16 +-
> > >  9 files changed, 373 insertions(+), 2 deletions(-)
> > > 
> > > -- 
> > > 2.34.1
> > > 
> 
> -- 
> மணிவண்ணன் சதாசிவம்