Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
MIME-Version: 1.0
References: <cover.1696850733.git.viresh.kumar@linaro.org> <957de2a53dde99a653b47af9c95bc17692870294.1696850733.git.viresh.kumar@linaro.org>
 <920a671c-1927-4086-950f-db8e3293a989@linaro.org>
In-Reply-To: <920a671c-1927-4086-950f-db8e3293a989@linaro.org>
From:   Viresh Kumar <viresh.kumar@linaro.org>
Date:   Tue, 10 Oct 2023 19:52:32 +0530
Message-ID: <CAKohpon4aYmr9TxhS8H7fVTU_xyhvErr12qViuYAUEf8RX5DGg@mail.gmail.com>
Subject: Re: [Stratos-dev] [PATCH V3 2/2] xen: privcmd: Add support for ioeventfd
To:     Bill Mills <bill.mills@linaro.org>
Cc:     Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        stratos-dev@op-lists.linaro.org,
        Erik Schilling <erik.schilling@linaro.org>,
        Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,
        linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Bill,

On Tue, 10 Oct 2023 at 18:52, Bill Mills <bill.mills@linaro.org> wrote:
> On 10/9/23 7:29 AM, Viresh Kumar via Stratos-dev wrote:

> > -config XEN_PRIVCMD_IRQFD
> > -     bool "Xen irqfd support"
> > +config XEN_PRIVCMD_EVENTFD
> > +     bool "Xen Ioeventfd and irqfd support"
>
> You certainly know about kernel policies better than I but why the
> CONGIG_ name change?
>
> With this change all downstream distros need to find this and re-enable
> it if they want to keep a working Xen system.
>
> I presume the kernel can still work in the old way and not use your new
> mode correct?
>
> I would certainly change the description but I wonder about keeping the
> CONFIG_ name the same.
>
> No issue if I am obviously wrong and this is done all the time.

You are absolutely right Bill, but this is a special case. The CONFIG option
here (XEN_PRIVCMD_IRQFD) is recently added (by me) and is currently
present in linux-next only. Hopefully this and the other commit will make it
to Linus's master together.

No one using this currently downstream and so life won't be that complicated
for anyone and so I wanted to put this under the same config option, since they
are related too.

Hope it makes sense.

--
Viresh