Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp213881rdg; Tue, 10 Oct 2023 08:17:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGzcIW3QjMUqReN/KaHz6vMtzW8lr/ZWXKw4b5BzPdQTWjbIDHP2Vo/pX8AzKV57TeszUP8 X-Received: by 2002:a17:90a:f517:b0:27c:f8d4:a4ca with SMTP id cs23-20020a17090af51700b0027cf8d4a4camr797729pjb.44.1696951060110; Tue, 10 Oct 2023 08:17:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696951060; cv=none; d=google.com; s=arc-20160816; b=lvF9HrVK4bG30P1RgOQwOAkdzodWvtWRPGpJBxusu2LMQYYARGPmQx8b/AK542nSzz HlsftXo1Mm0gBa7hq7BRy2TlR3OvwjTASN53pFtypdvFW4sam4FdI63l7xrH+K4bgXop 2dH6bHJlLBmA2y/HRN4wwz0Fy+y5zDgMh/haAe4DqX+wtsjT7DQSucU6pxPRGNUEf+Wz ygvcqejlOlsGtIEqr1izCmCpx7z4FvEGrN82tVXVu2F6KKFRwbUil8WI+zUIGfeT8nxe 29e0amA3c4lsW1Ar+3dcnsBUBzvkYNRmCiquRnvfKuNUccn3et5prsHIKmndW5FhnV7p qJWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+dkRlejyTcahjdPzQrenk/TdsIZLs1zSdZv153PSeFs=; fh=Pmv/3wCd/vMMkz6ztZZNrSYr82TrxG1l8ka93ZTHWP8=; b=ZBadOJwITHBfs0q4NS9/RUw+hXTm0EL9BanLI7Ig/aiSG1PTMZQUyYlwBK0+EHKpzt O/S/dRaiWq8xOgONbOYnnNYCwCEr4Ihsux8CzVp8StqLmthpeFlmhu9HUzlk1kmD54ps yp3M5oR152DkwqfIY8ct4wNQfVYFRsc8X9dHyZTvYK8M/gZc7LJ5YDAAkokbnYNNw/eP gBh/XUksN/Ouy9cI7mh2h863vmlNfiEoDI25dY+FjpHJKoJ9qul5P2E0x87n9Us4Qt0y a1ENtdSXxAGIftMmvNVfcf98m5M92d9b2JvZa4/wEO6h8geuVRcrxaIkvvlFM2HuIQqm YfNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=csOEtFfh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id kb11-20020a17090ae7cb00b0027cd01b6cb0si3746364pjb.125.2023.10.10.08.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 08:17:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=csOEtFfh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 9B627822A493; Tue, 10 Oct 2023 08:17:34 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232958AbjJJPRU (ORCPT + 99 others); Tue, 10 Oct 2023 11:17:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232670AbjJJPRR (ORCPT ); Tue, 10 Oct 2023 11:17:17 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F7A8C9; Tue, 10 Oct 2023 08:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696951036; x=1728487036; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cfi2ScUuQ38Rjpas5/iU2szLV7W2WROp/dyzeK87y4E=; b=csOEtFfhoWAPmG3pgKhLABa0dAjecUwK8QWP7LbERrL+bidKI7hA4YgE tEgyBc3Y0xpSKND4DcLlz/tJpdqDxxIdRsXuMX7JvqpjPGOLqh2FKfsPB rUVAe+mP4bzDa6b9jQdSAi4nVdSVZO4iCXOeoD4ZckSIJJMgWiSMaN9Be KxXro7+IaF3U3CwE7P/pr2skxcpF8LMaA0QdYwIB3z1YYJzF7tN77gVB4 GJvqREEGfacXijwQPNM+JUjU6UiYfTei/nWpbaGUUTUPJrDgOPWfz01ff cOsKtPmVq1a5Wlyo069zQIa4vhOzOFAw5wY/GxLn1StgvAEmiGnNoWYhi Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10859"; a="363771593" X-IronPort-AV: E=Sophos;i="6.03,213,1694761200"; d="scan'208";a="363771593" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2023 08:17:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10859"; a="823812776" X-IronPort-AV: E=Sophos;i="6.03,213,1694761200"; d="scan'208";a="823812776" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 10 Oct 2023 08:17:11 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 484EE6DA; Tue, 10 Oct 2023 18:17:10 +0300 (EEST) From: Andy Shevchenko To: Bartosz Golaszewski , Andy Shevchenko , Dipen Patel , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, timestamp@lists.linux.dev, linux-tegra@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Thierry Reding , Jonathan Hunter Subject: [PATCH v1 3/4] hte: tegra194: Remove redundant dev_err() Date: Tue, 10 Oct 2023 18:17:08 +0300 Message-Id: <20231010151709.4104747-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20231010151709.4104747-1-andriy.shevchenko@linux.intel.com> References: <20231010151709.4104747-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 10 Oct 2023 08:17:34 -0700 (PDT) X-Spam-Level: ** There is no need to call the dev_err() function directly to print a custom message when handling an error from platform_get_irq() function as it is going to display an appropriate error message in case of a failure. Signed-off-by: Andy Shevchenko --- drivers/hte/hte-tegra194.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c index 339ff5921ec8..30ef1750a9fa 100644 --- a/drivers/hte/hte-tegra194.c +++ b/drivers/hte/hte-tegra194.c @@ -731,10 +731,8 @@ static int tegra_hte_probe(struct platform_device *pdev) return -ENOMEM; ret = platform_get_irq(pdev, 0); - if (ret < 0) { - dev_err_probe(dev, ret, "failed to get irq\n"); + if (ret < 0) return ret; - } hte_dev->hte_irq = ret; ret = devm_request_irq(dev, hte_dev->hte_irq, tegra_hte_isr, 0, dev_name(dev), hte_dev); -- 2.40.0.1.gaa8946217a0b