Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <5c76da14-e34e-afbd-4265-493c66e0bc60@axis.com>
Date:   Tue, 10 Oct 2023 17:59:38 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [cocci] [PATCH 2/2] scripts: coccicheck: Separate spatch stdout
 and stderr
Content-Language: en-GB
To:     Julia Lawall <julia.lawall@inria.fr>
Cc:     Nicolas Palix <nicolas.palix@imag.fr>, cocci@inria.fr,
        linux-kernel@vger.kernel.org, kernel@axis.com
References: <20231003-coccicheck-v1-0-07d2d900a52a@axis.com>
 <20231003-coccicheck-v1-2-07d2d900a52a@axis.com>
 <alpine.DEB.2.22.394.2310072140340.36842@hadrien>
From:   Anton Eliasson <anton.eliasson@axis.com>
In-Reply-To: <alpine.DEB.2.22.394.2310072140340.36842@hadrien>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTdFdDl4RHMxbWxZZHRic1RXTFRtUTRrVDE2UEsxRW1BWnNld21WQUg5cXND?=
 =?utf-8?B?c2xrQU4xb0RYZXM0azNvMVc5K3B5NGZncExzM3k0WDBxbVdoMzBIQ0JteitO?=
 =?utf-8?B?V1N5eS84b3J3dmdaT1pzc0VIbHprZzNUVUhkYi95WmhvRW1oY0lvalU4QVBG?=
 =?utf-8?B?NDJHdG12UmRkeHlydENBQkNEb2hpekFyM05xajQrVkhIY0FFbnRBNmtRMDUy?=
 =?utf-8?B?U2NyRU54Mk0wd3BSUzl5YjdwNnNPUFZhczdBc29tdldRU2ZkNUwwY2NSRFZi?=
 =?utf-8?B?WFpXQnNDOURCamVla2RDRVdIQWFFL3IrQTZtYTVkd0dsVU54c2plNWhvWkFL?=
 =?utf-8?B?am5aNG80YVNVKzFROElXWGtRNmZLWGhTQUc4cnpoL3IzbWwrczRoWHY4YU1T?=
 =?utf-8?B?Ym54QzNmUEVtcVFWZzh3SHVhTkNVSUhKUFBVWnVVRFk5dDNTYWJBdllncEJR?=
 =?utf-8?B?bXQxZ01WZGYyVkh2N0xSbFU1VU5paUsvbXFwTlUvbW1oemZsTzdDeEVnbnhv?=
 =?utf-8?B?S0JKSW13MDFqUkxMY3lSSmlTa2ZXMi9nK3cvYnVsN3BTQVVuaDB5ZjhuS1k0?=
 =?utf-8?B?aitDZXV3R0pLUE5CNFNaZmNpbWQ1dVB2ZXAxVjFNNGFPWS9oT25CeGd2d2la?=
 =?utf-8?B?a3ROc28yMEwrd0xnK3BFbkxZOFdQZzlURExvVklMMFFLZ2dSbG94aXk0K2Rl?=
 =?utf-8?B?Y25YMXZrV2FjMUJhQ1VRT2hob2ovdjdmOG5VMmhVQzZkZzZHVldZTFFhR05X?=
 =?utf-8?B?R0dVYnlrRFcrWkFTRHp4YWc5ZEc1VWtTZ25PRHBtQk4xWE1lcG1RTEtjell6?=
 =?utf-8?B?NEp2Q3dmNC9tVDloSkZWSCt4YnF5N04rMEV1dENSQmhrMnJieS9NWlFPZk9i?=
 =?utf-8?B?KzRTR3BEdmc2M2JQUVp1MWp0cE9RWmRaOStnNjZqSENzMzBKclFiN3EwTHRU?=
 =?utf-8?B?NFYvVlhkT2p4a0NnVFU5dXBnYzdnMmZUL29XemZBejJMS2xEVm1HeVRvVmh1?=
 =?utf-8?B?NEpjc3NrMkU4Qlh2dDI1MWlTYTNTaWEyeHdUSElyWG5QRVFVM0pXZTdLbXY0?=
 =?utf-8?B?OElKWlVvOVRvRDBUbmxtOTZMSytLYXFFdFU5dS9EbmlWYXhWSFY3b3N2eEYw?=
 =?utf-8?B?TEZkQjdULzFDV0ZHS0FzMmpCcmRuY096Z3oyblVDenhLd2dKSDMrcGorV2pr?=
 =?utf-8?B?RkF0WExnckRKOWlreDZlYVRlejF1NHVWNUFhQU9SaEZiellpd25tejJWOUN2?=
 =?utf-8?B?ay91RTRyVm53TXd5eWdtM3RCT1FFK2VCRUo3UnZna0hKSlZkZ3FFWUVyaGxZ?=
 =?utf-8?B?SnI5RkJSMm5tSlY4R0NHK21SYVNGZm1ubG81ZXl6ODA0NW1jNGNYS1pVbUpz?=
 =?utf-8?B?VThpRTliamdoVTViZGpFOFI0Vnd4ajBNbmFYcUJhRlpsUWczVXVXRWNZcldt?=
 =?utf-8?B?SHFZSzBQWGZWclVweDVUS1owVmpoWW4zQnZVWHNocjl6N0NLeWc5QW1OdHVk?=
 =?utf-8?B?RW40Nm9wTkZwajVjVUtJLzZtblFvUTliWmxPY2ZuZFpqckQxNEFZNFpnc0RX?=
 =?utf-8?B?alNuUll0eDZMNnM3K1I2eFArQ21wRnZFWnJ3RVZUTkFVQUl0MVBZVmsrcnda?=
 =?utf-8?B?ZHRDSWtCanUwWGs3SGk1aGNyY3h0RDYwc05aTnVpZTl1L052OTRQMjNZcjB2?=
 =?utf-8?B?MUNYL0hNN3c1a05YVGJuZ29yQUkyU0hqSVNSamlaRm5oRnJscm41K0NYSUdq?=
 =?utf-8?B?UCtmRVNURnFOSTIvcFJRUFNXNGhpRTNCc1U0em5aMGdkWlNUbDA4dUVITGxV?=
 =?utf-8?B?Y0N6Vjc5ODRxQkxVSlNvTzQyRXhDcGJ5eTlXd2d1MlFMTFcyNjVCc1d1eXEz?=
 =?utf-8?B?QkNrL1JtT2NvTGdNNGNQYXhyZjRnRmlXWmIxNmcrWU9lbXIvTEI4RW1KYXhF?=
 =?utf-8?B?bkFIK1VXM1BadXQ2MjcyekZzRnlERWp5TXdmalYzelpqY0hnSEtOT2JJQzVn?=
 =?utf-8?B?RlJWekMvSFBGUjM1djROVjFuLzdzSlQ5eWE2YWYyeGVYRkVNaU1xU3dNdHB6?=
 =?utf-8?B?RUlWZzFsZWtEbGttYWJyNURLdExlWnh5d3NHa1dsU0g2SU5nMHk2YWo3WDQ2?=
 =?utf-8?Q?Bqzg=3D?=
X-OriginatorOrg: axis.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5007308-7631-4a07-3a4f-08dbc9a9e98d
X-MS-Exchange-CrossTenant-AuthSource: DU0PR02MB10338.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 15:59:40.9360
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JnFlCfVExXkhVfnrFJTsMe3qRTMQSgz6VoNQ6ONWWi2HtKHpLQM7duqw3Yq7KFNc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR02MB7248
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 10 Oct 2023 08:59:58 -0700 (PDT)

On 07/10/2023 21.41, Julia Lawall wrote:
>
> On Tue, 3 Oct 2023, Anton Eliasson wrote:
>
>> This helps automating coccicheck runs by discarding stderr and only
>> looking at the output of stdout. In report mode the only remaining
>> output on stdout is the initial "Please check for false positives"
>> message followed by each spatch warning found.
> What is getting dropped is the spatch command lines indicating the
> semantic patch.  Is this desirable?
>
> julia
It's not ideal but it's the best compromise that I have found. The 
problem I'm trying to solve is to be able to diff the output of two 
coccicheck runs and notify the developer if any new warnings were 
introduced. That requires the output to be stable. spatch is always 
invoked for each cocci file in the same order. However, the output from 
each spatch invocation is not stable as it examines each source file in 
an arbitrary order.

My workaround is to sort the output before diffing. The line-by-line 
sorted output only makes sense if the input is one line per warning 
found and that is why I try to discard all output except the single line 
per spatch warning. While the terse output doesn't tell which semantic 
patch file generated the warning, it does usually contain the offending 
file, line number and a summary of the issue.


Anton
>
>> Signed-off-by: Anton Eliasson <anton.eliasson@axis.com>
>> ---
>>   scripts/coccicheck | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/coccicheck b/scripts/coccicheck
>> index 95a312730e98..7e7c44125f47 100755
>> --- a/scripts/coccicheck
>> +++ b/scripts/coccicheck
>> @@ -146,8 +146,8 @@ run_cmd_parmap() {
>>                   echo $@>>$DEBUG_FILE
>>                   $@ 2>>$DEBUG_FILE
>>           else
>> -                echo $@
>> -                $@ 2>&1
>> +                echo $@ >&2
>> +                $@
>>   	fi
>>
>>   	err=$?
>>
>> --
>> 2.30.2
>>
>>