Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932825AbXKOTnj (ORCPT ); Thu, 15 Nov 2007 14:43:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932091AbXKOTna (ORCPT ); Thu, 15 Nov 2007 14:43:30 -0500 Received: from scrub.xs4all.nl ([194.109.195.176]:3060 "EHLO scrub.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763302AbXKOTn3 (ORCPT ); Thu, 15 Nov 2007 14:43:29 -0500 Date: Thu, 15 Nov 2007 20:43:27 +0100 (CET) From: Roman Zippel X-X-Sender: roman@scrub.home To: Sam Ravnborg cc: LKML Subject: Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets In-Reply-To: <20071115192555.GD23914@uranus.ravnborg.org> Message-ID: References: <20071110204038.GA13140@uranus.ravnborg.org> <11947274093185-git-send-email-sam@ravnborg.org> <11947274091127-git-send-email-sam@ravnborg.org> <20071114220840.GB10920@uranus.ravnborg.org> <20071115192555.GD23914@uranus.ravnborg.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1217 Lines: 33 Hi, On Thu, 15 Nov 2007, Sam Ravnborg wrote: > > > The value can be supplied on the command-line so we need to validate input. > > > > Is there a need for this? > Yes. We would like to set 64BIT or not in other than x86 cases. > And way forward was not to override ARCH as in the x86 case. Can we please can get some consistency in this? We have a .config file for a reason, what's wrong with using it? > > Please revert the K64BIT changes and use this instead. > > I will finish up your patch and target it for next merge window. Why can't this be fixed properly now? You don't even need this patch, just use ARCH to set 64BIT in the Kconfig as I've shown. > > These are two different uses, when reading a .config only the basic syntax > > is checked, but not the value itself. > This is wrong considering the amount of people that hand edit the .config file. It's not, the actual symbol value is set later depending on the dependency constraints. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/