Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <59939570-3779-ef90-2a72-7be32a30e368@nvidia.com>
Date:   Tue, 10 Oct 2023 09:12:09 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.1
Subject: Re: [PATCH v1 1/1] hte: Use kasprintf() instead of fixed buffer
 formatting
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        timestamp@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20231010141123.3909596-1-andriy.shevchenko@linux.intel.com>
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <20231010141123.3909596-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnRwUElLTkxuOFJyeFpKQm13dEVORzBua1RWS2xwN1V4U3ZiK1RWemhGSUps?=
 =?utf-8?B?cXloM0VwMmZXMEkvaUFjVGVjMytJNCtQOU1aWlhYUVVUR2VNM0lwUStpUXhr?=
 =?utf-8?B?bk10V254SUptaDZDUUFZQWpSbncydWNDeEpDQlJCR29TOXZiMlEvMXZ2dW96?=
 =?utf-8?B?U1BUU1BPYWdST0JWUG51WXZ6TE9oeEtBT1RpQUVhMU83U1hPTk80Mmsyejc0?=
 =?utf-8?B?cUw0L2J6KzBLUlZXZ3ZrdGFqOVFqeGtZbEdzWUZmWHI3bEJUdHhNVG5IS2FD?=
 =?utf-8?B?WllNcnpldXhhaFpZbndJN0UxeWFwZmxmSyticCtMWXUrcFpKc29BbFFZck9F?=
 =?utf-8?B?Z0JmMDdYUW1vbWNxcnRUeCtVMkFKVUlhWlE0dFY0NURIZ21PVXAveEwvcWpO?=
 =?utf-8?B?ZjBmUGFIeDJId09SVzc0SUROaVJBaGJreHluWjhmbEhVZ21ONjcvRDAxeTB5?=
 =?utf-8?B?dHRwT2l0RVlrL1g2SmM4M1JOYUl6RW9aVVV1QlFTeEp1MTNwR0wrVnM2WWxT?=
 =?utf-8?B?TjVoemV1ZTlTOE1Rck04clhtTS8rZ2JIcXpNM2dITzZpeDJUcnE5VWtCWFVE?=
 =?utf-8?B?TktYUHdHTnU0UE9zWVdrcTg4UFpnMUg0U252TlM0cWhIeDVzeDJzbWtvSXBL?=
 =?utf-8?B?d2xzWXNnN2xTMlNyeTM0SFJXUVErQUR1d21yQzY3ZUZBQVNSdm5DN3V4SHpO?=
 =?utf-8?B?allCdWV6b2xpMXpCRFlJTUE4Z0s1NVNWbkJYK0hPZnRFeEkxSFlHMEd3UHA3?=
 =?utf-8?B?dmtyUzRNRDhZbGsxRmh5MFBseWd2RHoxU1JWMllJNVl5UGNJb0E1aHgzWlY3?=
 =?utf-8?B?b2prYWJBSG9RaTJWL2toaENCZElIMk5BODZYbFZ3aFFiVlYxQjkvdSs2NUdD?=
 =?utf-8?B?T1hPN0laZmtnRkVMckJ1bEQremIzajRNRHVFbE5BbldHMVAvb243bUhVMHd0?=
 =?utf-8?B?RTg5WlgvYVlTVGFhaXM2KzlZUnBFRmZxbVBIa0xqZExQaDdYYkpjU2NaSXQ1?=
 =?utf-8?B?Ly9BWEFzeHdKeWgwcDRJMUJRQWNuM3hCQ0lVaVpBTEJaREFMZmRSZmczZVQr?=
 =?utf-8?B?Ny9GTlBxMTBDdjRxdlN1VmR6Q3NwQ0djUnlGSWw3M3dIUWdLdHV1eHFlL0RY?=
 =?utf-8?B?dkNHTmFocVNGMUxvd1A2dnYrVHZuUSs4eUJLV0xGT0FiUmF4YVlyWHZVZ0Ji?=
 =?utf-8?B?NjhlcWNnM3VLd0dWbklaT1BUU1kxM1F3SUd1MUEwc0dlQllVTmQ1dHUxSlpQ?=
 =?utf-8?B?VFVCdEI3T1pRSTBOSkVaL08zcitiSlNjbms4ZGhQczk1eWJZREQ4Qy8rczRk?=
 =?utf-8?B?c2gwMVRiVzJqNVowTWRtRnJKWkt5T2lrR3JOdmNQdDdHL3dwQU1JcHBLcjUr?=
 =?utf-8?B?SXZuQTZsakFmbGluNkdaeHAwQ0R6RC92Y2ppZlQxMk1jZm9MQzFOOFN5ci8x?=
 =?utf-8?B?WmVTdTB2NGxYQmI2V1A1RzhEcW1Rck1YcTdEQmw2ZUt2enpOcC9udksvbUR1?=
 =?utf-8?B?clFPT3BvS2hoa01SUG9sbkw5MEFWN3FDaHd4M3JHM2xhMU9xVjkvaWc3cnVr?=
 =?utf-8?B?WEV0S2FNcUEwaUw2MURSZDhIcU1jRFhPVW1JMHRvM1djU1ZKemI1ZjRod01W?=
 =?utf-8?B?b3ZlOExZVUh2SnlLVmg2b0VZanNJUytXM3lYYmtFMGJTenZIWi93OUkxb2xG?=
 =?utf-8?B?Snl6dVUyOFJPeVd5MlllbjJqVUIrN3BNSXN5Y0NpSGtaYnl6RTlhYzZhanNn?=
 =?utf-8?B?R1Y2ZXJFNHpGTzM3NG5QSjRvdUpnVEZqTk5oLzFscE5WVGxWR0djZU5kWGhX?=
 =?utf-8?B?bU80NDVMc0dVY2ZaMWoyVWJkSkxUOXJRVjJoSHRFQW9IbFUyMUxUTmlWOW01?=
 =?utf-8?B?NDJ3VHhpc2JTYXdvUW9QSkdzZjF1cWFoUFV5SkVYOWh1ZmdnS0dTMGdLcUR3?=
 =?utf-8?B?eG9Falo0L0VOdTM3bVVSeXdVbHdCTXkvYUZSUm1CRHYvWm9NRExENXFFc2pQ?=
 =?utf-8?B?UXQ0cnFiYWthUHA4MDRrTjU0ZXpKK1BzNkZhZmYvVFBBUDZlVHhWamhjSmVa?=
 =?utf-8?B?eWV4MTlKd28ya3htVzUvTkN1SWk3amhwK0NvUXJhT2dNam5FQm96Tmdzc1p6?=
 =?utf-8?Q?tb362PeuorvZQ8QI6mT7a5Cfe?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c31876ca-072f-4b83-af93-08dbc9aba9c3
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6604.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 16:12:12.9576
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aSOcJHsPXvRsDSyhsZE5Ylq/xs+i/CDfBV77U//9hjIlMY6SSDaI67DfcumpBtC037C1P3TeycPzjma8cYl5XQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5849
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 10 Oct 2023 09:12:40 -0700 (PDT)

On 10/10/23 7:11 AM, Andy Shevchenko wrote:
> Improve readability and maintainability by replacing a hardcoded string
> allocation and formatting by the use of the kasprintf() helper.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/hte/hte.c | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/hte/hte.c b/drivers/hte/hte.c
> index 1fd8d2d4528b..23a6eeb8c506 100644
> --- a/drivers/hte/hte.c
> +++ b/drivers/hte/hte.c
> @@ -17,8 +17,6 @@
>  #include <linux/debugfs.h>
>  #include <linux/device.h>
>  
> -#define HTE_TS_NAME_LEN		10
> -
>  /* Global list of the HTE devices */
>  static DEFINE_SPINLOCK(hte_lock);
>  static LIST_HEAD(hte_devices);
> @@ -389,13 +387,10 @@ static int __hte_req_ts(struct hte_ts_desc *desc, hte_ts_cb_t cb,
>  
>  	atomic_inc(&gdev->ts_req);
>  
> -	ei->line_name = NULL;
> -	if (!desc->attr.name) {
> -		ei->line_name = kzalloc(HTE_TS_NAME_LEN, GFP_KERNEL);
> -		if (ei->line_name)
> -			scnprintf(ei->line_name, HTE_TS_NAME_LEN, "ts_%u",
> -				  desc->attr.line_id);
> -	}
> +	if (desc->attr.name)
> +		ei->line_name = NULL;
> +	else
> +		ei->line_name = kasprintf(GFP_KERNEL, "ts_%u", desc->attr.line_id);
>  
>  	hte_ts_dbgfs_init(desc->attr.name == NULL ?
>  			  ei->line_name : desc->attr.name, ei);
Reviewed-by: Dipen Patel <dipenp@nvidia.com>