Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Tue, 10 Oct 2023 17:17:16 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Deepak Gupta <debug@rivosinc.com>
Cc:     linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>
Subject: Re: [PATCH v1 RFC Zisslpcfi 15/20] sslp prctl: arch-agnostic prctl
 for shadow stack and landing pad instr
Message-ID: <c4a77a1b-ae13-4071-98e8-25235e8058b7@sirena.org.uk>
References: <20230213045351.3945824-1-debug@rivosinc.com>
 <20230213045351.3945824-16-debug@rivosinc.com>
 <7c4448d1-4622-436f-8779-f52c4f011783@sirena.org.uk>
 <CAKC1njQuw_nzbQ07BGAQOi3C=vr35JhAc6-TB5nzY3zG3Nff3Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ACAhjzT85bg724HA"
Content-Disposition: inline
In-Reply-To: <CAKC1njQuw_nzbQ07BGAQOi3C=vr35JhAc6-TB5nzY3zG3Nff3Q@mail.gmail.com>
Precedence: bulk


--ACAhjzT85bg724HA
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 09, 2023 at 02:22:51PM -0700, Deepak Gupta wrote:
> On Wed, Jun 7, 2023 at 1:22=E2=80=AFPM Mark Brown <broonie@kernel.org> wr=
ote:

> > On Sun, Feb 12, 2023 at 08:53:44PM -0800, Deepak Gupta wrote:

> > > +int __weak arch_get_shadow_stack_status(struct task_struct *t, unsig=
ned long __user *status)
> > > +{
> > > +     return -EINVAL;
> > > +}

> > Having looked at this further is there any great reason why the status
> > is passed as a pointer?  It seems needless effort.

> I was trying to be cleaner here to not overload returned status with a po=
inter.
> You could say that any negative value is an error. I don't have any
> favorites here.

OK, thanks - I changed it to treat negative codes as errors, I'll leave
things like that.

--ACAhjzT85bg724HA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmUleQsACgkQJNaLcl1U
h9A+oQf+LpsNDfAqDS2nwgFHdh60JolPY8rn6NrF842aj9Y2olxRwTCSw34whng7
5EBGkVw6506Spqsle1zvqdXSzA1VyWFfzZKJ+04ZsH6N6Wn42m0gry/3RnKcphxW
gF3Yz5JSyLRam8m4pGDM3OBDwLReOxIgxhOZs4VjWbaRdlL2MJ4y+gqHYx7JJRCT
fpF5koeDVyLxvPNJVwMHtHRE6adGLqd91yFi/UNL/ERzz4LhYxixwpk8LcZJzLcT
gjlqKcScF9TvoCqnItWWO6ulsNqN/fxtAvK+PYBCEZfiPqMktLztr2oeq238hdg0
3oCa+f5qhH7JF0SgvRu+mPmURwO7Lg==
=7Bqv
-----END PGP SIGNATURE-----

--ACAhjzT85bg724HA--